Re: Review Request 29828: Patch ResourceManager into OSS Aurora.

2015-01-12 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29828/ --- (Updated Jan. 13, 2015, 12:42 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 29828: Patch ResourceManager into OSS Aurora.

2015-01-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29828/#review67762 --- Ship it! Master (5ce076b) is green with this patch. ./build-suppo

Re: Review Request 29828: Patch ResourceManager into OSS Aurora.

2015-01-12 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29828/ --- (Updated Jan. 13, 2015, 12:09 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 29828: Patch ResourceManager into OSS Aurora.

2015-01-12 Thread Brian Wickman
> On Jan. 12, 2015, 11:33 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/executor/common/resource_manager.py, lines > > 24-25 > > > > > > Mind adding a TODO to drop the cpu and ram portions of this? Those

Re: Review Request 29828: Patch ResourceManager into OSS Aurora.

2015-01-12 Thread Kevin Sweeney
> On Jan. 12, 2015, 3:33 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/executor/common/resource_manager.py, lines > > 24-25 > > > > > > Mind adding a TODO to drop the cpu and ram portions of this? Those

Re: Review Request 29828: Patch ResourceManager into OSS Aurora.

2015-01-12 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29828/#review67749 --- Ship it! Ship It! - Joshua Cohen On Jan. 12, 2015, 11:40 p.m., B

Re: Review Request 29828: Patch ResourceManager into OSS Aurora.

2015-01-12 Thread Brian Wickman
> On Jan. 12, 2015, 11:33 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/executor/common/resource_manager.py, lines > > 24-25 > > > > > > Mind adding a TODO to drop the cpu and ram portions of this? Those

Re: Review Request 29828: Patch ResourceManager into OSS Aurora.

2015-01-12 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29828/ --- (Updated Jan. 12, 2015, 11:40 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 29828: Patch ResourceManager into OSS Aurora.

2015-01-12 Thread Brian Wickman
> On Jan. 12, 2015, 11:35 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py, line > > 100 > > > > > > nit: should this be 2 spaces, not 4? indentation is 2, continuatio

Re: Review Request 29828: Patch ResourceManager into OSS Aurora.

2015-01-12 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29828/#review67744 --- src/main/python/apache/aurora/executor/bin/thermos_executor_main.py

Re: Review Request 29828: Patch ResourceManager into OSS Aurora.

2015-01-12 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29828/#review67743 --- Ship it! src/main/python/apache/aurora/executor/common/resource_ma

Review Request 29828: Patch ResourceManager into OSS Aurora.

2015-01-12 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29828/ --- Review request for Aurora, Joshua Cohen and Kevin Sweeney. Bugs: AURORA-1002