Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-20 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review73384
---


This patch does not apply cleanly on master (e5de618), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 20, 2015, 11:09 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> ---
> 
> (Updated Feb. 20, 2015, 11:09 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1062
> https://issues.apache.org/jira/browse/AURORA-1062
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Instrument the HealthChecker to export stats.
> 
> HealthChecker plugin now should export three stats:
>   consecutive_failures: number of consecutive failures experienced (resets on 
> success)
>   latency: how long health checks are taking in practice
>   snoozed: whether or not the health checker is snoozed
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 60676ba0fbd8a218fe4309f07de28e2c66d54530 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 624921d68199df098ea51ee8a10815403bf58984 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> a4e215d4422e3ada7b7913eaab105fdf030695c5 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> c8fab307d17949a8157659c4b3944ec7520feb9d 
> 
> Diff: https://reviews.apache.org/r/30647/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-20 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review73338
---

Ship it!


Ship It!

- Bill Farner


On Feb. 20, 2015, 11:09 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> ---
> 
> (Updated Feb. 20, 2015, 11:09 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1062
> https://issues.apache.org/jira/browse/AURORA-1062
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Instrument the HealthChecker to export stats.
> 
> HealthChecker plugin now should export three stats:
>   consecutive_failures: number of consecutive failures experienced (resets on 
> success)
>   latency: how long health checks are taking in practice
>   snoozed: whether or not the health checker is snoozed
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 60676ba0fbd8a218fe4309f07de28e2c66d54530 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 624921d68199df098ea51ee8a10815403bf58984 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> a4e215d4422e3ada7b7913eaab105fdf030695c5 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> c8fab307d17949a8157659c4b3944ec7520feb9d 
> 
> Diff: https://reviews.apache.org/r/30647/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-20 Thread Bill Farner 


> On Feb. 20, 2015, 10:30 p.m., Bill Farner wrote:
> > src/test/python/apache/aurora/executor/common/test_health_checker.py, line 
> > 136
> > 
> >
> > Is it necessary to use a real clock + real threads + sleeps in this 
> > test?  I'm not confident i can confirm that this test will not be flaky 
> > with these in place.
> 
> Brian Wickman wrote:
> this is not a real clock.  it's a fake clock that allows us to test 
> threaded behavior:
> 
> 
> https://github.com/twitter/commons/blob/master/src/python/twitter/common/testing/clock.py

Aha!  Thanks for clarifying.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review73324
---


On Feb. 20, 2015, 11:09 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> ---
> 
> (Updated Feb. 20, 2015, 11:09 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1062
> https://issues.apache.org/jira/browse/AURORA-1062
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Instrument the HealthChecker to export stats.
> 
> HealthChecker plugin now should export three stats:
>   consecutive_failures: number of consecutive failures experienced (resets on 
> success)
>   latency: how long health checks are taking in practice
>   snoozed: whether or not the health checker is snoozed
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 60676ba0fbd8a218fe4309f07de28e2c66d54530 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 624921d68199df098ea51ee8a10815403bf58984 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> a4e215d4422e3ada7b7913eaab105fdf030695c5 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> c8fab307d17949a8157659c4b3944ec7520feb9d 
> 
> Diff: https://reviews.apache.org/r/30647/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-20 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/
---

(Updated Feb. 20, 2015, 11:09 p.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

Be explicit that the latency metric is in seconds.


Bugs: AURORA-1062
https://issues.apache.org/jira/browse/AURORA-1062


Repository: aurora


Description
---

Instrument the HealthChecker to export stats.

HealthChecker plugin now should export three stats:
  consecutive_failures: number of consecutive failures experienced (resets on 
success)
  latency: how long health checks are taking in practice
  snoozed: whether or not the health checker is snoozed


Diffs (updated)
-

  src/main/python/apache/aurora/executor/common/health_checker.py 
60676ba0fbd8a218fe4309f07de28e2c66d54530 
  src/main/python/apache/aurora/executor/common/status_checker.py 
624921d68199df098ea51ee8a10815403bf58984 
  src/test/python/apache/aurora/executor/common/test_health_checker.py 
a4e215d4422e3ada7b7913eaab105fdf030695c5 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
c8fab307d17949a8157659c4b3944ec7520feb9d 

Diff: https://reviews.apache.org/r/30647/diff/


Testing
---

./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::


Thanks,

Brian Wickman

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-20 Thread Brian Wickman 


> On Feb. 20, 2015, 10:30 p.m., Bill Farner wrote:
> > src/test/python/apache/aurora/executor/common/test_health_checker.py, line 
> > 136
> > 
> >
> > Is it necessary to use a real clock + real threads + sleeps in this 
> > test?  I'm not confident i can confirm that this test will not be flaky 
> > with these in place.

this is not a real clock.  it's a fake clock that allows us to test threaded 
behavior:

https://github.com/twitter/commons/blob/master/src/python/twitter/common/testing/clock.py


> On Feb. 20, 2015, 10:30 p.m., Bill Farner wrote:
> > src/main/python/apache/aurora/executor/common/health_checker.py, line 161
> > 
> >
> > nit - can you include the unit in the name?  i've seen time-based 
> > things misused more often than i care to recall

sure


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review73324
---


On Feb. 20, 2015, 7:33 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> ---
> 
> (Updated Feb. 20, 2015, 7:33 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1062
> https://issues.apache.org/jira/browse/AURORA-1062
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Instrument the HealthChecker to export stats.
> 
> HealthChecker plugin now should export three stats:
>   consecutive_failures: number of consecutive failures experienced (resets on 
> success)
>   latency: how long health checks are taking in practice
>   snoozed: whether or not the health checker is snoozed
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 60676ba0fbd8a218fe4309f07de28e2c66d54530 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 624921d68199df098ea51ee8a10815403bf58984 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> a4e215d4422e3ada7b7913eaab105fdf030695c5 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> c8fab307d17949a8157659c4b3944ec7520feb9d 
> 
> Diff: https://reviews.apache.org/r/30647/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-20 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review73324
---



src/main/python/apache/aurora/executor/common/health_checker.py


nit - can you include the unit in the name?  i've seen time-based things 
misused more often than i care to recall



src/test/python/apache/aurora/executor/common/test_health_checker.py


Is it necessary to use a real clock + real threads + sleeps in this test?  
I'm not confident i can confirm that this test will not be flaky with these in 
place.


- Bill Farner


On Feb. 20, 2015, 7:33 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> ---
> 
> (Updated Feb. 20, 2015, 7:33 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1062
> https://issues.apache.org/jira/browse/AURORA-1062
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Instrument the HealthChecker to export stats.
> 
> HealthChecker plugin now should export three stats:
>   consecutive_failures: number of consecutive failures experienced (resets on 
> success)
>   latency: how long health checks are taking in practice
>   snoozed: whether or not the health checker is snoozed
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 60676ba0fbd8a218fe4309f07de28e2c66d54530 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 624921d68199df098ea51ee8a10815403bf58984 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> a4e215d4422e3ada7b7913eaab105fdf030695c5 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> c8fab307d17949a8157659c4b3944ec7520feb9d 
> 
> Diff: https://reviews.apache.org/r/30647/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-20 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review73308
---

Ship it!


Master (e0e3f2e) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 20, 2015, 7:33 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> ---
> 
> (Updated Feb. 20, 2015, 7:33 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1062
> https://issues.apache.org/jira/browse/AURORA-1062
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Instrument the HealthChecker to export stats.
> 
> HealthChecker plugin now should export three stats:
>   consecutive_failures: number of consecutive failures experienced (resets on 
> success)
>   latency: how long health checks are taking in practice
>   snoozed: whether or not the health checker is snoozed
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 60676ba0fbd8a218fe4309f07de28e2c66d54530 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 624921d68199df098ea51ee8a10815403bf58984 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> a4e215d4422e3ada7b7913eaab105fdf030695c5 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> c8fab307d17949a8157659c4b3944ec7520feb9d 
> 
> Diff: https://reviews.apache.org/r/30647/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-20 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/
---

(Updated Feb. 20, 2015, 7:33 p.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

Address Bill's feedback.


Bugs: AURORA-1062
https://issues.apache.org/jira/browse/AURORA-1062


Repository: aurora


Description
---

Instrument the HealthChecker to export stats.

HealthChecker plugin now should export three stats:
  consecutive_failures: number of consecutive failures experienced (resets on 
success)
  latency: how long health checks are taking in practice
  snoozed: whether or not the health checker is snoozed


Diffs (updated)
-

  src/main/python/apache/aurora/executor/common/health_checker.py 
60676ba0fbd8a218fe4309f07de28e2c66d54530 
  src/main/python/apache/aurora/executor/common/status_checker.py 
624921d68199df098ea51ee8a10815403bf58984 
  src/test/python/apache/aurora/executor/common/test_health_checker.py 
a4e215d4422e3ada7b7913eaab105fdf030695c5 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
c8fab307d17949a8157659c4b3944ec7520feb9d 

Diff: https://reviews.apache.org/r/30647/diff/


Testing
---

./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::


Thanks,

Brian Wickman

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-20 Thread Joe Smith 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review73304
---

Ship it!


This is awesome- thank you!

- Joe Smith


On Feb. 17, 2015, 5 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> ---
> 
> (Updated Feb. 17, 2015, 5 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1062
> https://issues.apache.org/jira/browse/AURORA-1062
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Instrument the HealthChecker to export stats.
> 
> HealthChecker plugin now should export three stats:
>   consecutive_failures: number of consecutive failures experienced (resets on 
> success)
>   latency: how long health checks are taking in practice
>   snoozed: whether or not the health checker is snoozed
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 60676ba0fbd8a218fe4309f07de28e2c66d54530 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 624921d68199df098ea51ee8a10815403bf58984 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> a4e215d4422e3ada7b7913eaab105fdf030695c5 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> c8fab307d17949a8157659c4b3944ec7520feb9d 
> 
> Diff: https://reviews.apache.org/r/30647/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-17 Thread Bill Farner 


> On Feb. 18, 2015, 1:07 a.m., Bill Farner wrote:
> > src/main/python/apache/aurora/executor/common/health_checker.py, line 151
> > 
> >
> > What's the intended use of this metric?  Since it's exported as a 
> > gauge, it's lossy depending on the poll frequency.
> > 
> > Unless there's a concrete use, i suggest killing this.
> 
> Brian Wickman wrote:
> What would your suggestion be?  Average latency?  There are no 
> implementations of gauge aggregations or anything like that in the python 
> twitter.common.metrics.  I think it can still be valuable to see health check 
> latency.  If 50% of your fleet is reporting 200ms health check intervals it 
> probably indicates a problem?  Or if that number consistently goes up.

How about something that you can use with a rate ratio?  This would mean a 
monotonic counter for number of health checks, and another accumulating latency.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review72856
---


On Feb. 18, 2015, 1 a.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> ---
> 
> (Updated Feb. 18, 2015, 1 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1062
> https://issues.apache.org/jira/browse/AURORA-1062
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Instrument the HealthChecker to export stats.
> 
> HealthChecker plugin now should export three stats:
>   consecutive_failures: number of consecutive failures experienced (resets on 
> success)
>   latency: how long health checks are taking in practice
>   snoozed: whether or not the health checker is snoozed
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 60676ba0fbd8a218fe4309f07de28e2c66d54530 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 624921d68199df098ea51ee8a10815403bf58984 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> a4e215d4422e3ada7b7913eaab105fdf030695c5 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> c8fab307d17949a8157659c4b3944ec7520feb9d 
> 
> Diff: https://reviews.apache.org/r/30647/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-17 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review72860
---

Ship it!


Master (4b43305) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 18, 2015, 1 a.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> ---
> 
> (Updated Feb. 18, 2015, 1 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1062
> https://issues.apache.org/jira/browse/AURORA-1062
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Instrument the HealthChecker to export stats.
> 
> HealthChecker plugin now should export three stats:
>   consecutive_failures: number of consecutive failures experienced (resets on 
> success)
>   latency: how long health checks are taking in practice
>   snoozed: whether or not the health checker is snoozed
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 60676ba0fbd8a218fe4309f07de28e2c66d54530 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 624921d68199df098ea51ee8a10815403bf58984 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> a4e215d4422e3ada7b7913eaab105fdf030695c5 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> c8fab307d17949a8157659c4b3944ec7520feb9d 
> 
> Diff: https://reviews.apache.org/r/30647/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-17 Thread Brian Wickman 


> On Feb. 18, 2015, 1:07 a.m., Bill Farner wrote:
> > src/main/python/apache/aurora/executor/common/health_checker.py, line 151
> > 
> >
> > What's the intended use of this metric?  Since it's exported as a 
> > gauge, it's lossy depending on the poll frequency.
> > 
> > Unless there's a concrete use, i suggest killing this.

What would your suggestion be?  Average latency?  There are no implementations 
of gauge aggregations or anything like that in the python 
twitter.common.metrics.  I think it can still be valuable to see health check 
latency.  If 50% of your fleet is reporting 200ms health check intervals it 
probably indicates a problem?  Or if that number consistently goes up.


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review72856
---


On Feb. 18, 2015, 1 a.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> ---
> 
> (Updated Feb. 18, 2015, 1 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1062
> https://issues.apache.org/jira/browse/AURORA-1062
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Instrument the HealthChecker to export stats.
> 
> HealthChecker plugin now should export three stats:
>   consecutive_failures: number of consecutive failures experienced (resets on 
> success)
>   latency: how long health checks are taking in practice
>   snoozed: whether or not the health checker is snoozed
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 60676ba0fbd8a218fe4309f07de28e2c66d54530 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 624921d68199df098ea51ee8a10815403bf58984 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> a4e215d4422e3ada7b7913eaab105fdf030695c5 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> c8fab307d17949a8157659c4b3944ec7520feb9d 
> 
> Diff: https://reviews.apache.org/r/30647/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-17 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review72858
---

Ship it!


Ship It!

- Joshua Cohen


On Feb. 18, 2015, 1 a.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> ---
> 
> (Updated Feb. 18, 2015, 1 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1062
> https://issues.apache.org/jira/browse/AURORA-1062
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Instrument the HealthChecker to export stats.
> 
> HealthChecker plugin now should export three stats:
>   consecutive_failures: number of consecutive failures experienced (resets on 
> success)
>   latency: how long health checks are taking in practice
>   snoozed: whether or not the health checker is snoozed
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 60676ba0fbd8a218fe4309f07de28e2c66d54530 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 624921d68199df098ea51ee8a10815403bf58984 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> a4e215d4422e3ada7b7913eaab105fdf030695c5 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> c8fab307d17949a8157659c4b3944ec7520feb9d 
> 
> Diff: https://reviews.apache.org/r/30647/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-17 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review72856
---



src/main/python/apache/aurora/executor/common/health_checker.py


What's the intended use of this metric?  Since it's exported as a gauge, 
it's lossy depending on the poll frequency.

Unless there's a concrete use, i suggest killing this.


- Bill Farner


On Feb. 18, 2015, 1 a.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> ---
> 
> (Updated Feb. 18, 2015, 1 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1062
> https://issues.apache.org/jira/browse/AURORA-1062
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Instrument the HealthChecker to export stats.
> 
> HealthChecker plugin now should export three stats:
>   consecutive_failures: number of consecutive failures experienced (resets on 
> success)
>   latency: how long health checks are taking in practice
>   snoozed: whether or not the health checker is snoozed
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 60676ba0fbd8a218fe4309f07de28e2c66d54530 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 624921d68199df098ea51ee8a10815403bf58984 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> a4e215d4422e3ada7b7913eaab105fdf030695c5 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> c8fab307d17949a8157659c4b3944ec7520feb9d 
> 
> Diff: https://reviews.apache.org/r/30647/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-17 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/
---

(Updated Feb. 18, 2015, 1 a.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

Update to use ThreadedClock with converge methods.  Kill thread_yields.


Bugs: AURORA-1062
https://issues.apache.org/jira/browse/AURORA-1062


Repository: aurora


Description
---

Instrument the HealthChecker to export stats.

HealthChecker plugin now should export three stats:
  consecutive_failures: number of consecutive failures experienced (resets on 
success)
  latency: how long health checks are taking in practice
  snoozed: whether or not the health checker is snoozed


Diffs (updated)
-

  src/main/python/apache/aurora/executor/common/health_checker.py 
60676ba0fbd8a218fe4309f07de28e2c66d54530 
  src/main/python/apache/aurora/executor/common/status_checker.py 
624921d68199df098ea51ee8a10815403bf58984 
  src/test/python/apache/aurora/executor/common/test_health_checker.py 
a4e215d4422e3ada7b7913eaab105fdf030695c5 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
c8fab307d17949a8157659c4b3944ec7520feb9d 

Diff: https://reviews.apache.org/r/30647/diff/


Testing
---

./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::


Thanks,

Brian Wickman

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-17 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/
---

(Updated Feb. 17, 2015, 10:46 p.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

Added dependency on r/31137


Bugs: AURORA-1062
https://issues.apache.org/jira/browse/AURORA-1062


Repository: aurora


Description
---

Instrument the HealthChecker to export stats.

HealthChecker plugin now should export three stats:
  consecutive_failures: number of consecutive failures experienced (resets on 
success)
  latency: how long health checks are taking in practice
  snoozed: whether or not the health checker is snoozed


Diffs
-

  src/main/python/apache/aurora/executor/common/health_checker.py 
60676ba0fbd8a218fe4309f07de28e2c66d54530 
  src/main/python/apache/aurora/executor/common/status_checker.py 
624921d68199df098ea51ee8a10815403bf58984 
  src/test/python/apache/aurora/executor/common/test_health_checker.py 
def249c2509a28f7145380f250f79202b653dc83 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
c8fab307d17949a8157659c4b3944ec7520feb9d 

Diff: https://reviews.apache.org/r/30647/diff/


Testing
---

./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::


Thanks,

Brian Wickman

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-10 Thread Joe Smith 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review71836
---



src/test/python/apache/aurora/executor/common/test_health_checker.py


I have a hard time believing this is going to be un-flaky, but not based on 
quantitative analysis.


- Joe Smith


On Feb. 6, 2015, 3:13 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> ---
> 
> (Updated Feb. 6, 2015, 3:13 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1062
> https://issues.apache.org/jira/browse/AURORA-1062
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Instrument the HealthChecker to export stats.
> 
> HealthChecker plugin now should export three stats:
>   consecutive_failures: number of consecutive failures experienced (resets on 
> success)
>   latency: how long health checks are taking in practice
>   snoozed: whether or not the health checker is snoozed
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 60676ba0fbd8a218fe4309f07de28e2c66d54530 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 624921d68199df098ea51ee8a10815403bf58984 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> def249c2509a28f7145380f250f79202b653dc83 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> c8fab307d17949a8157659c4b3944ec7520feb9d 
> 
> Diff: https://reviews.apache.org/r/30647/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-10 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review71835
---



src/test/python/apache/aurora/executor/common/test_health_checker.py


Why do we need these real timeouts?


- Joshua Cohen


On Feb. 6, 2015, 11:13 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> ---
> 
> (Updated Feb. 6, 2015, 11:13 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1062
> https://issues.apache.org/jira/browse/AURORA-1062
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Instrument the HealthChecker to export stats.
> 
> HealthChecker plugin now should export three stats:
>   consecutive_failures: number of consecutive failures experienced (resets on 
> success)
>   latency: how long health checks are taking in practice
>   snoozed: whether or not the health checker is snoozed
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 60676ba0fbd8a218fe4309f07de28e2c66d54530 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 624921d68199df098ea51ee8a10815403bf58984 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> def249c2509a28f7145380f250f79202b653dc83 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> c8fab307d17949a8157659c4b3944ec7520feb9d 
> 
> Diff: https://reviews.apache.org/r/30647/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-09 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review71711
---


ping.

- Brian Wickman


On Feb. 6, 2015, 11:13 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> ---
> 
> (Updated Feb. 6, 2015, 11:13 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1062
> https://issues.apache.org/jira/browse/AURORA-1062
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Instrument the HealthChecker to export stats.
> 
> HealthChecker plugin now should export three stats:
>   consecutive_failures: number of consecutive failures experienced (resets on 
> success)
>   latency: how long health checks are taking in practice
>   snoozed: whether or not the health checker is snoozed
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 60676ba0fbd8a218fe4309f07de28e2c66d54530 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 624921d68199df098ea51ee8a10815403bf58984 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> def249c2509a28f7145380f250f79202b653dc83 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> c8fab307d17949a8157659c4b3944ec7520feb9d 
> 
> Diff: https://reviews.apache.org/r/30647/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-08 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review71540
---

Ship it!


Master (11a65d2) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 6, 2015, 11:13 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> ---
> 
> (Updated Feb. 6, 2015, 11:13 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1062
> https://issues.apache.org/jira/browse/AURORA-1062
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Instrument the HealthChecker to export stats.
> 
> HealthChecker plugin now should export three stats:
>   consecutive_failures: number of consecutive failures experienced (resets on 
> success)
>   latency: how long health checks are taking in practice
>   snoozed: whether or not the health checker is snoozed
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 60676ba0fbd8a218fe4309f07de28e2c66d54530 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 624921d68199df098ea51ee8a10815403bf58984 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> def249c2509a28f7145380f250f79202b653dc83 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> c8fab307d17949a8157659c4b3944ec7520feb9d 
> 
> Diff: https://reviews.apache.org/r/30647/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-08 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/
---

(Updated Feb. 6, 2015, 11:13 p.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

Fix style violation.


Bugs: AURORA-1062
https://issues.apache.org/jira/browse/AURORA-1062


Repository: aurora


Description
---

Instrument the HealthChecker to export stats.

HealthChecker plugin now should export three stats:
  consecutive_failures: number of consecutive failures experienced (resets on 
success)
  latency: how long health checks are taking in practice
  snoozed: whether or not the health checker is snoozed


Diffs (updated)
-

  src/main/python/apache/aurora/executor/common/health_checker.py 
60676ba0fbd8a218fe4309f07de28e2c66d54530 
  src/main/python/apache/aurora/executor/common/status_checker.py 
624921d68199df098ea51ee8a10815403bf58984 
  src/test/python/apache/aurora/executor/common/test_health_checker.py 
def249c2509a28f7145380f250f79202b653dc83 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
c8fab307d17949a8157659c4b3944ec7520feb9d 

Diff: https://reviews.apache.org/r/30647/diff/


Testing
---

./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::


Thanks,

Brian Wickman

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-06 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review71488
---


Master (da296a3) is red with this patch.
  ./build-support/jenkins/build.sh

  Running setup.py install for twitter.common.collections
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)
Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.collections-0.3.0-py2.7-nspkg.pth
  Running setup.py install for twitter.common.util
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)
Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.util-0.3.0-py2.7-nspkg.pth
  Running setup.py install for twitter.common.log
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)
Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.log-0.3.0-py2.7-nspkg.pth
  Running setup.py install for twitter.common.process
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)
Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.process-0.3.0-py2.7-nspkg.pth
  Running setup.py install for gitdb
building 'gitdb._perf' extension
x86_64-linux-gnu-gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 
-Wall -Wstrict-prototypes -fPIC -Igitdb -I/usr/include/python2.7 -c 
gitdb/_fun.c -o build/temp.linux-x86_64-2.7/gitdb/_fun.o
x86_64-linux-gnu-gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 
-Wall -Wstrict-prototypes -fPIC -Igitdb -I/usr/include/python2.7 -c 
gitdb/_delta_apply.c -o build/temp.linux-x86_64-2.7/gitdb/_delta_apply.o
x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions 
-Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv 
-O2 -Wall -Wstrict-prototypes -D_FORTIFY_SOURCE=2 -g -fstack-protector 
--param=ssp-buffer-size=4 -Wformat -Werror=format-security 
build/temp.linux-x86_64-2.7/gitdb/_fun.o 
build/temp.linux-x86_64-2.7/gitdb/_delta_apply.o -o 
build/lib.linux-x86_64-2.7/gitdb/_perf.so
  Running setup.py install for twitter.common.app
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)
Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.app-0.3.0-py2.7-nspkg.pth
  Running setup.py install for GitPython

/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/setuptools/dist.py:292:
 UserWarning: The version specified ('0.3.2 RC1') is an invalid version, this 
may not work as expected with newer versions of setuptools, pip, and PyPI. 
Please see PEP 440 for more details.
  "details." % self.metadata.version
  Running setup.py install for pep8
Installing pep8 script to 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/bin
  Running setup.py install for pyflakes
Installing pyflakes script to 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/bin
  Running setup.py in

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-06 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/
---

(Updated Feb. 6, 2015, 7:44 p.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

Remove no longer valid assertions about exported metrics.


Bugs: AURORA-1062
https://issues.apache.org/jira/browse/AURORA-1062


Repository: aurora


Description
---

Instrument the HealthChecker to export stats.

HealthChecker plugin now should export three stats:
  consecutive_failures: number of consecutive failures experienced (resets on 
success)
  latency: how long health checks are taking in practice
  snoozed: whether or not the health checker is snoozed


Diffs (updated)
-

  src/main/python/apache/aurora/executor/common/health_checker.py 
60676ba0fbd8a218fe4309f07de28e2c66d54530 
  src/main/python/apache/aurora/executor/common/status_checker.py 
624921d68199df098ea51ee8a10815403bf58984 
  src/test/python/apache/aurora/executor/common/test_health_checker.py 
def249c2509a28f7145380f250f79202b653dc83 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
c8fab307d17949a8157659c4b3944ec7520feb9d 

Diff: https://reviews.apache.org/r/30647/diff/


Testing
---

./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::


Thanks,

Brian Wickman

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-06 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review71484
---


whoops, there is a legit breakage due to the removal of the 'enabled' flags.  
will fix.

- Brian Wickman


On Feb. 5, 2015, 7:17 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> ---
> 
> (Updated Feb. 5, 2015, 7:17 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1062
> https://issues.apache.org/jira/browse/AURORA-1062
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Instrument the HealthChecker to export stats.
> 
> HealthChecker plugin now should export three stats:
>   consecutive_failures: number of consecutive failures experienced (resets on 
> success)
>   latency: how long health checks are taking in practice
>   snoozed: whether or not the health checker is snoozed
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 60676ba0fbd8a218fe4309f07de28e2c66d54530 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 624921d68199df098ea51ee8a10815403bf58984 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> def249c2509a28f7145380f250f79202b653dc83 
> 
> Diff: https://reviews.apache.org/r/30647/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-05 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review71294
---


Master (1c78721) is red with this patch.
  ./build-support/jenkins/build.sh

 src.test.python.apache.aurora.client.cli.task  
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.update
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.version   
 .   SUCCESS
 src.test.python.apache.aurora.client.config
 .   SUCCESS
 src.test.python.apache.aurora.client.hooks.hooked_api  
 .   SUCCESS
 src.test.python.apache.aurora.client.hooks.non_hooked_api  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_aurora_job_key   
 .   SUCCESS
 src.test.python.apache.aurora.common.test_cluster  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_cluster_option   
 .   SUCCESS
 src.test.python.apache.aurora.common.test_clusters 
 .   SUCCESS
 src.test.python.apache.aurora.common.test_http_signaler
 .   SUCCESS
 src.test.python.apache.aurora.common.test_pex_version  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_shellify 
 .   SUCCESS
 src.test.python.apache.aurora.common.test_transport
 .   SUCCESS
 src.test.python.apache.aurora.config.test_base 
 .   SUCCESS
 
src.test.python.apache.aurora.config.test_constraint_parsing
.   SUCCESS
 src.test.python.apache.aurora.config.test_loader   
 .   SUCCESS
 src.test.python.apache.aurora.config.test_thrift   
 .   SUCCESS
 src.test.python.apache.aurora.executor.common.announcer
 .   SUCCESS
 
src.test.python.apache.aurora.executor.common.directory_sandbox 
.   SUCCESS
 
src.test.python.apache.aurora.executor.common.executor_timeout  
.   SUCCESS
 
src.test.python.apache.aurora.executor.common.health_checker
.   SUCCESS
 src.test.python.apache.aurora.executor.common.kill_manager 
 .   SUCCESS
 
src.test.python.apache.aurora.executor.common.status_checker
.   SUCCESS
 src.test.python.apache.aurora.executor.common.task_info
 .   SUCCESS
 src.test.python.apache.aurora.executor.executor_base   
 .   SUCCESS
 src.test.python.apache.aurora.executor.executor_detector   
 .   SUCCESS
 src.test.python.apache.aurora.executor.executor_vars   
 .   SUCCESS
 src.test.python.apache.aurora.executor.gc_executor 
 .   SUCCESS
 src.test.python.apache.aurora.executor.status_manager  
 .   SUCCESS
 src.test.python.apache.aurora.executor.thermos_executor
 .   FAILURE
 src.test.python.apache.aurora.executor.thermos_task_runner 
 .   SUCCESS
 src.test.python.apache.thermos.common.test_pathspec
 .   SUCCESS
 
src.test.python.apache.thermos.core.test_runner_integration 
.   SUCCESS
 src.test.python.apache.thermos.monitoring.test_disk
 .   SUCCESS
 
FAILURE


   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 5, 2015, 7:17 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> ---
> 
> (Updated Feb. 5, 2015, 7:17 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
>

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-05 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review71282
---


@ReviewBot retry

- Joshua Cohen


On Feb. 5, 2015, 7:17 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> ---
> 
> (Updated Feb. 5, 2015, 7:17 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1062
> https://issues.apache.org/jira/browse/AURORA-1062
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Instrument the HealthChecker to export stats.
> 
> HealthChecker plugin now should export three stats:
>   consecutive_failures: number of consecutive failures experienced (resets on 
> success)
>   latency: how long health checks are taking in practice
>   snoozed: whether or not the health checker is snoozed
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 60676ba0fbd8a218fe4309f07de28e2c66d54530 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 624921d68199df098ea51ee8a10815403bf58984 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> def249c2509a28f7145380f250f79202b653dc83 
> 
> Diff: https://reviews.apache.org/r/30647/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-05 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review71281
---


Master (1c78721) is red with this patch.
  ./build-support/jenkins/build.sh

 src.test.python.apache.aurora.client.cli.task  
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.update
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.version   
 .   SUCCESS
 src.test.python.apache.aurora.client.config
 .   SUCCESS
 src.test.python.apache.aurora.client.hooks.hooked_api  
 .   SUCCESS
 src.test.python.apache.aurora.client.hooks.non_hooked_api  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_aurora_job_key   
 .   SUCCESS
 src.test.python.apache.aurora.common.test_cluster  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_cluster_option   
 .   SUCCESS
 src.test.python.apache.aurora.common.test_clusters 
 .   SUCCESS
 src.test.python.apache.aurora.common.test_http_signaler
 .   SUCCESS
 src.test.python.apache.aurora.common.test_pex_version  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_shellify 
 .   SUCCESS
 src.test.python.apache.aurora.common.test_transport
 .   SUCCESS
 src.test.python.apache.aurora.config.test_base 
 .   SUCCESS
 
src.test.python.apache.aurora.config.test_constraint_parsing
.   SUCCESS
 src.test.python.apache.aurora.config.test_loader   
 .   SUCCESS
 src.test.python.apache.aurora.config.test_thrift   
 .   SUCCESS
 src.test.python.apache.aurora.executor.common.announcer
 .   SUCCESS
 
src.test.python.apache.aurora.executor.common.directory_sandbox 
.   SUCCESS
 
src.test.python.apache.aurora.executor.common.executor_timeout  
.   SUCCESS
 
src.test.python.apache.aurora.executor.common.health_checker
.   SUCCESS
 src.test.python.apache.aurora.executor.common.kill_manager 
 .   SUCCESS
 
src.test.python.apache.aurora.executor.common.status_checker
.   SUCCESS
 src.test.python.apache.aurora.executor.common.task_info
 .   SUCCESS
 src.test.python.apache.aurora.executor.executor_base   
 .   SUCCESS
 src.test.python.apache.aurora.executor.executor_detector   
 .   SUCCESS
 src.test.python.apache.aurora.executor.executor_vars   
 .   SUCCESS
 src.test.python.apache.aurora.executor.gc_executor 
 .   SUCCESS
 src.test.python.apache.aurora.executor.status_manager  
 .   SUCCESS
 src.test.python.apache.aurora.executor.thermos_executor
 .   FAILURE
 src.test.python.apache.aurora.executor.thermos_task_runner 
 .   SUCCESS
 src.test.python.apache.thermos.common.test_pathspec
 .   SUCCESS
 
src.test.python.apache.thermos.core.test_runner_integration 
.   SUCCESS
 src.test.python.apache.thermos.monitoring.test_disk
 .   SUCCESS
 
FAILURE


   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 5, 2015, 7:17 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> ---
> 
> (Updated Feb. 5, 2015, 7:17 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
>

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-05 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/
---

(Updated Feb. 5, 2015, 7:17 p.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

Actually compare latency metric.


Bugs: AURORA-1062
https://issues.apache.org/jira/browse/AURORA-1062


Repository: aurora


Description
---

Instrument the HealthChecker to export stats.

HealthChecker plugin now should export three stats:
  consecutive_failures: number of consecutive failures experienced (resets on 
success)
  latency: how long health checks are taking in practice
  snoozed: whether or not the health checker is snoozed


Diffs (updated)
-

  src/main/python/apache/aurora/executor/common/health_checker.py 
60676ba0fbd8a218fe4309f07de28e2c66d54530 
  src/main/python/apache/aurora/executor/common/status_checker.py 
624921d68199df098ea51ee8a10815403bf58984 
  src/test/python/apache/aurora/executor/common/test_health_checker.py 
def249c2509a28f7145380f250f79202b653dc83 

Diff: https://reviews.apache.org/r/30647/diff/


Testing
---

./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::


Thanks,

Brian Wickman

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-05 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/
---

(Updated Feb. 5, 2015, 7:15 p.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

Add coverage for snooze/latency.


Bugs: AURORA-1062
https://issues.apache.org/jira/browse/AURORA-1062


Repository: aurora


Description
---

Instrument the HealthChecker to export stats.

HealthChecker plugin now should export three stats:
  consecutive_failures: number of consecutive failures experienced (resets on 
success)
  latency: how long health checks are taking in practice
  snoozed: whether or not the health checker is snoozed


Diffs (updated)
-

  src/main/python/apache/aurora/executor/common/health_checker.py 
60676ba0fbd8a218fe4309f07de28e2c66d54530 
  src/main/python/apache/aurora/executor/common/status_checker.py 
624921d68199df098ea51ee8a10815403bf58984 
  src/test/python/apache/aurora/executor/common/test_health_checker.py 
def249c2509a28f7145380f250f79202b653dc83 

Diff: https://reviews.apache.org/r/30647/diff/


Testing
---

./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::


Thanks,

Brian Wickman

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-05 Thread Joshua Cohen 


> On Feb. 5, 2015, 2:32 a.m., Maxim Khutornenko wrote:
> > src/test/python/apache/aurora/executor/common/test_health_checker.py, line 
> > 106
> > 
> >
> > Any chance to have test coverage for the other two metrics?

+1


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review71137
---


On Feb. 5, 2015, 1:46 a.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> ---
> 
> (Updated Feb. 5, 2015, 1:46 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1062
> https://issues.apache.org/jira/browse/AURORA-1062
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Instrument the HealthChecker to export stats.
> 
> HealthChecker plugin now should export three stats:
>   consecutive_failures: number of consecutive failures experienced (resets on 
> success)
>   latency: how long health checks are taking in practice
>   snoozed: whether or not the health checker is snoozed
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 60676ba0fbd8a218fe4309f07de28e2c66d54530 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 624921d68199df098ea51ee8a10815403bf58984 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> def249c2509a28f7145380f250f79202b653dc83 
> 
> Diff: https://reviews.apache.org/r/30647/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-04 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review71137
---



src/test/python/apache/aurora/executor/common/test_health_checker.py


Any chance to have test coverage for the other two metrics?


- Maxim Khutornenko


On Feb. 5, 2015, 1:46 a.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> ---
> 
> (Updated Feb. 5, 2015, 1:46 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-1062
> https://issues.apache.org/jira/browse/AURORA-1062
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Instrument the HealthChecker to export stats.
> 
> HealthChecker plugin now should export three stats:
>   consecutive_failures: number of consecutive failures experienced (resets on 
> success)
>   latency: how long health checks are taking in practice
>   snoozed: whether or not the health checker is snoozed
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> 60676ba0fbd8a218fe4309f07de28e2c66d54530 
>   src/main/python/apache/aurora/executor/common/status_checker.py 
> 624921d68199df098ea51ee8a10815403bf58984 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> def249c2509a28f7145380f250f79202b653dc83 
> 
> Diff: https://reviews.apache.org/r/30647/diff/
> 
> 
> Testing
> ---
> 
> ./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-04 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review71127
---


Master (edcc252) is red with this patch.
  ./build-support/jenkins/build.sh

 src.test.python.apache.aurora.client.cli.plugins   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.quota 
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.sla   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.supdate   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.task  
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.update
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.version   
 .   SUCCESS
 src.test.python.apache.aurora.client.config
 .   SUCCESS
 src.test.python.apache.aurora.client.hooks.hooked_api  
 .   SUCCESS
 src.test.python.apache.aurora.client.hooks.non_hooked_api  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_aurora_job_key   
 .   SUCCESS
 src.test.python.apache.aurora.common.test_cluster  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_cluster_option   
 .   SUCCESS
 src.test.python.apache.aurora.common.test_clusters 
 .   SUCCESS
 src.test.python.apache.aurora.common.test_http_signaler
 .   SUCCESS
 src.test.python.apache.aurora.common.test_pex_version  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_shellify 
 .   SUCCESS
 src.test.python.apache.aurora.common.test_transport
 .   SUCCESS
 src.test.python.apache.aurora.config.test_base 
 .   SUCCESS
 
src.test.python.apache.aurora.config.test_constraint_parsing
.   SUCCESS
 src.test.python.apache.aurora.config.test_loader   
 .   SUCCESS
 src.test.python.apache.aurora.config.test_thrift   
 .   SUCCESS
 src.test.python.apache.aurora.executor.common.announcer
 .   SUCCESS
 
src.test.python.apache.aurora.executor.common.directory_sandbox 
.   SUCCESS
 
src.test.python.apache.aurora.executor.common.executor_timeout  
.   SUCCESS
 
src.test.python.apache.aurora.executor.common.health_checker
.   FAILURE
 src.test.python.apache.aurora.executor.common.task_info
 .   SUCCESS
 src.test.python.apache.aurora.executor.executor_base   
 .   SUCCESS
 src.test.python.apache.aurora.executor.executor_detector   
 .   SUCCESS
 src.test.python.apache.aurora.executor.executor_vars   
 .   SUCCESS
 src.test.python.apache.aurora.executor.status_manager  
 .   SUCCESS
 src.test.python.apache.aurora.executor.thermos_task_runner 
 .   SUCCESS
 src.test.python.apache.thermos.common.test_pathspec
 .   SUCCESS
 
src.test.python.apache.thermos.core.test_runner_integration 
.   SUCCESS
 src.test.python.apache.thermos.monitoring.test_disk
 .   SUCCESS
 
FAILURE


   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 5, 2015, 1:46 a.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30647/
> ---
> 
> (Updated Feb. 5, 2015, 1:46 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
>

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-04 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/
---

(Updated Feb. 5, 2015, 1:46 a.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Bugs: AURORA-1062
https://issues.apache.org/jira/browse/AURORA-1062


Repository: aurora


Description
---

Instrument the HealthChecker to export stats.

HealthChecker plugin now should export three stats:
  consecutive_failures: number of consecutive failures experienced (resets on 
success)
  latency: how long health checks are taking in practice
  snoozed: whether or not the health checker is snoozed


Diffs
-

  src/main/python/apache/aurora/executor/common/health_checker.py 
60676ba0fbd8a218fe4309f07de28e2c66d54530 
  src/main/python/apache/aurora/executor/common/status_checker.py 
624921d68199df098ea51ee8a10815403bf58984 
  src/test/python/apache/aurora/executor/common/test_health_checker.py 
def249c2509a28f7145380f250f79202b653dc83 

Diff: https://reviews.apache.org/r/30647/diff/


Testing
---

./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::


Thanks,

Brian Wickman

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-04 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/
---

(Updated Feb. 5, 2015, 1:45 a.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

Rename health checker stats to health_checker.  Add reviewers.


Repository: aurora


Description
---

Instrument the HealthChecker to export stats.

HealthChecker plugin now should export three stats:
  consecutive_failures: number of consecutive failures experienced (resets on 
success)
  latency: how long health checks are taking in practice
  snoozed: whether or not the health checker is snoozed


Diffs (updated)
-

  src/main/python/apache/aurora/executor/common/health_checker.py 
60676ba0fbd8a218fe4309f07de28e2c66d54530 
  src/main/python/apache/aurora/executor/common/status_checker.py 
624921d68199df098ea51ee8a10815403bf58984 
  src/test/python/apache/aurora/executor/common/test_health_checker.py 
def249c2509a28f7145380f250f79202b653dc83 

Diff: https://reviews.apache.org/r/30647/diff/


Testing
---

./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::


Thanks,

Brian Wickman

Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-04 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/
---

Review request for Aurora.


Repository: aurora


Description
---

Instrument the HealthChecker to export stats.

HealthChecker plugin now should export three stats:
  consecutive_failures: number of consecutive failures experienced (resets on 
success)
  latency: how long health checks are taking in practice
  snoozed: whether or not the health checker is snoozed


Diffs
-

  src/main/python/apache/aurora/executor/common/health_checker.py 
60676ba0fbd8a218fe4309f07de28e2c66d54530 
  src/main/python/apache/aurora/executor/common/status_checker.py 
624921d68199df098ea51ee8a10815403bf58984 
  src/test/python/apache/aurora/executor/common/test_health_checker.py 
def249c2509a28f7145380f250f79202b653dc83 

Diff: https://reviews.apache.org/r/30647/diff/


Testing
---

./pants test.pytest --no-fast src/test/python/apache/aurora/executor/common::


Thanks,

Brian Wickman