Re: Review Request 32329: Extract job key from RPC parameters

2015-03-25 Thread Joshua Cohen
On March 23, 2015, 8:59 p.m., Joshua Cohen wrote: Thanks, this is already much easier to follow. One general question on the overall approach: do you think the DRY benefits of using composed `StructFieldGetter`s to generate the functions that allow walking from the starting type to

Re: Review Request 32329: Extract job key from RPC parameters

2015-03-23 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/ --- (Updated March 23, 2015, 12:14 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 32329: Extract job key from RPC parameters

2015-03-23 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/#review77289 --- Thanks, this is already much easier to follow. One general

Re: Review Request 32329: Extract job key from RPC parameters

2015-03-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/#review77448 --- ~All minor stuff. config/pmd/custom.xml

Re: Review Request 32329: Extract job key from RPC parameters

2015-03-23 Thread Bill Farner
On March 23, 2015, 8:59 p.m., Joshua Cohen wrote: Thanks, this is already much easier to follow. One general question on the overall approach: do you think the DRY benefits of using composed `StructFieldGetter`s to generate the functions that allow walking from the starting type to

Re: Review Request 32329: Extract job key from RPC parameters

2015-03-20 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/ --- (Updated March 20, 2015, 5:16 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 32329: Extract job key from RPC parameters

2015-03-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/#review77319 --- Ship it! Master (a3a35e9) is green with this patch.

Re: Review Request 32329: Extract job key from RPC parameters

2015-03-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/#review77273 --- Master (f12d9fe) is red with this patch.

Review Request 32329: Extract job key from RPC parameters

2015-03-20 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-1187

Re: Review Request 32329: Extract job key from RPC parameters

2015-03-20 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/ --- (Updated March 20, 2015, 3:01 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 32329: Extract job key from RPC parameters

2015-03-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32329/#review77286 --- Ship it! Master (f12d9fe) is green with this patch.