[GitHub] bahir pull request #57: [BAHIR-128][WIP] fix failing sql-cloudant test

Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/57#discussion_r157553098 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/CloudantChangesConfig.scala --- @@ -67,7 +67,8 @@ class CloudantChangesConfig(protocol:

[GitHub] bahir pull request #57: [BAHIR-128][WIP] fix failing sql-cloudant test

Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/57#discussion_r157552982 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/internal/ChangesReceiver.scala --- @@ -39,56 +37,38 @@ class ChangesReceiver(config:

[GitHub] bahir pull request #57: [BAHIR-128][WIP] fix failing sql-cloudant test

Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/57#discussion_r157533814 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/internal/ChangesReceiver.scala --- @@ -39,56 +37,38 @@ class ChangesReceiver(config:

[GitHub] bahir pull request #57: [BAHIR-128][WIP] fix failing sql-cloudant test

Github user ricellis commented on a diff in the pull request: https://github.com/apache/bahir/pull/57#discussion_r157480164 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/DefaultSource.scala --- @@ -125,7 +125,7 @@ class DefaultSource extends RelationProvider

[GitHub] bahir pull request #57: [BAHIR-128][WIP] fix failing sql-cloudant test

Github user ricellis commented on a diff in the pull request: https://github.com/apache/bahir/pull/57#discussion_r157484722 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/internal/ChangesReceiver.scala --- @@ -39,56 +37,38 @@ class ChangesReceiver(config:

[GitHub] bahir pull request #57: [BAHIR-128][WIP] fix failing sql-cloudant test

Github user ricellis commented on a diff in the pull request: https://github.com/apache/bahir/pull/57#discussion_r157478713 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/CloudantChangesConfig.scala --- @@ -67,7 +67,8 @@ class CloudantChangesConfig(protocol:

[GitHub] bahir pull request #57: [BAHIR-128][WIP] fix failing sql-cloudant test

Github user ricellis commented on a diff in the pull request: https://github.com/apache/bahir/pull/57#discussion_r157479639 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/internal/ChangesReceiver.scala --- @@ -39,56 +37,38 @@ class ChangesReceiver(config:

[GitHub] bahir pull request #57: [BAHIR-128][WIP] fix failing sql-cloudant test

Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/57#discussion_r156206675 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/common/ChangesRow.java --- @@ -0,0 +1,74 @@ +/* + * Copyright (c) 2017 IBM Cloudant.

[GitHub] bahir pull request #57: [BAHIR-128][WIP] fix failing sql-cloudant test

Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/57#discussion_r156123828 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/common/ChangesRow.java --- @@ -0,0 +1,74 @@ +/* + * Copyright (c) 2017 IBM Cloudant.

[GitHub] bahir pull request #57: [BAHIR-128][WIP] fix failing sql-cloudant test

Github user ckadner commented on a diff in the pull request: https://github.com/apache/bahir/pull/57#discussion_r155934996 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/common/ChangesRowScanner.java --- @@ -0,0 +1,92 @@ +/* + * Copyright (c) 2017 IBM

[GitHub] bahir pull request #57: [BAHIR-128][WIP] fix failing sql-cloudant test

Github user ckadner commented on a diff in the pull request: https://github.com/apache/bahir/pull/57#discussion_r155934979 --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/common/ChangesRow.java --- @@ -0,0 +1,74 @@ +/* + * Copyright (c) 2017 IBM Cloudant.

[GitHub] bahir pull request #57: [BAHIR-128][WIP] fix failing sql-cloudant test

Github user emlaver commented on a diff in the pull request: https://github.com/apache/bahir/pull/57#discussion_r155699572 --- Diff: pom.xml --- @@ -458,7 +458,7 @@ .gitignore .repository/ - .idea/ +

[GitHub] bahir pull request #57: [BAHIR-128][WIP] fix failing sql-cloudant test

Github user ckadner commented on a diff in the pull request: https://github.com/apache/bahir/pull/57#discussion_r155697683 --- Diff: pom.xml --- @@ -458,7 +458,7 @@ .gitignore .repository/ - .idea/ +

[GitHub] bahir pull request #57: [BAHIR-128][WIP] fix failing sql-cloudant test

GitHub user emlaver opened a pull request: https://github.com/apache/bahir/pull/57 [BAHIR-128][WIP] fix failing sql-cloudant test _What_ Fix test that's failing sporadically in sql-cloudant's `CloudantChangesDFSuite`. _How_ - Call stop in receiver when _changes