[GitHub] [helix] jiajunwang merged pull request #511: More strict partition weight validation while creating the cluster model.

2019-10-17 Thread GitBox
jiajunwang merged pull request #511: More strict partition weight validation while creating the cluster model. URL: https://github.com/apache/helix/pull/511 This is an automated message from the Apache Git Service. To

[GitHub] [helix] pkuwm commented on a change in pull request #514: The WAGED rebalancer returns the previously calculated assignment on calculation failure

2019-10-17 Thread GitBox
pkuwm commented on a change in pull request #514: The WAGED rebalancer returns the previously calculated assignment on calculation failure URL: https://github.com/apache/helix/pull/514#discussion_r335821471 ## File path:

[GitHub] [helix] pkuwm commented on a change in pull request #514: The WAGED rebalancer returns the previously calculated assignment on calculation failure

2019-10-17 Thread GitBox
pkuwm commented on a change in pull request #514: The WAGED rebalancer returns the previously calculated assignment on calculation failure URL: https://github.com/apache/helix/pull/514#discussion_r335823915 ## File path:

[GitHub] [helix] pkuwm commented on a change in pull request #514: The WAGED rebalancer returns the previously calculated assignment on calculation failure

2019-10-17 Thread GitBox
pkuwm commented on a change in pull request #514: The WAGED rebalancer returns the previously calculated assignment on calculation failure URL: https://github.com/apache/helix/pull/514#discussion_r335822181 ## File path:

[GitHub] [helix] jiajunwang commented on issue #511: More strict partition weight validation while creating the cluster model.

2019-10-17 Thread GitBox
jiajunwang commented on issue #511: More strict partition weight validation while creating the cluster model. URL: https://github.com/apache/helix/pull/511#issuecomment-543267517 > Suggestion on the description of the PR. You say "a more strict check", but you don't actually describe it.

[GitHub] [helix] i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint

2019-10-17 Thread GitBox
i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r336205171 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java

[GitHub] [helix] jiajunwang commented on a change in pull request #511: More strict partition weight validation while creating the cluster model.

2019-10-17 Thread GitBox
jiajunwang commented on a change in pull request #511: More strict partition weight validation while creating the cluster model. URL: https://github.com/apache/helix/pull/511#discussion_r336217541 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #511: More strict partition weight validation while creating the cluster model.

2019-10-17 Thread GitBox
jiajunwang commented on a change in pull request #511: More strict partition weight validation while creating the cluster model. URL: https://github.com/apache/helix/pull/511#discussion_r336217298 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #511: More strict partition weight validation while creating the cluster model.

2019-10-17 Thread GitBox
jiajunwang commented on a change in pull request #511: More strict partition weight validation while creating the cluster model. URL: https://github.com/apache/helix/pull/511#discussion_r336215847 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #511: More strict partition weight validation while creating the cluster model.

2019-10-17 Thread GitBox
narendly commented on a change in pull request #511: More strict partition weight validation while creating the cluster model. URL: https://github.com/apache/helix/pull/511#discussion_r336170671 ## File path: helix-core/src/test/java/org/apache/helix/model/TestClusterConfig.java

[GitHub] [helix] narendly commented on a change in pull request #511: More strict partition weight validation while creating the cluster model.

2019-10-17 Thread GitBox
narendly commented on a change in pull request #511: More strict partition weight validation while creating the cluster model. URL: https://github.com/apache/helix/pull/511#discussion_r336163644 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #511: More strict partition weight validation while creating the cluster model.

2019-10-17 Thread GitBox
narendly commented on a change in pull request #511: More strict partition weight validation while creating the cluster model. URL: https://github.com/apache/helix/pull/511#discussion_r336166711 ## File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java

[GitHub] [helix] narendly commented on a change in pull request #511: More strict partition weight validation while creating the cluster model.

2019-10-17 Thread GitBox
narendly commented on a change in pull request #511: More strict partition weight validation while creating the cluster model. URL: https://github.com/apache/helix/pull/511#discussion_r336163778 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #511: More strict partition weight validation while creating the cluster model.

2019-10-17 Thread GitBox
narendly commented on a change in pull request #511: More strict partition weight validation while creating the cluster model. URL: https://github.com/apache/helix/pull/511#discussion_r336161572 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #511: More strict partition weight validation while creating the cluster model.

2019-10-17 Thread GitBox
narendly commented on a change in pull request #511: More strict partition weight validation while creating the cluster model. URL: https://github.com/apache/helix/pull/511#discussion_r336169212 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #511: More strict partition weight validation while creating the cluster model.

2019-10-17 Thread GitBox
jiajunwang commented on a change in pull request #511: More strict partition weight validation while creating the cluster model. URL: https://github.com/apache/helix/pull/511#discussion_r336213926 ## File path: helix-core/src/test/java/org/apache/helix/model/TestClusterConfig.java

[GitHub] [helix] jiajunwang commented on a change in pull request #511: More strict partition weight validation while creating the cluster model.

2019-10-17 Thread GitBox
jiajunwang commented on a change in pull request #511: More strict partition weight validation while creating the cluster model. URL: https://github.com/apache/helix/pull/511#discussion_r336217456 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #511: More strict partition weight validation while creating the cluster model.

2019-10-17 Thread GitBox
jiajunwang commented on a change in pull request #511: More strict partition weight validation while creating the cluster model. URL: https://github.com/apache/helix/pull/511#discussion_r336214755 ## File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java

[GitHub] [helix] narendly commented on a change in pull request #516: Implement the propertyStore read endpoint

2019-10-17 Thread GitBox
narendly commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r336172205 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java

[GitHub] [helix] pkuwm commented on issue #513: Fix name typo for DataPropagationLatencyGuage.

2019-10-17 Thread GitBox
pkuwm commented on issue #513: Fix name typo for DataPropagationLatencyGuage. URL: https://github.com/apache/helix/pull/513#issuecomment-543297477 This PR is ready to be merged, approved by @narendly Final commit message: DataPropagationLatencyGuage has a typo which makes helix

[GitHub] [helix] narendly commented on a change in pull request #511: More strict partition weight validation while creating the cluster model.

2019-10-17 Thread GitBox
narendly commented on a change in pull request #511: More strict partition weight validation while creating the cluster model. URL: https://github.com/apache/helix/pull/511#discussion_r336163339 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #506: Increase parallelism for ZkBucketDataAccessor

2019-10-17 Thread GitBox
jiajunwang commented on a change in pull request #506: Increase parallelism for ZkBucketDataAccessor URL: https://github.com/apache/helix/pull/506#discussion_r336267335 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkBucketDataAccessor.java ## @@

[GitHub] [helix] jiajunwang commented on a change in pull request #506: Increase parallelism for ZkBucketDataAccessor

2019-10-17 Thread GitBox
jiajunwang commented on a change in pull request #506: Increase parallelism for ZkBucketDataAccessor URL: https://github.com/apache/helix/pull/506#discussion_r336264002 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkBucketDataAccessor.java ## @@

[GitHub] [helix] jiajunwang commented on a change in pull request #506: Increase parallelism for ZkBucketDataAccessor

2019-10-17 Thread GitBox
jiajunwang commented on a change in pull request #506: Increase parallelism for ZkBucketDataAccessor URL: https://github.com/apache/helix/pull/506#discussion_r336246159 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkBucketDataAccessor.java ## @@

[GitHub] [helix] jiajunwang commented on a change in pull request #506: Increase parallelism for ZkBucketDataAccessor

2019-10-17 Thread GitBox
jiajunwang commented on a change in pull request #506: Increase parallelism for ZkBucketDataAccessor URL: https://github.com/apache/helix/pull/506#discussion_r336246641 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkBucketDataAccessor.java ## @@

[GitHub] [helix] jiajunwang commented on a change in pull request #506: Increase parallelism for ZkBucketDataAccessor

2019-10-17 Thread GitBox
jiajunwang commented on a change in pull request #506: Increase parallelism for ZkBucketDataAccessor URL: https://github.com/apache/helix/pull/506#discussion_r336267819 ## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkBucketDataAccessor.java ## @@

[GitHub] [helix] jiajunwang commented on issue #511: More strict partition weight validation while creating the cluster model.

2019-10-17 Thread GitBox
jiajunwang commented on issue #511: More strict partition weight validation while creating the cluster model. URL: https://github.com/apache/helix/pull/511#issuecomment-543408333 This PR is ready to be merged, approved by @narendly

[GitHub] [helix] narendly merged pull request #513: Fix name typo for DataPropagationLatencyGuage.

2019-10-17 Thread GitBox
narendly merged pull request #513: Fix name typo for DataPropagationLatencyGuage. URL: https://github.com/apache/helix/pull/513 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [helix] i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint

2019-10-17 Thread GitBox
i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r336277993 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java

[GitHub] [helix] i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint

2019-10-17 Thread GitBox
i3wangyi commented on a change in pull request #516: Implement the propertyStore read endpoint URL: https://github.com/apache/helix/pull/516#discussion_r336277677 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java

[GitHub] [helix] narendly commented on a change in pull request #511: More strict partition weight validation while creating the cluster model.

2019-10-17 Thread GitBox
narendly commented on a change in pull request #511: More strict partition weight validation while creating the cluster model. URL: https://github.com/apache/helix/pull/511#discussion_r336245939 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #511: More strict partition weight validation while creating the cluster model.

2019-10-17 Thread GitBox
narendly commented on a change in pull request #511: More strict partition weight validation while creating the cluster model. URL: https://github.com/apache/helix/pull/511#discussion_r336246498 ## File path: helix-core/src/test/java/org/apache/helix/model/TestClusterConfig.java