junkaixue commented on code in PR #2735:
URL: https://github.com/apache/helix/pull/2735#discussion_r1525490257
##
helix-core/src/test/java/org/apache/helix/integration/TestErrorReplicaPersist.java:
##
@@ -103,10 +103,9 @@ public void testErrorReplicaPersist() throws
himanshukandwal commented on PR #2735:
URL: https://github.com/apache/helix/pull/2735#issuecomment-1997897068
Hey @junkaixue, this PR is ready to be reviewed.
Latest full CI successful run:
https://github.com/himanshukandwal/helix/actions/runs/8277053505
--
This is an automated
junkaixue commented on PR #2735:
URL: https://github.com/apache/helix/pull/2735#issuecomment-1969971593
@himanshukandwal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
junkaixue commented on PR #2735:
URL: https://github.com/apache/helix/pull/2735#issuecomment-1967835774
Ready for reviewing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
himanshukandwal commented on code in PR #2735:
URL: https://github.com/apache/helix/pull/2735#discussion_r141680
##
helix-core/src/test/java/org/apache/helix/integration/manager/ClusterManager.java:
##
@@ -34,7 +34,7 @@
public class ClusterManager extends ZKHelixManager
himanshukandwal commented on code in PR #2735:
URL: https://github.com/apache/helix/pull/2735#discussion_r142014
##
helix-core/src/test/java/org/apache/helix/TestHelper.java:
##
@@ -864,4 +866,36 @@ public static void printZkListeners(HelixZkClient client)
throws Exception
himanshukandwal commented on code in PR #2735:
URL: https://github.com/apache/helix/pull/2735#discussion_r1488879623
##
helix-core/src/test/java/org/apache/helix/common/ZkTestBase.java:
##
@@ -738,7 +731,7 @@ protected void deleteCluster(String clusterName) {
*/
himanshukandwal commented on code in PR #2735:
URL: https://github.com/apache/helix/pull/2735#discussion_r1488878155
##
meta-client/src/test/java/org/apache/helix/metaclient/impl/zk/TestMultiThreadStressTest/TestMultiThreadStressZKClient.java:
##
@@ -52,7 +52,7 @@ private void
himanshukandwal commented on code in PR #2735:
URL: https://github.com/apache/helix/pull/2735#discussion_r1488877926
##
helix-core/src/test/java/org/apache/helix/controller/stages/TestRebalancePipeline.java:
##
@@ -157,7 +157,6 @@ public void testDuplicateMsg() throws Exception
himanshukandwal commented on code in PR #2735:
URL: https://github.com/apache/helix/pull/2735#discussion_r1488876782
##
helix-core/src/test/java/org/apache/helix/TestListenerCallbackBatchMode.java:
##
@@ -221,21 +219,15 @@ public void testMixedListener() throws Exception {
}
himanshukandwal commented on code in PR #2735:
URL: https://github.com/apache/helix/pull/2735#discussion_r1488876378
##
helix-core/src/test/java/org/apache/helix/TestHelper.java:
##
@@ -864,4 +866,36 @@ public static void printZkListeners(HelixZkClient client)
throws Exception
himanshukandwal commented on code in PR #2735:
URL: https://github.com/apache/helix/pull/2735#discussion_r1488875667
##
helix-core/src/test/java/org/apache/helix/TestHelper.java:
##
@@ -864,4 +866,36 @@ public static void printZkListeners(HelixZkClient client)
throws Exception
himanshukandwal commented on code in PR #2735:
URL: https://github.com/apache/helix/pull/2735#discussion_r1488875382
##
helix-core/src/test/java/org/apache/helix/TestHelper.java:
##
@@ -864,4 +866,36 @@ public static void printZkListeners(HelixZkClient client)
throws Exception
himanshukandwal commented on code in PR #2735:
URL: https://github.com/apache/helix/pull/2735#discussion_r1488875270
##
helix-core/src/test/java/org/apache/helix/TestHelper.java:
##
@@ -278,16 +281,18 @@ public static void setupCluster(String clusterName,
String zkAddr, int
himanshukandwal commented on code in PR #2735:
URL: https://github.com/apache/helix/pull/2735#discussion_r1488874460
##
helix-core/src/test/java/org/apache/helix/TestHelper.java:
##
@@ -76,8 +79,10 @@
public class TestHelper {
private static final Logger LOG =
himanshukandwal commented on code in PR #2735:
URL: https://github.com/apache/helix/pull/2735#discussion_r1488874460
##
helix-core/src/test/java/org/apache/helix/TestHelper.java:
##
@@ -76,8 +79,10 @@
public class TestHelper {
private static final Logger LOG =
himanshukandwal commented on code in PR #2735:
URL: https://github.com/apache/helix/pull/2735#discussion_r1488873812
##
helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java:
##
@@ -221,14 +221,19 @@ public void finalize() {
close();
}
- public void
MarkGaox commented on code in PR #2735:
URL: https://github.com/apache/helix/pull/2735#discussion_r1470558265
##
helix-core/src/test/java/org/apache/helix/integration/manager/ClusterManager.java:
##
@@ -34,7 +34,7 @@
public class ClusterManager extends ZKHelixManager
xyuanlu commented on code in PR #2735:
URL: https://github.com/apache/helix/pull/2735#discussion_r1470537665
##
meta-client/src/test/java/org/apache/helix/metaclient/impl/zk/TestMultiThreadStressTest/TestMultiThreadStressZKClient.java:
##
@@ -52,7 +52,7 @@ private void setUp()
junkaixue commented on code in PR #2735:
URL: https://github.com/apache/helix/pull/2735#discussion_r1470075163
##
helix-core/src/test/java/org/apache/helix/TestHelper.java:
##
@@ -278,16 +281,18 @@ public static void setupCluster(String clusterName,
String zkAddr, int
20 matches
Mail list logo
