[Impala-ASF-CR] IMPALA-6503: Support reading complex types from ORC format files

2019-01-23 Thread Quanlong Huang (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12168 to look at the new patch set (#9). Change subject: IMPALA-6503: Support reading complex types from ORC format files

[Impala-ASF-CR] IMPALA-8091: incremental improvements to NTP sync

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12253 ) Change subject: IMPALA-8091: incremental improvements to NTP sync .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR](asf-site) Remove stale meetup link

2019-01-23 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12256 ) Change subject: Remove stale meetup link .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12256 To

[Impala-ASF-CR](asf-site) Remove stale meetup link

2019-01-23 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12256 ) Change subject: Remove stale meetup link .. Remove stale meetup link Change-Id: Ia109b11e0cb65315b1bf3fa1e07540fd48c89ca3

[Impala-ASF-CR](asf-site) Remove stale meetup link

2019-01-23 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/12256 ) Change subject: Remove stale meetup link .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12256 To

[Impala-ASF-CR] IMPALA-8097: mt dop for all queries via hidden flag

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12257 ) Change subject: IMPALA-8097: mt_dop for all queries via hidden flag .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-8091: incremental improvements to NTP sync

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12253 ) Change subject: IMPALA-8091: incremental improvements to NTP sync .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-7694: Add host resource usage metrics to profile

2019-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12069 ) Change subject: IMPALA-7694: Add host resource usage metrics to profile .. Patch Set 11: (4 comments) Thanks for doing this, mostly

[Impala-ASF-CR] IMPALA-7979: Enhance decoders to support value-skipping

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12172 ) Change subject: IMPALA-7979: Enhance decoders to support value-skipping .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7979: Enhance decoders to support value-skipping

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12172 ) Change subject: IMPALA-7979: Enhance decoders to support value-skipping .. IMPALA-7979: Enhance decoders to support

[Impala-ASF-CR] IMPALA-6503: Support reading complex types from ORC format files

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12168 ) Change subject: IMPALA-6503: Support reading complex types from ORC format files .. Patch Set 9: Build Successful

[Impala-ASF-CR] IMPALA-8097: mt dop for all queries via hidden flag

2019-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12257 Change subject: IMPALA-8097: mt_dop for all queries via hidden flag .. IMPALA-8097: mt_dop for all queries via hidden flag

[Impala-ASF-CR] IMPALA-8097: mt dop for all queries via hidden flag

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12257 ) Change subject: IMPALA-8097: mt_dop for all queries via hidden flag .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12247 ) Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-8097: mt dop for all queries via hidden flag

2019-01-23 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12257 to look at the new patch set (#2). Change subject: IMPALA-8097: mt_dop for all queries via hidden flag ..

[Impala-ASF-CR] IMPALA-8097: mt dop for all queries via hidden flag

2019-01-23 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12257 to look at the new patch set (#3). Change subject: IMPALA-8097: mt_dop for all queries via hidden flag ..

[Impala-ASF-CR] Using 'master' branch of Impala-lzo and allowing test-with-docker to configure it.

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12259 ) Change subject: Using 'master' branch of Impala-lzo and allowing test-with-docker to configure it. .. Patch Set 2: Build

[Impala-ASF-CR] Support centos:7 for test-with-docker.

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12139 ) Change subject: Support centos:7 for test-with-docker. .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-8092: Add an admission controller debug page

2019-01-23 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12244 ) Change subject: IMPALA-8092: Add an admission controller debug page .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Using 'master' branch of Impala-lzo and allowing test-with-docker to configure it.

2019-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12259 ) Change subject: Using 'master' branch of Impala-lzo and allowing test-with-docker to configure it. .. Patch Set 1: Code-Review+2

[Impala-ASF-CR] IMPALA-7980: Fix spinning because of buggy num unqueued files .

2019-01-23 Thread Philip Zeyliger (Code Review)
Hello Michael Ho, Todd Lipcon, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12097 to look at the new patch set (#3). Change subject: IMPALA-7980: Fix spinning because of buggy num_unqueued_files_.

[Impala-ASF-CR] Using 'master' branch of Impala-lzo and allowing test-with-docker to configure it.

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12259 ) Change subject: Using 'master' branch of Impala-lzo and allowing test-with-docker to configure it. .. Patch Set 1: Build

[Impala-ASF-CR] Support centos:7 for test-with-docker.

2019-01-23 Thread Philip Zeyliger (Code Review)
Hello Laszlo Gaal, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12139 to look at the new patch set (#2). Change subject: Support centos:7 for test-with-docker.

[Impala-ASF-CR] Support centos:7 for test-with-docker.

2019-01-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12139 ) Change subject: Support centos:7 for test-with-docker. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7980: Fix spinning because of buggy num unqueued files .

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12097 ) Change subject: IMPALA-7980: Fix spinning because of buggy num_unqueued_files_. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8092: Add an admission controller debug page

2019-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12244 ) Change subject: IMPALA-8092: Add an admission controller debug page .. Patch Set 1: (1 comment)

[Impala-ASF-CR] Support centos:7 for test-with-docker.

2019-01-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12139 ) Change subject: Support centos:7 for test-with-docker. .. Patch Set 1: (1 comment) I just have a small question about ntpd on

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-01-23 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 2: (19 comments)

[Impala-ASF-CR] IMPALA-7980: Fix spinning because of buggy num unqueued files .

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12097 ) Change subject: IMPALA-7980: Fix spinning because of buggy num_unqueued_files_. .. Patch Set 3: Build Failed

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 1: Build Successful

[Impala-ASF-CR] Support centos:7 for test-with-docker.

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12139 ) Change subject: Support centos:7 for test-with-docker. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Using 'master' branch of Impala-lzo and allowing test-with-docker to configure it.

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12259 ) Change subject: Using 'master' branch of Impala-lzo and allowing test-with-docker to configure it. .. Patch Set 2:

[Impala-ASF-CR] Support centos:7 for test-with-docker.

2019-01-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12139 ) Change subject: Support centos:7 for test-with-docker. .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Support centos:7 for test-with-docker.

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12139 ) Change subject: Support centos:7 for test-with-docker. .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Support centos:7 for test-with-docker.

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12139 ) Change subject: Support centos:7 for test-with-docker. .. Patch Set 3: Build started:

[Impala-ASF-CR] Using 'master' branch of Impala-lzo and allowing test-with-docker to configure it.

2019-01-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12259 Change subject: Using 'master' branch of Impala-lzo and allowing test-with-docker to configure it. .. Using 'master' branch of

[Impala-ASF-CR] IMPALA-7980: Fix spinning because of buggy num unqueued files .

2019-01-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12097 ) Change subject: IMPALA-7980: Fix spinning because of buggy num_unqueued_files_. .. Patch Set 3: (12 comments) Thanks for the

[Impala-ASF-CR] IMPALA-7980: Fix spinning because of buggy num unqueued files .

2019-01-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12097 ) Change subject: IMPALA-7980: Fix spinning because of buggy num_unqueued_files_. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12260 Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. IMPALA-7985: Port RemoteShutdown() to KRPC. The :shutdown command is

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-23 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#12). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers

[Impala-ASF-CR] IMPALA-8092: Add an admission controller debug page

2019-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12244 ) Change subject: IMPALA-8092: Add an admission controller debug page .. Patch Set 1: (19 comments) This is cool - I checked it out

[Impala-ASF-CR] IMPALA-8091: incremental improvements to NTP sync

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12253 ) Change subject: IMPALA-8091: incremental improvements to NTP sync .. IMPALA-8091: incremental improvements to NTP sync

[Impala-ASF-CR] IMPALA-8091: incremental improvements to NTP sync

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12253 ) Change subject: IMPALA-8091: incremental improvements to NTP sync .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-01-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12247 ) Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet .. Patch Set 3: (7 comments) About 'parquet-tools dump':

[Impala-ASF-CR] IMPALA-7800: Reject new connections after --fe service threads

2019-01-23 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/12226 ) Change subject: IMPALA-7800: Reject new connections after --fe_service_threads .. Patch Set 6: > I meant "the timeout can also be

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12248 ) Change subject: IMPALA-8095: Detailed expression cardinality tests .. Patch Set 2: Rebased on latest master. A catalog_.close() line

[Impala-ASF-CR] IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging

2019-01-23 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11915 to look at the new patch set (#3). Change subject: IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-23 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 12: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 13: Build started:

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 13: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7934: Switch to java.util.Base64 implementation

2019-01-23 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12250 ) Change subject: IMPALA-7934: Switch to java.util.Base64 implementation .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 12: (1 comment) Addressed the code review comment.

[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-01-23 Thread Csaba Ringhofer (Code Review)
Hello Zoltan Borok-Nagy, Zoltan Ivanfi, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12247 to look at the new patch set (#5). Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet

[Impala-ASF-CR] IMPALA-7866: Predicates, helpers for implicit casts, slot refs

2019-01-23 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11953 to look at the new patch set (#3). Change subject: IMPALA-7866: Predicates, helpers for implicit casts, slot refs

[Impala-ASF-CR] IMPALA-7866: Predicates, helpers for implicit casts, slot refs

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11953 ) Change subject: IMPALA-7866: Predicates, helpers for implicit casts, slot refs .. Patch Set 2: Rebased on latest master to resolve

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

2019-01-23 Thread Paul Rogers (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12248 to look at the new patch set (#3). Change subject: IMPALA-8095: Detailed expression cardinality tests ..

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12248 ) Change subject: IMPALA-8095: Detailed expression cardinality tests .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-7866: Predicates, helpers for implicit casts, slot refs

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11953 ) Change subject: IMPALA-7866: Predicates, helpers for implicit casts, slot refs .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8041, Part 1: Move rewrite rules into expr nodes

2019-01-23 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12143 to look at the new patch set (#2). Change subject: IMPALA-8041, Part 1: Move rewrite rules into expr nodes

[Impala-ASF-CR] IMPALA-8041, Part 1: Move rewrite rules into expr nodes

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12143 ) Change subject: IMPALA-8041, Part 1: Move rewrite rules into expr nodes .. Patch Set 2: Rebased on latest master. Resolved check style

[Impala-ASF-CR] IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11915 ) Change subject: IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging .. Patch Set 3: (1 comment) Addressed review comment.

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 12: Build Successful

[Impala-ASF-CR] IMPALA-7927: Enhance Rewritten SQL in test files

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12033 ) Change subject: IMPALA-7927: Enhance Rewritten SQL in test files .. Patch Set 1: Hi Bharath, this one should be a simple one; please

[Impala-ASF-CR] IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11915 ) Change subject: IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12079 ) Change subject: IMPALA-7968, Part 1: JSON serialization framework .. Patch Set 8: Hi Bharath, Fredy gave this a +1. Can you take a

[Impala-ASF-CR] IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11915 ) Change subject: IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging .. Patch Set 4: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging

2019-01-23 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11915 ) Change subject: IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging .. Patch Set 3: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8058: Fallback for HBase key scan range estimation

2019-01-23 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12192 ) Change subject: IMPALA-8058: Fallback for HBase key scan range estimation .. Patch Set 2: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-7970 : Add support for metastore event based automatic invalidate

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for metastore event based automatic invalidate .. Patch Set 22: (3 comments) Thanks much

[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12247 ) Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12248 ) Change subject: IMPALA-8095: Detailed expression cardinality tests .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S)

2019-01-23 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12181 ) Change subject: IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S) .. Patch Set 8: Paul, Bharath gave a +1, can you

[Impala-ASF-CR] IMPALA-7866: Predicates, helpers for implicit casts, slot refs

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11953 ) Change subject: IMPALA-7866: Predicates, helpers for implicit casts, slot refs .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-8041, Part 1: Move rewrite rules into expr nodes

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12143 ) Change subject: IMPALA-8041, Part 1: Move rewrite rules into expr nodes .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-8041, Part 2: Refactor SELECT list

2019-01-23 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12144 ) Change subject: IMPALA-8041, Part 2: Refactor SELECT list .. Patch Set 2: (6 comments) Couple nits, but LGTM.

[Impala-ASF-CR] IMPALA-7929. Impala query on HBASE table failing with InternalException.

2019-01-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12213 ) Change subject: IMPALA-7929. Impala query on HBASE table failing with InternalException. .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11915 ) Change subject: IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 2: (3 comments) Minor suggestions, otherwise looks pretty

[Impala-ASF-CR] IMPALA-7929. Impala query on HBASE table failing with InternalException.

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12213 ) Change subject: IMPALA-7929. Impala query on HBASE table failing with InternalException. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

2019-01-23 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12248 to look at the new patch set (#4). Change subject: IMPALA-8095: Detailed expression cardinality tests

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12248 ) Change subject: IMPALA-8095: Detailed expression cardinality tests .. Patch Set 4: Fixed check style issues. -- To view, visit

[Impala-ASF-CR] IMPALA-8041, Part 2: Refactor SELECT list

2019-01-23 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12144 to look at the new patch set (#3). Change subject: IMPALA-8041, Part 2: Refactor SELECT list

[Impala-ASF-CR] IMPALA-8041, Part 2: Refactor SELECT list

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12144 ) Change subject: IMPALA-8041, Part 2: Refactor SELECT list .. Patch Set 2: (6 comments) Thanks Fredy for the review. Addressed your

[Impala-ASF-CR] IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S)

2019-01-23 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12181 ) Change subject: IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S) .. Patch Set 8: Code-Review+1 LGTM -- To view,

[Impala-ASF-CR] IMPALA-8058: Fallback for HBase key scan range estimation

2019-01-23 Thread Paul Rogers (Code Review)
Hello Bharath Vissapragada, Zoram Thanga, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12192 to look at the new patch set (#3). Change subject: IMPALA-8058: Fallback for HBase key scan range estimation

[Impala-ASF-CR] IMPALA-7941: part 1: detect cgroups memory limit

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12120 ) Change subject: IMPALA-7941: part 1: detect cgroups memory limit .. IMPALA-7941: part 1: detect cgroups memory limit

[Impala-ASF-CR] IMPALA-7941: part 1: detect cgroups memory limit

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12120 ) Change subject: IMPALA-7941: part 1: detect cgroups memory limit .. Patch Set 14: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7979: Enhance decoders to support value-skipping

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12172 ) Change subject: IMPALA-7979: Enhance decoders to support value-skipping .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-7979: Enhance decoders to support value-skipping

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12172 ) Change subject: IMPALA-7979: Enhance decoders to support value-skipping .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5051: Add INT64 timestamp write support in Parquet

2019-01-23 Thread Csaba Ringhofer (Code Review)
Hello Zoltan Borok-Nagy, Zoltan Ivanfi, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12247 to look at the new patch set (#4). Change subject: IMPALA-5051: Add INT64 timestamp write support in Parquet

[Impala-ASF-CR](asf-site) Remove stale meetup link

2019-01-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12256 Change subject: Remove stale meetup link .. Remove stale meetup link Change-Id: Ia109b11e0cb65315b1bf3fa1e07540fd48c89ca3 --- M

[Impala-ASF-CR] IMPALA-8041, Part 2: Refactor SELECT list

2019-01-23 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12144 ) Change subject: IMPALA-8041, Part 2: Refactor SELECT list .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] Support centos:7 for test-with-docker.

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12139 ) Change subject: Support centos:7 for test-with-docker. .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] Support centos:7 for test-with-docker.

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12139 ) Change subject: Support centos:7 for test-with-docker. .. Support centos:7 for test-with-docker. As a follow-on to

[Impala-ASF-CR] IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11915 ) Change subject: IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11915 ) Change subject: IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging .. IMPALA-7841 (Part 1): Refactor

[Impala-ASF-CR] IMPALA-7941: part 2/2: use cgroups memory limit

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12262 ) Change subject: IMPALA-7941: part 2/2: use cgroups memory limit .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7941: part 2/2: use cgroups memory limit

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12262 ) Change subject: IMPALA-7941: part 2/2: use cgroups memory limit .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-7941: part 2/2: use cgroups memory limit

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12262 ) Change subject: IMPALA-7941: part 2/2: use cgroups memory limit .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7941: part 2/2: use cgroups memory limit

2019-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12262 ) Change subject: IMPALA-7941: part 2/2: use cgroups memory limit .. Patch Set 2: Build Successful

  1   2   >