[Impala-ASF-CR] IMPALA-10152: Add support for Iceberg HiveCatalog

2020-11-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16721 ) Change subject: IMPALA-10152: Add support for Iceberg HiveCatalog .. Patch Set 2: (16 comments) Thanks for the comments!

[Impala-ASF-CR] IMPALA-10152: Add support for Iceberg HiveCatalog

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16721 ) Change subject: IMPALA-10152: Add support for Iceberg HiveCatalog .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-18 Thread wangsheng (Code Review)
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. Patch Set 7: > (1 comment) We need to use relative path

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. Patch Set 7: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-10152: Add support for Iceberg HiveCatalog

2020-11-18 Thread Zoltan Borok-Nagy (Code Review)
Hello Gabor Kaszab, wangsheng, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16721 to look at the new patch set (#2). Change subject: IMPALA-10152: Add support for Iceberg HiveCatalog

[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command fails

2020-11-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has restored this change. ( http://gerrit.cloudera.org:8080/16322 ) Change subject: IMPALA-10066: Fix test_cancellation_mid_command fails .. Restored -- To view, visit http://gerrit.cloudera.org:8080/16322 To

[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command fails

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16322 ) Change subject: IMPALA-10066: Fix test_cancellation_mid_command fails .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command fails

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16322 ) Change subject: IMPALA-10066: Fix test_cancellation_mid_command fails .. Patch Set 6: Build failed:

[Impala-ASF-CR] IMPALA-10152: Add support for Iceberg HiveCatalog

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16721 ) Change subject: IMPALA-10152: Add support for Iceberg HiveCatalog .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-10318: default transactional type shouldn't affect Iceberg tables

2020-11-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16742 Change subject: IMPALA-10318: default_transactional_type shouldn't affect Iceberg tables .. IMPALA-10318:

[Impala-ASF-CR] IMPALA-10340: Cannot set up KDC from scratch

2020-11-18 Thread Attila Doroszlai (Code Review)
Attila Doroszlai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16744 Change subject: IMPALA-10340: Cannot set up KDC from scratch .. IMPALA-10340: Cannot set up KDC from scratch IMPALA-9361 added

[Impala-ASF-CR] IMPALA-10340: Cannot set up KDC from scratch

2020-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16744 ) Change subject: IMPALA-10340: Cannot set up KDC from scratch .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10340: Cannot set up KDC from scratch

2020-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16744 ) Change subject: IMPALA-10340: Cannot set up KDC from scratch .. Patch Set 1: Makes sense, thanks for taking the initiative to improve

[Impala-ASF-CR] IMPALA-10286: Disable metadata.test catalogd debug actions on S3

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16745 ) Change subject: IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3 .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10286: Disable metadata.test catalogd debug actions on S3

2020-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16745 ) Change subject: IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3 .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10286: Disable metadata.test catalogd debug actions on S3

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16745 ) Change subject: IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3 .. Patch Set 3: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-10286: Disable metadata.test catalogd debug actions on S3

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16745 ) Change subject: IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3 .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-10318: default transactional type shouldn't affect Iceberg tables

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16742 ) Change subject: IMPALA-10318: default_transactional_type shouldn't affect Iceberg tables .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-10318: default transactional type shouldn't affect Iceberg tables

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16742 ) Change subject: IMPALA-10318: default_transactional_type shouldn't affect Iceberg tables .. Patch Set 2: Code-Review+2 --

[Impala-ASF-CR] IMPALA-10318: default transactional type shouldn't affect Iceberg tables

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16742 ) Change subject: IMPALA-10318: default_transactional_type shouldn't affect Iceberg tables .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-10332: Add file formats to HdfsScanNode's thrift representation.

2020-11-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16728 ) Change subject: IMPALA-10332: Add file formats to HdfsScanNode's thrift representation. .. Patch Set 5: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-10189: addendum: improve comment

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16557 ) Change subject: IMPALA-10189: addendum: improve comment .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-10189: addendum: improve comment

2020-11-18 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16557 ) Change subject: IMPALA-10189: addendum: improve comment .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10340: Cannot set up KDC from scratch

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16744 ) Change subject: IMPALA-10340: Cannot set up KDC from scratch .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-7523: increase hbase assignment timeout

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16740 ) Change subject: IMPALA-7523: increase hbase assignment timeout .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7523: increase hbase assignment timeout

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16740 ) Change subject: IMPALA-7523: increase hbase assignment timeout .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-10286: Disable metadata.test catalogd debug actions on S3

2020-11-18 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16745 Change subject: IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3 .. IMPALA-10286: Disable

[Impala-ASF-CR] IMPALA-10286: Disable metadata.test catalogd debug actions on S3

2020-11-18 Thread Vihang Karajgaonkar (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16745 to look at the new patch set (#2). Change subject: IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3

[Impala-ASF-CR] IMPALA-10161: User LDAP Search bind support

2020-11-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16717 ) Change subject: IMPALA-10161: User LDAP Search bind support .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command fails

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16322 ) Change subject: IMPALA-10066: Fix test_cancellation_mid_command fails .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-10332: Add file formats to HdfsScanNode's thrift representation.

2020-11-18 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16728 Change subject: IMPALA-10332: Add file formats to HdfsScanNode's thrift representation. .. IMPALA-10332: Add file formats to

[Impala-ASF-CR] IMPALA-10332: Add file formats to HdfsScanNode's thrift representation.

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16728 ) Change subject: IMPALA-10332: Add file formats to HdfsScanNode's thrift representation. .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-10283: Fix IllegalStateException in applying incremental partition updates

2020-11-18 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16649 ) Change subject: IMPALA-10283: Fix IllegalStateException in applying incremental partition updates .. Patch Set 4: Code-Review+2

[Impala-ASF-CR] IMPALA-10332: Add file formats to HdfsScanNode's thrift representation.

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16728 ) Change subject: IMPALA-10332: Add file formats to HdfsScanNode's thrift representation. .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-10332: Add file formats to HdfsScanNode's thrift representation.

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16728 ) Change subject: IMPALA-10332: Add file formats to HdfsScanNode's thrift representation. .. Patch Set 6: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-10340: Cannot set up KDC from scratch

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16744 ) Change subject: IMPALA-10340: Cannot set up KDC from scratch .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-10318: default transactional type shouldn't affect Iceberg tables

2020-11-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16742 ) Change subject: IMPALA-10318: default_transactional_type shouldn't affect Iceberg tables .. Patch Set 1: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-10189: addendum: improve comment

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16557 ) Change subject: IMPALA-10189: addendum: improve comment .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10340: Cannot set up KDC from scratch

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16744 ) Change subject: IMPALA-10340: Cannot set up KDC from scratch .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-10286: Disable metadata.test catalogd debug actions on S3

2020-11-18 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16745 ) Change subject: IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3 .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10249: Fix the flaky TestImpalaShell.test queries closed test.

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16743 ) Change subject: IMPALA-10249: Fix the flaky TestImpalaShell.test_queries_closed test. .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-10249: Fix the flaky TestImpalaShell.test queries closed test.

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16743 ) Change subject: IMPALA-10249: Fix the flaky TestImpalaShell.test_queries_closed test. .. Patch Set 2: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-10252: fix invalid runtime filters for outer joins

2020-11-18 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16622 ) Change subject: IMPALA-10252: fix invalid runtime filters for outer joins .. Patch Set 6: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10249: Fix the flaky TestImpalaShell.test queries closed test.

2020-11-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16743 Change subject: IMPALA-10249: Fix the flaky TestImpalaShell.test_queries_closed test. .. IMPALA-10249: Fix the flaky

[Impala-ASF-CR] IMPALA-10152: Add support for Iceberg HiveCatalog

2020-11-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16721 ) Change subject: IMPALA-10152: Add support for Iceberg HiveCatalog .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-10249: Fix the flaky TestImpalaShell.test queries closed test.

2020-11-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16743 ) Change subject: IMPALA-10249: Fix the flaky TestImpalaShell.test_queries_closed test. .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-10249: Fix the flaky TestImpalaShell.test queries closed test.

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16743 ) Change subject: IMPALA-10249: Fix the flaky TestImpalaShell.test_queries_closed test. .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-10276: thread-safe access to RuntimeProfile::counter map

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16739 ) Change subject: IMPALA-10276: thread-safe access to RuntimeProfile::counter_map_ .. Patch Set 4: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-10276: thread-safe access to RuntimeProfile::counter map

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16739 ) Change subject: IMPALA-10276: thread-safe access to RuntimeProfile::counter_map_ .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-10286: Disable metadata.test catalogd debug actions on S3

2020-11-18 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16745 ) Change subject: IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3 .. Patch Set 2: Code-Review+2 Carrying forward

[Impala-ASF-CR] IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables

2020-11-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16599 ) Change subject: IMPALA-10288: Implement DESCRIBE HISTORY for Iceberg tables .. Patch Set 7: I created this test table by Impala

[Impala-ASF-CR] IMPALA-10066: Fix test cancellation mid command fails

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16322 ) Change subject: IMPALA-10066: Fix test_cancellation_mid_command fails .. Patch Set 7: Verified-1 Build failed:

[Impala-ASF-CR] WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16741 ) Change subject: WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions .. Patch Set 1:

[Impala-ASF-CR] IMPALA-10314: Optimize planning time for simple limits

2020-11-18 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16723 ) Change subject: IMPALA-10314: Optimize planning time for simple limits .. Patch Set 4: (1 comment) Looks nice! In addition to the

[Impala-ASF-CR] WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16741 ) Change subject: WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions .. Patch Set 1: (1

[Impala-ASF-CR] IMPALA-10152: Add support for Iceberg HiveCatalog

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16721 ) Change subject: IMPALA-10152: Add support for Iceberg HiveCatalog .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions

2020-11-18 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16741 Change subject: WiP: IMPALA-10237: Support Bucket and Truncate partition transforms as built-in functions .. WiP: IMPALA-10237: Support

[Impala-ASF-CR] IMPALA-10189: addendum: improve comment

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16557 ) Change subject: IMPALA-10189: addendum: improve comment .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-10314: Temporarily set optimize simple limit to true for testing.

2020-11-18 Thread Aman Sinha (Code Review)
Aman Sinha has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16747 Change subject: IMPALA-10314: Temporarily set optimize_simple_limit to true for testing. .. IMPALA-10314: Temporarily set

[Impala-ASF-CR] IMPALA-10340: Cannot set up KDC from scratch

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16744 ) Change subject: IMPALA-10340: Cannot set up KDC from scratch .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10332: Add file formats to HdfsScanNode's thrift representation.

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16728 ) Change subject: IMPALA-10332: Add file formats to HdfsScanNode's thrift representation. .. Patch Set 6: Verified-1 Build

[Impala-ASF-CR] IMPALA-10276: thread-safe access to RuntimeProfile::counter map

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16739 ) Change subject: IMPALA-10276: thread-safe access to RuntimeProfile::counter_map_ .. Patch Set 4: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-10276: thread-safe access to RuntimeProfile::counter map

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16739 ) Change subject: IMPALA-10276: thread-safe access to RuntimeProfile::counter_map_ .. IMPALA-10276: thread-safe access

[Impala-ASF-CR] IMPALA-10249: Fix the flaky TestImpalaShell.test queries closed test.

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16743 ) Change subject: IMPALA-10249: Fix the flaky TestImpalaShell.test_queries_closed test. .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-10314: Temporarily set optimize simple limit to true for testing.

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16747 ) Change subject: IMPALA-10314: Temporarily set optimize_simple_limit to true for testing. .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-10314: Temporarily set optimize simple limit to true for testing.

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16747 ) Change subject: IMPALA-10314: Temporarily set optimize_simple_limit to true for testing. .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-9930 (part 2): Introduce new admission control rpc service

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16412 ) Change subject: IMPALA-9930 (part 2): Introduce new admission control rpc service .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-10249: Fix the flaky TestImpalaShell.test queries closed test.

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16743 ) Change subject: IMPALA-10249: Fix the flaky TestImpalaShell.test_queries_closed test. .. Patch Set 2: Verified-1 Build

[Impala-ASF-CR] IMPALA-10318: default transactional type shouldn't affect Iceberg tables

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16742 ) Change subject: IMPALA-10318: default_transactional_type shouldn't affect Iceberg tables .. Patch Set 2: Verified+1 -- To

[Impala-ASF-CR] IMPALA-10318: default transactional type shouldn't affect Iceberg tables

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16742 ) Change subject: IMPALA-10318: default_transactional_type shouldn't affect Iceberg tables .. IMPALA-10318:

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2020-11-18 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has removed Anurag Mantripragada from this change. ( http://gerrit.cloudera.org:8080/14272 ) Change subject: IMPALA-8795 : Enable event polling by default in dockerized tests. .. Removed reviewer Anurag

[Impala-ASF-CR] IMPALA-10286: Disable metadata.test catalogd debug actions on S3

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16745 ) Change subject: IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3 .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-10286: Disable metadata.test catalogd debug actions on S3

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16745 ) Change subject: IMPALA-10286: Disable metadata.test_catalogd_debug_actions on S3 .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-9930 (part 2): Introduce new admission control rpc service

2020-11-18 Thread Thomas Tauber-Marshall (Code Review)
Hello Sahil Takiar, Joe McDonnell, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16412 to look at the new patch set (#8). Change subject: IMPALA-9930 (part 2): Introduce new admission control rpc

[Impala-ASF-CR] IMPALA-9930 (part 2): Introduce new admission control rpc service

2020-11-18 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16412 ) Change subject: IMPALA-9930 (part 2): Introduce new admission control rpc service .. Patch Set 8: (4 comments)

[Impala-ASF-CR] IMPALA-9930 (part 2): Introduce new admission control rpc service

2020-11-18 Thread Thomas Tauber-Marshall (Code Review)
Hello Sahil Takiar, Joe McDonnell, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16412 to look at the new patch set (#9). Change subject: IMPALA-9930 (part 2): Introduce new admission control rpc

[Impala-ASF-CR] IMPALA-9930 (part 2): Introduce new admission control rpc service

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16412 ) Change subject: IMPALA-9930 (part 2): Introduce new admission control rpc service .. Patch Set 9: Build Successful

[Impala-ASF-CR] IMPALA-10314: Optimize planning time for simple limits

2020-11-18 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16723 ) Change subject: IMPALA-10314: Optimize planning time for simple limits .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-10340: Cannot set up KDC from scratch

2020-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16744 ) Change subject: IMPALA-10340: Cannot set up KDC from scratch .. IMPALA-10340: Cannot set up KDC from scratch IMPALA-9361

[Impala-ASF-CR] IMPALA-10189: addendum: improve comment

2020-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16557 ) Change subject: IMPALA-10189: addendum: improve comment .. IMPALA-10189: addendum: improve comment Change-Id:

[Impala-ASF-CR] IMPALA-10189: addendum: improve comment

2020-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16557 ) Change subject: IMPALA-10189: addendum: improve comment .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10189: addendum: improve comment

2020-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has removed a vote on this change. Change subject: IMPALA-10189: addendum: improve comment .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/16557 To unsubscribe,

[Impala-ASF-CR] IMPALA-10189: addendum: improve comment

2020-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16557 ) Change subject: IMPALA-10189: addendum: improve comment .. Patch Set 2: Hit IMPALA-10316. Going to override since it's so trivial.

[Impala-ASF-CR] IMPALA-10314: Optimize planning time for simple limits

2020-11-18 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16723 ) Change subject: IMPALA-10314: Optimize planning time for simple limits .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 ) Change subject: IMPALA-10329 Change apt install retry times to 30 .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30

2020-11-18 Thread Anonymous Coward (Code Review)
zhaoren...@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 ) Change subject: IMPALA-10329 Change apt install retry times to 30 .. Patch Set 3: For 'I find the two solutions different,

[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30

2020-11-18 Thread Anonymous Coward (Code Review)
zhaoren...@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 ) Change subject: IMPALA-10329 Change apt install retry times to 30 .. Patch Set 3: for 'why should it be done', no reason,

[Impala-ASF-CR] IMPALA-9121: try to avoid ASAN error in hdfs-util-test

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16748 ) Change subject: IMPALA-9121: try to avoid ASAN error in hdfs-util-test .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-10314: Optimize planning time for simple limits

2020-11-18 Thread Aman Sinha (Code Review)
Hello Qifan Chen, Shant Hovsepian, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16723 to look at the new patch set (#5). Change subject: IMPALA-10314: Optimize planning time for simple limits

[Impala-ASF-CR] IMPALA-10314: Optimize planning time for simple limits

2020-11-18 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16723 ) Change subject: IMPALA-10314: Optimize planning time for simple limits .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-10314: Optimize planning time for simple limits

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16723 ) Change subject: IMPALA-10314: Optimize planning time for simple limits .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-10249: Fix the flaky TestImpalaShell.test queries closed test.

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16743 ) Change subject: IMPALA-10249: Fix the flaky TestImpalaShell.test_queries_closed test. .. IMPALA-10249: Fix the flaky

[Impala-ASF-CR] IMPALA-10249: Fix the flaky TestImpalaShell.test queries closed test.

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16743 ) Change subject: IMPALA-10249: Fix the flaky TestImpalaShell.test_queries_closed test. .. Patch Set 2: Verified+1 -- To

[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 ) Change subject: IMPALA-10329 Change apt install retry times to 30 .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30

2020-11-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 ) Change subject: IMPALA-10329 Change apt install retry times to 30 .. Patch Set 3: > And I think this solution is same with 'changeing for

[Impala-ASF-CR] IMPALA-9121: try to avoid ASAN error in hdfs-util-test

2020-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16748 Change subject: IMPALA-9121: try to avoid ASAN error in hdfs-util-test .. IMPALA-9121: try to avoid ASAN error in hdfs-util-test I

[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30

2020-11-18 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 ) Change subject: IMPALA-10329 Change apt install retry times to 30 .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30

2020-11-18 Thread Anonymous Coward (Code Review)
zhaoren...@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 ) Change subject: IMPALA-10329 Change apt install retry times to 30 .. Patch Set 3: Don't output to the console. And I think

[Impala-ASF-CR] IMPALA-10329 Change apt install retry times to 30

2020-11-18 Thread Anonymous Coward (Code Review)
zhaoren...@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/16725 ) Change subject: IMPALA-10329 Change apt install retry times to 30 .. Patch Set 2: Hi, Jim, as your suggest, I add the wait

  1   2   >