[Impala-ASF-CR] IMPALA-10061 Fix bugs of IMPALA-9645

2020-08-11 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/16306 )

Change subject: IMPALA-10061 Fix bugs of IMPALA-9645
..

IMPALA-10061 Fix bugs of IMPALA-9645

Fix one bug of IMPALA-9645.

And fix issue when return type is decimal,
codegen code lack a 'StructRet' attribute,
this is not a issue on x86, but on aarch64,
the "StructRet" attribute is necessary.

And fix the hash function on aarch64.

Change-Id: I219588992715b7d5c69cd7c0d48ff4d90b980338
Reviewed-on: http://gerrit.cloudera.org:8080/16306
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M be/src/codegen/llvm-codegen.cc
M be/src/exprs/scalar-fn-call.cc
M be/src/gutil/sysinfo.cc
M be/src/gutil/sysinfo.h
4 files changed, 50 insertions(+), 4 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/16306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I219588992715b7d5c69cd7c0d48ff4d90b980338
Gerrit-Change-Number: 16306
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-10061 Fix bugs of IMPALA-9645

2020-08-11 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16306 )

Change subject: IMPALA-10061 Fix bugs of IMPALA-9645
..


Patch Set 3: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/16306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I219588992715b7d5c69cd7c0d48ff4d90b980338
Gerrit-Change-Number: 16306
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 12 Aug 2020 04:45:19 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10061 Fix bugs of IMPALA-9645

2020-08-11 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16306 )

Change subject: IMPALA-10061 Fix bugs of IMPALA-9645
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6271/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/16306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I219588992715b7d5c69cd7c0d48ff4d90b980338
Gerrit-Change-Number: 16306
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 11 Aug 2020 23:32:37 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10061 Fix bugs of IMPALA-9645

2020-08-11 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16306 )

Change subject: IMPALA-10061 Fix bugs of IMPALA-9645
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/16306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I219588992715b7d5c69cd7c0d48ff4d90b980338
Gerrit-Change-Number: 16306
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 11 Aug 2020 23:32:36 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10061 Fix bugs of IMPALA-9645

2020-08-10 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16306 )

Change subject: IMPALA-10061 Fix bugs of IMPALA-9645
..


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6255/


--
To view, visit http://gerrit.cloudera.org:8080/16306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I219588992715b7d5c69cd7c0d48ff4d90b980338
Gerrit-Change-Number: 16306
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 10 Aug 2020 22:19:51 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10061 Fix bugs of IMPALA-9645

2020-08-10 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16306 )

Change subject: IMPALA-10061 Fix bugs of IMPALA-9645
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6255/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/16306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I219588992715b7d5c69cd7c0d48ff4d90b980338
Gerrit-Change-Number: 16306
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 10 Aug 2020 16:58:58 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10061 Fix bugs of IMPALA-9645

2020-08-10 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16306 )

Change subject: IMPALA-10061 Fix bugs of IMPALA-9645
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/16306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I219588992715b7d5c69cd7c0d48ff4d90b980338
Gerrit-Change-Number: 16306
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 10 Aug 2020 16:58:02 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10061 Fix bugs of IMPALA-9645

2020-08-10 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16306 )

Change subject: IMPALA-10061 Fix bugs of IMPALA-9645
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/6847/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/16306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I219588992715b7d5c69cd7c0d48ff4d90b980338
Gerrit-Change-Number: 16306
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 10 Aug 2020 11:24:45 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10061 Fix bugs of IMPALA-9645

2020-08-10 Thread Anonymous Coward (Code Review) 
zhaoren...@hotmail.com has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16306 )

Change subject: IMPALA-10061 Fix bugs of IMPALA-9645
..


Patch Set 2:

Hi, Tim, this has been fixed as your request


--
To view, visit http://gerrit.cloudera.org:8080/16306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I219588992715b7d5c69cd7c0d48ff4d90b980338
Gerrit-Change-Number: 16306
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Mon, 10 Aug 2020 11:05:16 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10061 Fix bugs of IMPALA-9645

2020-08-10 Thread Anonymous Coward (Code Review) 
zhaoren...@hotmail.com has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/16306 )

Change subject: IMPALA-10061 Fix bugs of IMPALA-9645
..

IMPALA-10061 Fix bugs of IMPALA-9645

Fix one bug of IMPALA-9645.

And fix issue when return type is decimal,
codegen code lack a 'StructRet' attribute,
this is not a issue on x86, but on aarch64,
the "StructRet" attribute is necessary.

And fix the hash function on aarch64.

Change-Id: I219588992715b7d5c69cd7c0d48ff4d90b980338
---
M be/src/codegen/llvm-codegen.cc
M be/src/exprs/scalar-fn-call.cc
M be/src/gutil/sysinfo.cc
M be/src/gutil/sysinfo.h
4 files changed, 50 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/16306/2
--
To view, visit http://gerrit.cloudera.org:8080/16306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I219588992715b7d5c69cd7c0d48ff4d90b980338
Gerrit-Change-Number: 16306
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-10061 Fix bugs of IMPALA-9645

2020-08-07 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16306 )

Change subject: IMPALA-10061 Fix bugs of IMPALA-9645
..


Patch Set 1:

Build Failed

https://jenkins.impala.io/job/gerrit-code-review-checks/6837/ : Initial code 
review checks failed. See linked job for details on the failure.


--
To view, visit http://gerrit.cloudera.org:8080/16306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I219588992715b7d5c69cd7c0d48ff4d90b980338
Gerrit-Change-Number: 16306
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 07 Aug 2020 21:13:24 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10061 Fix bugs of IMPALA-9645

2020-08-07 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16306 )

Change subject: IMPALA-10061 Fix bugs of IMPALA-9645
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16306/1/be/src/codegen/llvm-codegen.cc
File be/src/codegen/llvm-codegen.cc:

http://gerrit.cloudera.org:8080/#/c/16306/1/be/src/codegen/llvm-codegen.cc@1613
PS1, Line 1613:   if (IsCPUFeatureEnabled(CpuInfo::SSE4_2)) {
I think it's confusing for readers to #ifdef control flow structures like this. 
Can you reworked it, e.g. by defining a new constant or macro to something like:

  if (IS_AARCH64 || IsCPUFeatureEnabled(CpuInfo::SSE4_2).


http://gerrit.cloudera.org:8080/#/c/16306/1/be/src/exprs/scalar-fn-call.cc
File be/src/exprs/scalar-fn-call.cc:

http://gerrit.cloudera.org:8080/#/c/16306/1/be/src/exprs/scalar-fn-call.cc@351
PS1, Line 351: PrimitiveType col_type = children_[i]->type().type;
I think you need to undo this change - it caused a clang-tidy failure because 
it's an unused variable on x86



--
To view, visit http://gerrit.cloudera.org:8080/16306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I219588992715b7d5c69cd7c0d48ff4d90b980338
Gerrit-Change-Number: 16306
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 07 Aug 2020 21:07:59 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10061 Fix bugs of IMPALA-9645

2020-08-07 Thread Anonymous Coward (Code Review) 
zhaoren...@hotmail.com has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/16306


Change subject: IMPALA-10061 Fix bugs of IMPALA-9645
..

IMPALA-10061 Fix bugs of IMPALA-9645

Fix one bug of IMPALA-9645.

And fix issue when return type is decimal,
codegen code lack a 'StructRet' attribute,
this is not a issue on x86, but on aarch64,
the "StructRet" attribute is necessary.

And fix the hash function on aarch64.

Change-Id: I219588992715b7d5c69cd7c0d48ff4d90b980338
---
M be/src/codegen/llvm-codegen.cc
M be/src/exprs/scalar-fn-call.cc
2 files changed, 39 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/16306/1
--
To view, visit http://gerrit.cloudera.org:8080/16306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I219588992715b7d5c69cd7c0d48ff4d90b980338
Gerrit-Change-Number: 16306
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward