[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 18: Verified+1 -- To view, visit http://

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. IMPALA-5315: Cast to timestamp fails for YYY

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 18: Build started: https://jenkins.impala

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 18: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 17: Code-Review+1 Did anyone else want to take a

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-12 Thread Vincent Tran (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7009 to look at the new patch set (#17). Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format ...

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-12 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 16: (4 comments) Changed the name of the e2e test

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 16: I started a dry run of the merge just in case

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 16: (5 comments) I think this should be the last

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-10 Thread Vincent Tran (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7009 to look at the new patch set (#16). Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format ...

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-10 Thread Vincent Tran (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7009 to look at the new patch set (#15). Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format ...

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-10 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 14: (18 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 14: (17 comments) It looks like we're getting cl

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 14: I've been neglecting reviews - need to get ba

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-02-10 Thread Vincent Tran (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7009 to look at the new patch set (#14). Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format ...

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-02-10 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 12: (10 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-02-10 Thread Vincent Tran (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7009 to look at the new patch set (#13). Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format ...

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 12: (10 comments) Sorry for the delay here. This

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-01-24 Thread Vincent Tran (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7009 to look at the new patch set (#12). Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format ...

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2017-12-17 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2017-12-17 Thread Vincent Tran (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7009 to look at the new patch set (#11). Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format ...

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2017-12-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2017-12-13 Thread Vincent Tran (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7009 to look at the new patch set (#10). Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format ...

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2017-12-13 Thread Vincent Tran (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7009 to look at the new patch set (#9). Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2017-12-13 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2017-12-13 Thread Vincent Tran (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7009 to look at the new patch set (#8). Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2017-12-13 Thread Vincent Tran (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7009 to look at the new patch set (#7). Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2017-12-13 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 6: The alternative here is that we only take this

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2017-12-13 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 6: I incorporated the same heuristic into ParseFor

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2017-12-13 Thread Vincent Tran (Code Review)
Hello Lars Volker, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7009 to look at the new patch set (#6). Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2017-12-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 5: Thanks for the update Vincent - agree that tha

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2017-12-11 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 5: Looks like the slow down is due to the 2x slowe

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2017-12-08 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 5: I ran 3 trials on both the old path and the new