[Impala-ASF-CR] IMPALA-6499: [DOCS] Fixed formatting errors in split part function

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9275 )

Change subject: IMPALA-6499: [DOCS] Fixed formatting errors in split_part 
function
..


Patch Set 6: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7623e32aaf31f21a3be4513f26deb0b789a56b1a
Gerrit-Change-Number: 9275
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 20 Feb 2018 22:09:05 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6499: [DOCS] Fixed formatting errors in split part function

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9275 )

Change subject: IMPALA-6499: [DOCS] Fixed formatting errors in split_part 
function
..

IMPALA-6499: [DOCS] Fixed formatting errors in split_part function

Change-Id: I7623e32aaf31f21a3be4513f26deb0b789a56b1a
Reviewed-on: http://gerrit.cloudera.org:8080/9275
Reviewed-by: John Russell 
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_string_functions.xml
1 file changed, 9 insertions(+), 9 deletions(-)

Approvals:
  John Russell: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7623e32aaf31f21a3be4513f26deb0b789a56b1a
Gerrit-Change-Number: 9275
Gerrit-PatchSet: 7
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-6499: [DOCS] Fixed formatting errors in split part function

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9275 )

Change subject: IMPALA-6499: [DOCS] Fixed formatting errors in split_part 
function
..


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/199/


--
To view, visit http://gerrit.cloudera.org:8080/9275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7623e32aaf31f21a3be4513f26deb0b789a56b1a
Gerrit-Change-Number: 9275
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 20 Feb 2018 21:51:57 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6499: [DOCS] Fixed formatting errors in split part function

[John Russell (Code Review)]

John Russell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9275 )

Change subject: IMPALA-6499: [DOCS] Fixed formatting errors in split_part 
function
..


Patch Set 6: Code-Review+2

I downloaded the patch and did an extra round of validation, just in case any 
XML tags got misplaced among the patch sets. Everything looks clean. Alex, 
thanks for weathering the iterations!


--
To view, visit http://gerrit.cloudera.org:8080/9275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7623e32aaf31f21a3be4513f26deb0b789a56b1a
Gerrit-Change-Number: 9275
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 20 Feb 2018 21:51:41 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6499: [DOCS] Fixed formatting errors in split part function

[Alex Rodoni (Code Review)]

Hello John Russell, Tim Armstrong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9275

to look at the new patch set (#6).

Change subject: IMPALA-6499: [DOCS] Fixed formatting errors in split_part 
function
..

IMPALA-6499: [DOCS] Fixed formatting errors in split_part function

Change-Id: I7623e32aaf31f21a3be4513f26deb0b789a56b1a
---
M docs/topics/impala_string_functions.xml
1 file changed, 9 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/9275/6
--
To view, visit http://gerrit.cloudera.org:8080/9275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7623e32aaf31f21a3be4513f26deb0b789a56b1a
Gerrit-Change-Number: 9275
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-6499: [DOCS] Fixed formatting errors in split part function

[John Russell (Code Review)]

John Russell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9275 )

Change subject: IMPALA-6499: [DOCS] Fixed formatting errors in split_part 
function
..


Patch Set 4:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/9275/4/docs/topics/impala_string_functions.xml
File docs/topics/impala_string_functions.xml:

http://gerrit.cloudera.org:8080/#/c/9275/4/docs/topics/impala_string_functions.xml@1079
PS4, Line 1079:   
Don't indent the  line.


http://gerrit.cloudera.org:8080/#/c/9275/4/docs/topics/impala_string_functions.xml@1102
PS4, Line 1102:   
  : These examples show what happens for out-of-range field
  : positions. Specifying a value less than 1 produces an error.
  : Specifying a value greater than the number of fields 
returns a
  : zero-length string (which is not the same as
  : NULL).
  :   
Put back some extra leading spaces to keep the indentation the same as it was 
originally.


http://gerrit.cloudera.org:8080/#/c/9275/4/docs/topics/impala_string_functions.xml@1126
PS4, Line 1126: 
This whole paragraph lost several spaces of indentation. Please keep the same 
indentation as in the original.


http://gerrit.cloudera.org:8080/#/c/9275/4/docs/topics/impala_string_functions.xml@1128
PS4, Line 1128: 

[Impala-ASF-CR] IMPALA-6499: [DOCS] Fixed formatting errors in split part function

[Alex Rodoni (Code Review)]

Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9275 )

Change subject: IMPALA-6499: [DOCS] Fixed formatting errors in split_part 
function
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9275/3/docs/topics/impala_string_functions.xml
File docs/topics/impala_string_functions.xml:

http://gerrit.cloudera.org:8080/#/c/9275/3/docs/topics/impala_string_functions.xml@1129
PS3, Line 1129: 

[Impala-ASF-CR] IMPALA-6499: [DOCS] Fixed formatting errors in split part function

[Alex Rodoni (Code Review)]

Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9275 )

Change subject: IMPALA-6499: [DOCS] Fixed formatting errors in split_part 
function
..


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/9275/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9275/3//COMMIT_MSG@7
PS3, Line 7: docs
> Uppercase "DOCS"
Done


http://gerrit.cloudera.org:8080/#/c/9275/3/docs/topics/impala_string_functions.xml
File docs/topics/impala_string_functions.xml:

http://gerrit.cloudera.org:8080/#/c/9275/3/docs/topics/impala_string_functions.xml@1067
PS3, Line 1067: 
  : Return type:
> This looks like the whole paragraph was reformatted by accident. The  li
Done


http://gerrit.cloudera.org:8080/#/c/9275/3/docs/topics/impala_string_functions.xml@1075
PS3, Line 1075:
> Remove trailing space.
Done



--
To view, visit http://gerrit.cloudera.org:8080/9275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7623e32aaf31f21a3be4513f26deb0b789a56b1a
Gerrit-Change-Number: 9275
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 20 Feb 2018 20:03:22 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6499: [DOCS] Fixed formatting errors in split part function

[Alex Rodoni (Code Review)]

Hello John Russell, Tim Armstrong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9275

to look at the new patch set (#4).

Change subject: IMPALA-6499: [DOCS] Fixed formatting errors in split_part 
function
..

IMPALA-6499: [DOCS] Fixed formatting errors in split_part function

Change-Id: I7623e32aaf31f21a3be4513f26deb0b789a56b1a
---
M docs/topics/impala_string_functions.xml
1 file changed, 20 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/9275/4
--
To view, visit http://gerrit.cloudera.org:8080/9275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7623e32aaf31f21a3be4513f26deb0b789a56b1a
Gerrit-Change-Number: 9275
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-6499: [docs] Fixed formatting errors in split part function

[John Russell (Code Review)]

John Russell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9275 )

Change subject: IMPALA-6499: [docs] Fixed formatting errors in split_part 
function
..


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/9275/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9275/3//COMMIT_MSG@7
PS3, Line 7: docs
Uppercase "DOCS"


http://gerrit.cloudera.org:8080/#/c/9275/3/docs/topics/impala_string_functions.xml
File docs/topics/impala_string_functions.xml:

http://gerrit.cloudera.org:8080/#/c/9275/3/docs/topics/impala_string_functions.xml@1067
PS3, Line 1067: 
  : Return type:
This looks like the whole paragraph was reformatted by accident. The  line 
shouldn't be wrapped at the end of another line containing text. Was there any 
change to the actual text in this paragraph?


http://gerrit.cloudera.org:8080/#/c/9275/3/docs/topics/impala_string_functions.xml@1075
PS3, Line 1075:
Remove trailing space.


http://gerrit.cloudera.org:8080/#/c/9275/3/docs/topics/impala_string_functions.xml@1129
PS3, Line 1129: 

[Impala-ASF-CR] IMPALA-6499: [docs] Fixed formatting errors in split part function

[Alex Rodoni (Code Review)]

Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9275


Change subject: IMPALA-6499: [docs] Fixed formatting errors in split_part 
function
..

IMPALA-6499: [docs] Fixed formatting errors in split_part function

Change-Id: I7623e32aaf31f21a3be4513f26deb0b789a56b1a
---
M docs/topics/impala_string_functions.xml
1 file changed, 24 insertions(+), 24 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/9275/3
--
To view, visit http://gerrit.cloudera.org:8080/9275
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7623e32aaf31f21a3be4513f26deb0b789a56b1a
Gerrit-Change-Number: 9275
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: John Russell 
Gerrit-Reviewer: Tim Armstrong