[Impala-ASF-CR] IMPALA-6567: ResetMetadataStmt analysis should not load tables.

2018-02-23 Thread Alex Behm (Code Review) 
Alex Behm has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9418 )

Change subject: IMPALA-6567: ResetMetadataStmt analysis should not load tables.
..

IMPALA-6567: ResetMetadataStmt analysis should not load tables.

This fixes a regression introduced by IMPALA-5152 where
invalidate metadata  and refresh  accidentally
required the target table to be loaded during analysis,
ultimately leading to a double load in some situations
(load during analysis, then another load during execution).
Since the purpose of these statements is to reload
metadata it does not make sense to require a table load
during analysis - that load happens during execution.

Note that REFRESH  PARTITION () still
requires the containing table to be loaded. This was
the behavior before IMPALA-5152 and this patch does
not attempt to improve that.

Testing:
- added new unit test
- ran FE tests locally
- validated the desired behavior by inspecting logs
  and the timeine from invalidate/refresh statements

Change-Id: I7033781ebf27ea53cfd26ff0e4f74d4f242bd1dc
Reviewed-on: http://gerrit.cloudera.org:8080/9418
Tested-by: Impala Public Jenkins
Reviewed-by: Alex Behm 
---
M fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java
M fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java
2 files changed, 24 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Alex Behm: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/9418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7033781ebf27ea53cfd26ff0e4f74d4f242bd1dc
Gerrit-Change-Number: 9418
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins

[Impala-ASF-CR] IMPALA-6567: ResetMetadataStmt analysis should not load tables.

2018-02-23 Thread Alex Behm (Code Review) 
Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9418 )

Change subject: IMPALA-6567: ResetMetadataStmt analysis should not load tables.
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7033781ebf27ea53cfd26ff0e4f74d4f242bd1dc
Gerrit-Change-Number: 9418
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Fri, 23 Feb 2018 21:16:25 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6567: ResetMetadataStmt analysis should not load tables.

2018-02-23 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9418 )

Change subject: IMPALA-6567: ResetMetadataStmt analysis should not load tables.
..


Patch Set 3: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7033781ebf27ea53cfd26ff0e4f74d4f242bd1dc
Gerrit-Change-Number: 9418
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Fri, 23 Feb 2018 21:07:53 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6567: ResetMetadataStmt analysis should not load tables.

2018-02-23 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9418 )

Change subject: IMPALA-6567: ResetMetadataStmt analysis should not load tables.
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2000/


--
To view, visit http://gerrit.cloudera.org:8080/9418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7033781ebf27ea53cfd26ff0e4f74d4f242bd1dc
Gerrit-Change-Number: 9418
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Fri, 23 Feb 2018 17:23:39 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6567: ResetMetadataStmt analysis should not load tables.

2018-02-23 Thread Alex Behm (Code Review) 
Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9418 )

Change subject: IMPALA-6567: ResetMetadataStmt analysis should not load tables.
..


Patch Set 2:

(1 comment)

Thanks for the review. Going to merge this since it badly affects data loading 
time.

http://gerrit.cloudera.org:8080/#/c/9418/2/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java
File fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java:

http://gerrit.cloudera.org:8080/#/c/9418/2/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java@189
PS2, Line 189: testResetMetadataStmts
> Just curious, whats the naming convention for frontend unit test names? We
We're inconsistent about this. In a recent dev@ thread most people expressed a 
preference for the standard camel-case naming so for new tests I'm going to try 
and use that (i.e. start with lower case)



--
To view, visit http://gerrit.cloudera.org:8080/9418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7033781ebf27ea53cfd26ff0e4f74d4f242bd1dc
Gerrit-Change-Number: 9418
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Comment-Date: Fri, 23 Feb 2018 17:08:40 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6567: ResetMetadataStmt analysis should not load tables.

2018-02-23 Thread Bharath Vissapragada (Code Review) 
Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9418 )

Change subject: IMPALA-6567: ResetMetadataStmt analysis should not load tables.
..


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9418/2/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java
File fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java:

http://gerrit.cloudera.org:8080/#/c/9418/2/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java@189
PS2, Line 189: testResetMetadataStmts
Just curious, whats the naming convention for frontend unit test names? We seem 
to be using names starting with capitals in multiple other places.

grep -rn "@Test" -A 1 fe/src/test



--
To view, visit http://gerrit.cloudera.org:8080/9418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7033781ebf27ea53cfd26ff0e4f74d4f242bd1dc
Gerrit-Change-Number: 9418
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Behm 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Comment-Date: Fri, 23 Feb 2018 14:55:54 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6567: ResetMetadataStmt analysis should not load tables.

2018-02-22 Thread Alex Behm (Code Review) 
Alex Behm has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/9418 )

Change subject: IMPALA-6567: ResetMetadataStmt analysis should not load tables.
..

IMPALA-6567: ResetMetadataStmt analysis should not load tables.

This fixes a regression introduced by IMPALA-5152 where
invalidate metadata  and refresh  accidentally
required the target table to be loaded during analysis,
ultimately leading to a double load in some situations
(load during analysis, then another load during execution).
Since the purpose of these statements is to reload
metadata it does not make sense to require a table load
during analysis - that load happens during execution.

Note that REFRESH  PARTITION () still
requires the containing table to be loaded. This was
the behavior before IMPALA-5152 and this patch does
not attempt to improve that.

Testing:
- added new unit test
- ran FE tests locally
- validated the desired behavior by inspecting logs
  and the timeine from invalidate/refresh statements

Change-Id: I7033781ebf27ea53cfd26ff0e4f74d4f242bd1dc
---
M fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java
M fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java
2 files changed, 24 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/9418/2
--
To view, visit http://gerrit.cloudera.org:8080/9418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7033781ebf27ea53cfd26ff0e4f74d4f242bd1dc
Gerrit-Change-Number: 9418
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Behm

[Impala-ASF-CR] IMPALA-6567: ResetMetadataStmt analysis should not load tables.

2018-02-22 Thread Alex Behm (Code Review) 
Alex Behm has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9418


Change subject: IMPALA-6567: ResetMetadataStmt analysis should not load tables.
..

IMPALA-6567: ResetMetadataStmt analysis should not load tables.

This fixes a regression introduced by IMPALA-5152 where
invaidate metadata  and refresh  accidentally
required the target table to be loaded during analysis,
ultimately leading to a double load in some situations
(load during analysis, then another load during execution).
Since the purpose of these statements is to reload
metadata it does not make sense to require a table load
during analysis - that load happens during execution.

Note that REFRESH  PARTITION () still
requires the containing table to be loaded. This was
the behavior before IMPALA-5152 and this patch does
not attempt to improve that.

Testing:
- added new unit test
- ran FE tests locally
- validated the desired behavior by inspecting logs
  and the timeine from invalidate/refresh statements

Change-Id: I7033781ebf27ea53cfd26ff0e4f74d4f242bd1dc
---
M fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java
M fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java
2 files changed, 24 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/9418/1
--
To view, visit http://gerrit.cloudera.org:8080/9418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7033781ebf27ea53cfd26ff0e4f74d4f242bd1dc
Gerrit-Change-Number: 9418
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm