[Impala-ASF-CR] IMPALA-6655: Add owner information on database creation

2018-03-16 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9637 )

Change subject: IMPALA-6655: Add owner information on database creation
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id74ec9bd3cb7954999305e9cd9085cbf50921a78
Gerrit-Change-Number: 9637
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Fri, 16 Mar 2018 19:28:36 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6655: Add owner information on database creation

2018-03-16 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9637 )

Change subject: IMPALA-6655: Add owner information on database creation
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2120/


--
To view, visit http://gerrit.cloudera.org:8080/9637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id74ec9bd3cb7954999305e9cd9085cbf50921a78
Gerrit-Change-Number: 9637
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Fri, 16 Mar 2018 15:36:49 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6655: Add owner information on database creation

2018-03-16 Thread Alex Behm (Code Review) 
Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9637 )

Change subject: IMPALA-6655: Add owner information on database creation
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id74ec9bd3cb7954999305e9cd9085cbf50921a78
Gerrit-Change-Number: 9637
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Comment-Date: Fri, 16 Mar 2018 15:36:15 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6655: Add owner information on database creation

2018-03-16 Thread Fredy Wijaya (Code Review) 
Fredy Wijaya has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/9637 )

Change subject: IMPALA-6655: Add owner information on database creation
..

IMPALA-6655: Add owner information on database creation

Add owner information on database creation.

> create database foo;
> describe database extended foo;
+-+--+-+
| name| location | comment |
+-+--+-+
| foo |  | |
| Owner:  |  | |
| | user1| USER|
+-+--+-+

Testing:
- Ran end-to-end query and metadata tests

Change-Id: Id74ec9bd3cb7954999305e9cd9085cbf50921a78
---
M common/thrift/JniCatalog.thrift
M fe/src/main/java/org/apache/impala/analysis/CreateDbStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M testdata/workloads/functional-query/queries/QueryTest/describe-db.test
M tests/common/impala_test_suite.py
5 files changed, 29 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/9637/2
--
To view, visit http://gerrit.cloudera.org:8080/9637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id74ec9bd3cb7954999305e9cd9085cbf50921a78
Gerrit-Change-Number: 9637
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya

[Impala-ASF-CR] IMPALA-6655: Add owner information on database creation

2018-03-15 Thread Alex Behm (Code Review) 
Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9637 )

Change subject: IMPALA-6655: Add owner information on database creation
..


Patch Set 1:

(2 comments)

Looks good to me as well, will merge after the final touches

http://gerrit.cloudera.org:8080/#/c/9637/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9637/1//COMMIT_MSG@13
PS1, Line 13: +-+--+-+
Not really related to your change, but our describe database looks a little 
strange. It's also quite different from Hive's output which looks nicer imo.

Let's not make any changes to the output in this patch. But can you file a JIRA 
to reconsider our output?


http://gerrit.cloudera.org:8080/#/c/9637/1/fe/src/main/java/org/apache/impala/analysis/CreateDbStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateDbStmt.java:

http://gerrit.cloudera.org:8080/#/c/9637/1/fe/src/main/java/org/apache/impala/analysis/CreateDbStmt.java@111
PS1, Line 111: Preconditions.checkNotNull(owner_);
condense into a single line:

public String getOwner() { return Preconditions.checkNotNull(owner_); }



--
To view, visit http://gerrit.cloudera.org:8080/9637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id74ec9bd3cb7954999305e9cd9085cbf50921a78
Gerrit-Change-Number: 9637
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Comment-Date: Fri, 16 Mar 2018 05:40:55 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6655: Add owner information on database creation

2018-03-15 Thread Adam Holley (Code Review) 
Adam Holley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9637 )

Change subject: IMPALA-6655: Add owner information on database creation
..


Patch Set 1: Code-Review+1

Don't see any issues, just make sure to pick up latest describe changes to 
check against.


--
To view, visit http://gerrit.cloudera.org:8080/9637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id74ec9bd3cb7954999305e9cd9085cbf50921a78
Gerrit-Change-Number: 9637
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Fredy Wijaya 
Gerrit-Comment-Date: Fri, 16 Mar 2018 01:32:03 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6655: Add owner information on database creation

2018-03-14 Thread Fredy Wijaya (Code Review) 
Fredy Wijaya has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9637


Change subject: IMPALA-6655: Add owner information on database creation
..

IMPALA-6655: Add owner information on database creation

Add owner information on database creation.

> create database foo;
> describe database extended foo;
+-+--+-+
| name| location | comment |
+-+--+-+
| foo |  | |
| Owner:  |  | |
| | user1| USER|
+-+--+-+

Testing:
- Ran end-to-end query and metadata tests

Change-Id: Id74ec9bd3cb7954999305e9cd9085cbf50921a78
---
M common/thrift/JniCatalog.thrift
M fe/src/main/java/org/apache/impala/analysis/CreateDbStmt.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M testdata/workloads/functional-query/queries/QueryTest/describe-db.test
M tests/common/impala_test_suite.py
5 files changed, 32 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/9637/1
--
To view, visit http://gerrit.cloudera.org:8080/9637
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id74ec9bd3cb7954999305e9cd9085cbf50921a78
Gerrit-Change-Number: 9637
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya 
Gerrit-Reviewer: Adam Holley 
Gerrit-Reviewer: Fredy Wijaya