[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..

IMPALA-6723: [DOCS] Hints for CTAS

Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa

IMPALA-6723 Hints for CTAS

Change-Id: I201a4e1ddaf62164e1f6b636c4e1e60af60e1af7

IMPALA-6723: [DOCS] Hints for CTAS

Optimizer hints were move out of SELECT section.
Hints for CTAS were added to the same section as INSERT.

Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Reviewed-on: http://gerrit.cloudera.org:8080/9993
Reviewed-by: Alex Rodoni 
Tested-by: Impala Public Jenkins 
---
M docs/impala.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_hints.xml
3 files changed, 181 insertions(+), 48 deletions(-)

Approvals:
  Alex Rodoni: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 11
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 10: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 10
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Tue, 17 Apr 2018 00:34:51 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 10:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/244/


--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 10
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Tue, 17 Apr 2018 00:24:20 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-16 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 10: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 10
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Tue, 17 Apr 2018 00:24:00 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-16 Thread Alex Rodoni (Code Review)
Hello Thomas Tauber-Marshall, Lars Volker, Csaba Ringhofer, Impala Public 
Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9993

to look at the new patch set (#10).

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..

IMPALA-6723: [DOCS] Hints for CTAS

Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa

IMPALA-6723 Hints for CTAS

Change-Id: I201a4e1ddaf62164e1f6b636c4e1e60af60e1af7

IMPALA-6723: [DOCS] Hints for CTAS

Optimizer hints were move out of SELECT section.
Hints for CTAS were added to the same section as INSERT.

Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
---
M docs/impala.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_hints.xml
3 files changed, 181 insertions(+), 48 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/9993/10
--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 10
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-16 Thread Alex Rodoni (Code Review)
Hello Thomas Tauber-Marshall, Lars Volker, Csaba Ringhofer, Impala Public 
Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9993

to look at the new patch set (#9).

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..

IMPALA-6723: [DOCS] Hints for CTAS

Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa

IMPALA-6723 Hints for CTAS

Change-Id: I201a4e1ddaf62164e1f6b636c4e1e60af60e1af7

IMPALA-6723: [DOCS] Hints for CTAS

Optimizer hints were move out of SELECT section.
Hints for CTAS were added to the same section as INSERT.

Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
---
M docs/impala.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_hints.xml
3 files changed, 179 insertions(+), 48 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/9993/9
--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 9
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 8: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 8
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Mon, 16 Apr 2018 19:00:58 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 8:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/241/


--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 8
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Mon, 16 Apr 2018 18:53:10 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-16 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 8: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 8
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Mon, 16 Apr 2018 18:52:00 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-16 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9993/7/docs/topics/impala_hints.xml
File docs/topics/impala_hints.xml:

http://gerrit.cloudera.org:8080/#/c/9993/7/docs/topics/impala_hints.xml@264
PS7, Line 264: smaller
> It results in fewer files.
Done



--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 7
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Mon, 16 Apr 2018 18:49:39 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-16 Thread Alex Rodoni (Code Review)
Hello Thomas Tauber-Marshall, Lars Volker, Csaba Ringhofer, Impala Public 
Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9993

to look at the new patch set (#8).

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..

IMPALA-6723: [DOCS] Hints for CTAS

Optimizer hints were move out of SELECT section.
Hints for CTAS were added to the same section as INSERT.

Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
---
M docs/impala.ditamap
M docs/topics/impala_hints.xml
2 files changed, 119 insertions(+), 108 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/9993/8
--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 8
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-16 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9993/7/docs/topics/impala_hints.xml
File docs/topics/impala_hints.xml:

http://gerrit.cloudera.org:8080/#/c/9993/7/docs/topics/impala_hints.xml@264
PS7, Line 264: smaller
It results in fewer files.



--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 7
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Mon, 16 Apr 2018 18:44:34 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-16 Thread Alex Rodoni (Code Review)
Hello Thomas Tauber-Marshall, Lars Volker, Csaba Ringhofer, Impala Public 
Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9993

to look at the new patch set (#7).

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..

IMPALA-6723: [DOCS] Hints for CTAS

Optimizer hints were move out of SELECT section.
Hints for CTAS were added to the same section as INSERT.

Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
---
M docs/impala.ditamap
M docs/topics/impala_hints.xml
2 files changed, 119 insertions(+), 108 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/9993/7
--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 7
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-16 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 6:

I don't see a new Patch Set. Did you forget to push it?


--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Mon, 16 Apr 2018 16:47:14 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-14 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 6:

Does anyone have any more comments? Or can someone +2 this?


--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Sat, 14 Apr 2018 17:10:07 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-13 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 6:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/9993/6/docs/topics/impala_hints.xml
File docs/topics/impala_hints.xml:

http://gerrit.cloudera.org:8080/#/c/9993/6/docs/topics/impala_hints.xml@258
PS6, Line 258: /* +SHUFFLE */ Adds an exchange 
node which
> mention that this node gets added before writing the data.
Done


http://gerrit.cloudera.org:8080/#/c/9993/6/docs/topics/impala_hints.xml@260
PS6, Line 260: on the partitioning columns of the target table. 
This makes a
> This also reduces fragmentation, resulting in smaller files.
Done


http://gerrit.cloudera.org:8080/#/c/9993/6/docs/topics/impala_hints.xml@268
PS6, Line 268: constructed
> s/written
Done


http://gerrit.cloudera.org:8080/#/c/9993/6/docs/topics/impala_hints.xml@273
PS6, Line 273: construct
> write
Done


http://gerrit.cloudera.org:8080/#/c/9993/6/docs/topics/impala_hints.xml@315
PS6, Line 315: each partition
 : column
> "... by the partitioning columns ..." (it's a compound key, not several con
Done


http://gerrit.cloudera.org:8080/#/c/9993/6/docs/topics/impala_hints.xml@318
PS6, Line 318: or
> s/and
Done


http://gerrit.cloudera.org:8080/#/c/9993/6/docs/topics/impala_hints.xml@348
PS6, Line 348: partitioning
> I don't think Kudu has partitions, but you should confirm with Thomas.
Thomas wrote this.



--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Fri, 13 Apr 2018 22:58:52 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 6:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/9993/6/docs/topics/impala_hints.xml
File docs/topics/impala_hints.xml:

http://gerrit.cloudera.org:8080/#/c/9993/6/docs/topics/impala_hints.xml@258
PS6, Line 258: /* +SHUFFLE */ Adds an exchange 
node which
mention that this node gets added before writing the data.


http://gerrit.cloudera.org:8080/#/c/9993/6/docs/topics/impala_hints.xml@260
PS6, Line 260: on the partitioning columns of the target table. 
This makes a
This also reduces fragmentation, resulting in smaller files.

Can we simplify this sentence? "makes... to be written" reads a bit odd.


http://gerrit.cloudera.org:8080/#/c/9993/6/docs/topics/impala_hints.xml@268
PS6, Line 268: constructed
s/written


http://gerrit.cloudera.org:8080/#/c/9993/6/docs/topics/impala_hints.xml@273
PS6, Line 273: construct
write


http://gerrit.cloudera.org:8080/#/c/9993/6/docs/topics/impala_hints.xml@315
PS6, Line 315: each partition
 : column
"... by the partitioning columns ..." (it's a compound key, not several 
consecutive sorts)


http://gerrit.cloudera.org:8080/#/c/9993/6/docs/topics/impala_hints.xml@318
PS6, Line 318: or
s/and


http://gerrit.cloudera.org:8080/#/c/9993/6/docs/topics/impala_hints.xml@348
PS6, Line 348: partitioning
I don't think Kudu has partitions, but you should confirm with Thomas.



--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Fri, 13 Apr 2018 16:40:35 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 6: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Thu, 12 Apr 2018 22:17:38 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-12 Thread Alex Rodoni (Code Review)
Hello Thomas Tauber-Marshall, Lars Volker, Csaba Ringhofer, Impala Public 
Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9993

to look at the new patch set (#6).

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..

IMPALA-6723: [DOCS] Hints for CTAS

Optimizer hints were move out of SELECT section.
Hints for CTAS were added to the same section as INSERT.

Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
---
M docs/impala.ditamap
M docs/topics/impala_hints.xml
2 files changed, 110 insertions(+), 108 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/9993/6
--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-12 Thread Alex Rodoni (Code Review)
Hello Thomas Tauber-Marshall, Lars Volker, Csaba Ringhofer, Impala Public 
Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9993

to look at the new patch set (#5).

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..

IMPALA-6723: [DOCS] Hints for CTAS

Optimizer hints were move out of SELECT section.
Hints for CTAS were added to the same section as INSERT.

Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
---
M docs/impala.ditamap
M docs/topics/impala_hints.xml
2 files changed, 114 insertions(+), 108 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/9993/5
--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 4:

Alex, it looks like if the new change was applied to patch set 2, not patch set 
3, so the changes in patch set 3 are missing.


--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Thu, 12 Apr 2018 21:14:15 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-12 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9993/3/docs/topics/impala_hints.xml
File docs/topics/impala_hints.xml:

http://gerrit.cloudera.org:8080/#/c/9993/3/docs/topics/impala_hints.xml@317
PS3, Line 317: at a time
> Adding "per node" would make the intention clearer. No other complaints on
Done



--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:41:29 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-12 Thread Alex Rodoni (Code Review)
Hello Thomas Tauber-Marshall, Lars Volker, Csaba Ringhofer, Impala Public 
Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9993

to look at the new patch set (#4).

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..

IMPALA-6723: [DOCS] Hints for CTAS

Optimizer hints were move out of SELECT section.
Hints for CTAS were added to the same section as INSERT.

Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
---
M docs/impala.ditamap
M docs/topics/impala_hints.xml
2 files changed, 100 insertions(+), 109 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/9993/4
--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9993/3/docs/topics/impala_hints.xml
File docs/topics/impala_hints.xml:

http://gerrit.cloudera.org:8080/#/c/9993/3/docs/topics/impala_hints.xml@317
PS3, Line 317: at a time
Adding "per node" would make the intention clearer. No other complaints on my 
side.



--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Thu, 12 Apr 2018 20:22:19 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-12 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9993/2/docs/topics/impala_hints.xml
File docs/topics/impala_hints.xml:

http://gerrit.cloudera.org:8080/#/c/9993/2/docs/topics/impala_hints.xml@328
PS2, Line 328:  Starting in , this is the
 :   default behavior for HDFS tables. 
> Actually the opposite is true: until 3.0, NOCLUSTERED was the default in HD
Done



--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Thu, 12 Apr 2018 17:34:08 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-12 Thread Alex Rodoni (Code Review)
Hello Thomas Tauber-Marshall, Lars Volker, Csaba Ringhofer, Impala Public 
Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9993

to look at the new patch set (#3).

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..

IMPALA-6723: [DOCS] Hints for CTAS

Optimizer hints were move out of SELECT section.
Hints for CTAS were added to the same section as INSERT.

Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
---
M docs/topics/impala_hints.xml
1 file changed, 114 insertions(+), 108 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/9993/3
--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9993/2/docs/topics/impala_hints.xml
File docs/topics/impala_hints.xml:

http://gerrit.cloudera.org:8080/#/c/9993/2/docs/topics/impala_hints.xml@328
PS2, Line 328:  Starting in , this is the
 :   default behavior for HDFS tables. 
Actually the opposite is true: until 3.0, NOCLUSTERED was the default in HDFS 
tables, and since 3.0 CLUSTERED became the default.



--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Thu, 12 Apr 2018 17:12:14 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-11 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 2:

> What is the relation between this change and the abandoned one that
 > has Csaba's comments?

My error. I uploaded from a wrong branch. I reapplied all the changes, and this 
is the healthy package.


--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Wed, 11 Apr 2018 20:19:09 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9993 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 2:

What is the relation between this change and the abandoned one that has Csaba's 
comments?


--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Wed, 11 Apr 2018 19:39:41 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-11 Thread Alex Rodoni (Code Review)
Hello Thomas Tauber-Marshall, Lars Volker, Csaba Ringhofer, Impala Public 
Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9993

to look at the new patch set (#2).

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..

IMPALA-6723: [DOCS] Hints for CTAS

Optimizer hints were move out of SELECT section.
Hints for CTAS were added to the same section as INSERT.

Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
---
M docs/impala.ditamap
M docs/topics/impala_hints.xml
2 files changed, 100 insertions(+), 109 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/9993/2
--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-11 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9993


Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..

IMPALA-6723: [DOCS] Hints for CTAS

Optimizer hints were move out of SELECT section.
Hints for CTAS were added to the same section as INSERT.

Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
---
M docs/topics/impala_hints.xml
1 file changed, 100 insertions(+), 108 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/9993/1
--
To view, visit http://gerrit.cloudera.org:8080/9993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I91d9f4f039a603382ff4415d1dd22a351279cbfa
Gerrit-Change-Number: 9993
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9980 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/9980/2/docs/topics/impala_hints.xml
File docs/topics/impala_hints.xml:

http://gerrit.cloudera.org:8080/#/c/9980/2/docs/topics/impala_hints.xml@59
PS2, Line 59: Inserting into partitioned Parquet tables, where many 
memory buffers could be allocated on each host to
: hold intermediate results for each partition.
:   
:   
: Creating a table based on column definitions from another 
table and
: copying data from the source table,
These two use cases are practically the same, as CTAS is practically a CREATE + 
an INSERT...SELECT, so I would try to merge these into one paragraph, or remove 
the CTAS version from this example section.


http://gerrit.cloudera.org:8080/#/c/9980/2/docs/topics/impala_hints.xml@287
PS2, Line 287: does not add exchange node before
 : inserting to partitioned tables and disables 
re-partitioning.
I think that it would be clearer if this was explained in the SHUFFLE 
paragraph, like "SHUFFLE adds an exchange node which re-partitions the result 
of the SELECT based on the partitioning columns of the target table. This makes 
a partition to be written only by a single node, ..."


http://gerrit.cloudera.org:8080/#/c/9980/2/docs/topics/impala_hints.xml@319
PS2, Line 319: partition
I think that "by each partitioning column" would be clearer.


http://gerrit.cloudera.org:8080/#/c/9980/2/docs/topics/impala_hints.xml@328
PS2, Line 328: /* +NOCLUSTERED */ does not sort by 
primary key
 : before insert. Use this hint when inserting to Kudu 
tables. This
 : hint has no effect on HDFS tables currently as this 
is the default
 : behavior. This hint is available in  or higher. 
Since IMPALA-5293 (Impala 3.x only) the default is CLUSTERED behavior for HDFS 
tables, so NOCLUSTERED will have effect on them.



--
To view, visit http://gerrit.cloudera.org:8080/9980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I01057d59127d6193bdb69a2a181a386a039e08f5
Gerrit-Change-Number: 9980
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Thomas Tauber-Marshall 
Gerrit-Comment-Date: Wed, 11 Apr 2018 14:42:51 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-10 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/9980 )

Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..

IMPALA-6723: [DOCS] Hints for CTAS

- Moved the Hints doc out of the SELECT section.
- Added CTAS hints to the same section as INSERT.

Change-Id: I01057d59127d6193bdb69a2a181a386a039e08f5
---
M docs/impala.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_hints.xml
3 files changed, 158 insertions(+), 43 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/9980/2
--
To view, visit http://gerrit.cloudera.org:8080/9980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I01057d59127d6193bdb69a2a181a386a039e08f5
Gerrit-Change-Number: 9980
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 


[Impala-ASF-CR] IMPALA-6723: [DOCS] Hints for CTAS

2018-04-10 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9980


Change subject: IMPALA-6723: [DOCS] Hints for CTAS
..

IMPALA-6723: [DOCS] Hints for CTAS

- Moved the Hints doc out of the SELECT section.
- Added CTAS hints to the same section as INSERT.

Change-Id: I01057d59127d6193bdb69a2a181a386a039e08f5
---
M docs/impala.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_hints.xml
3 files changed, 154 insertions(+), 47 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/9980/1
--
To view, visit http://gerrit.cloudera.org:8080/9980
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I01057d59127d6193bdb69a2a181a386a039e08f5
Gerrit-Change-Number: 9980
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni