[Impala-ASF-CR] IMPALA-8273 : Change metastore config template to not exclude impala specific parameters
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12646 ) Change subject: IMPALA-8273 : Change metastore config template to not exclude impala specific parameters .. IMPALA-8273 : Change metastore config template to not exclude impala specific parameters When HMS configuration key "hive.metastore.notification.parameters.exclude.patterns" is set to "^impala" it excludes all the parameter key/values from the table and partition which start with "impala". This can cause problems for event processing since it relies on these property keys (for instance, impala.disableHmsSync). Testing done: Confirmed existing test pass. Ran jenkins job which runs all the fe tests where the events disable flag tests were failing from MetastoreEventsProcessingTest class. Job currently running. Will update the message once the result comes back. Change-Id: Ic367b1d06459295c7721cdb20ac7faed9a2aa4c9 Reviewed-on: http://gerrit.cloudera.org:8080/12646 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java M fe/src/test/resources/postgresql-hive-site.xml.template 3 files changed, 19 insertions(+), 4 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/12646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic367b1d06459295c7721cdb20ac7faed9a2aa4c9 Gerrit-Change-Number: 12646 Gerrit-PatchSet: 6 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-8273 : Change metastore config template to not exclude impala specific parameters
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12646 ) Change subject: IMPALA-8273 : Change metastore config template to not exclude impala specific parameters .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/12646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic367b1d06459295c7721cdb20ac7faed9a2aa4c9 Gerrit-Change-Number: 12646 Gerrit-PatchSet: 5 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 05 Mar 2019 22:31:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8273 : Change metastore config template to not exclude impala specific parameters
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12646 ) Change subject: IMPALA-8273 : Change metastore config template to not exclude impala specific parameters .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3875/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/12646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic367b1d06459295c7721cdb20ac7faed9a2aa4c9 Gerrit-Change-Number: 12646 Gerrit-PatchSet: 5 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 05 Mar 2019 18:23:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8273 : Change metastore config template to not exclude impala specific parameters
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12646 ) Change subject: IMPALA-8273 : Change metastore config template to not exclude impala specific parameters .. Patch Set 2: > Let me know when you think this is ready for merge and I can > kickoff a GVO. Thanks Bharath. Patch is good to go. Please kickoff a GVO when possible. -- To view, visit http://gerrit.cloudera.org:8080/12646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic367b1d06459295c7721cdb20ac7faed9a2aa4c9 Gerrit-Change-Number: 12646 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 05 Mar 2019 17:51:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8273 : Change metastore config template to not exclude impala specific parameters
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12646 ) Change subject: IMPALA-8273 : Change metastore config template to not exclude impala specific parameters .. Patch Set 4: Code-Review+2 Let me know when you think this is ready for merge and I can kickoff a GVO. -- To view, visit http://gerrit.cloudera.org:8080/12646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic367b1d06459295c7721cdb20ac7faed9a2aa4c9 Gerrit-Change-Number: 12646 Gerrit-PatchSet: 4 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Tue, 05 Mar 2019 06:04:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8273 : Change metastore config template to not exclude impala specific parameters
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12646 ) Change subject: IMPALA-8273 : Change metastore config template to not exclude impala specific parameters .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/2336/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/12646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic367b1d06459295c7721cdb20ac7faed9a2aa4c9 Gerrit-Change-Number: 12646 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Mon, 04 Mar 2019 18:42:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8273 : Change metastore config template to not exclude impala specific parameters
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12646 ) Change subject: IMPALA-8273 : Change metastore config template to not exclude impala specific parameters .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12646/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12646/2//COMMIT_MSG@10 PS2, Line 10: When HMS configuration key > nit: trailing whitespaces (multiple places) Done -- To view, visit http://gerrit.cloudera.org:8080/12646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic367b1d06459295c7721cdb20ac7faed9a2aa4c9 Gerrit-Change-Number: 12646 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Mon, 04 Mar 2019 18:09:08 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8273 : Change metastore config template to not exclude impala specific parameters
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12646 to look at the new patch set (#4). Change subject: IMPALA-8273 : Change metastore config template to not exclude impala specific parameters .. IMPALA-8273 : Change metastore config template to not exclude impala specific parameters When HMS configuration key "hive.metastore.notification.parameters.exclude.patterns" is set to "^impala" it excludes all the parameter key/values from the table and partition which start with "impala". This can cause problems for event processing since it relies on these property keys (for instance, impala.disableHmsSync). Testing done: Confirmed existing test pass. Ran jenkins job which runs all the fe tests where the events disable flag tests were failing from MetastoreEventsProcessingTest class. Job currently running. Will update the message once the result comes back. Change-Id: Ic367b1d06459295c7721cdb20ac7faed9a2aa4c9 --- M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java M fe/src/test/resources/postgresql-hive-site.xml.template 3 files changed, 19 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/12646/4 -- To view, visit http://gerrit.cloudera.org:8080/12646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic367b1d06459295c7721cdb20ac7faed9a2aa4c9 Gerrit-Change-Number: 12646 Gerrit-PatchSet: 4 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-8273 : Change metastore config template to not exclude impala specific parameters
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12646 to look at the new patch set (#3). Change subject: IMPALA-8273 : Change metastore config template to not exclude impala specific parameters .. IMPALA-8273 : Change metastore config template to not exclude impala specific parameters When HMS configuration key "hive.metastore.notification.parameters.exclude.patterns" is set to "^impala" it excludes all the parameter key/values from the table and partition which start with "impala". This can cause problems for event processing since it relies on these property keys (for instance, impala.disableHmsSync). Testing done: Confirmed existing test pass. Ran jenkins job which runs all the fe tests where the events disable flag tests were failing from MetastoreEventsProcessingTest class. Job currently running. Will update the message once the result comes back. Change-Id: Ic367b1d06459295c7721cdb20ac7faed9a2aa4c9 --- M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java M fe/src/test/resources/postgresql-hive-site.xml.template 3 files changed, 19 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/12646/3 -- To view, visit http://gerrit.cloudera.org:8080/12646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic367b1d06459295c7721cdb20ac7faed9a2aa4c9 Gerrit-Change-Number: 12646 Gerrit-PatchSet: 3 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar
[Impala-ASF-CR] IMPALA-8273 : Change metastore config template to not exclude impala specific parameters
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12646 ) Change subject: IMPALA-8273 : Change metastore config template to not exclude impala specific parameters .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12646/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12646/1//COMMIT_MSG@17 PS1, Line 17: failing from MetastoreEventsProcessingTest class. Job currently running. > the failures are deterministic when you uprade the cdh components which inc Okay, I take that back .. I thought the cdh component number was different for master and cdh6.x branch. I will look into this more. -- To view, visit http://gerrit.cloudera.org:8080/12646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic367b1d06459295c7721cdb20ac7faed9a2aa4c9 Gerrit-Change-Number: 12646 Gerrit-PatchSet: 1 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Mon, 04 Mar 2019 18:07:26 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8273 : Change metastore config template to not exclude impala specific parameters
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12646 ) Change subject: IMPALA-8273 : Change metastore config template to not exclude impala specific parameters .. Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/12646/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12646/1//COMMIT_MSG@17 PS1, Line 17: Testing done: > the failures are deterministic when you uprade the cdh components which inc Ah ok, I missed the part that we hit this when upgrading the CDH bits. Makes sense, thanks., http://gerrit.cloudera.org:8080/#/c/12646/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12646/2//COMMIT_MSG@10 PS2, Line 10: When HMS configuration key nit: trailing whitespaces (multiple places) -- To view, visit http://gerrit.cloudera.org:8080/12646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic367b1d06459295c7721cdb20ac7faed9a2aa4c9 Gerrit-Change-Number: 12646 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vihang Karajgaonkar Gerrit-Comment-Date: Mon, 04 Mar 2019 18:03:29 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8273 : Change metastore config template to not exclude impala specific parameters
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12646 ) Change subject: IMPALA-8273 : Change metastore config template to not exclude impala specific parameters .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/12646/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12646/1//COMMIT_MSG@9 PS1, Line 9: > Line overflow. Done http://gerrit.cloudera.org:8080/#/c/12646/1//COMMIT_MSG@17 PS1, Line 17: Testing done: > Shouldn't the failures be deterministic if this config is missing? I'm curi the failures are deterministic when you uprade the cdh components which include the HMS config change. All the tests which depend on the flag impala.disableHmsSync in table/partition parameters are failing. http://gerrit.cloudera.org:8080/#/c/12646/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/12646/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@1017 PS1, Line 1017: assertEquals(numEventsReceivedBefore + 5, response.getEvents_received()); > Remove? Done http://gerrit.cloudera.org:8080/#/c/12646/1/fe/src/test/resources/postgresql-hive-site.xml.template File fe/src/test/resources/postgresql-hive-site.xml.template: http://gerrit.cloudera.org:8080/#/c/12646/1/fe/src/test/resources/postgresql-hive-site.xml.template@240 PS1, Line 240:
[Impala-ASF-CR] IMPALA-8273 : Change metastore config template to not exclude impala specific parameters
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12646 to look at the new patch set (#2). Change subject: IMPALA-8273 : Change metastore config template to not exclude impala specific parameters .. IMPALA-8273 : Change metastore config template to not exclude impala specific parameters When HMS configuration key "hive.metastore.notification.parameters.exclude.patterns" is set to "^impala" it excludes all the parameter key/values from the table and partition which start with "impala". This can cause problems for event processing since it relies on these property keys (for instance, impala.disableHmsSync). Testing done: Confirmed existing test pass. Ran jenkins job which runs all the fe tests where the events disable flag tests were failing from MetastoreEventsProcessingTest class. Job currently running. Will update the message once the result comes back. Change-Id: Ic367b1d06459295c7721cdb20ac7faed9a2aa4c9 --- M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java M fe/src/test/resources/postgresql-hive-site.xml.template 3 files changed, 19 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/12646/2 -- To view, visit http://gerrit.cloudera.org:8080/12646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic367b1d06459295c7721cdb20ac7faed9a2aa4c9 Gerrit-Change-Number: 12646 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins
