[Impala-ASF-CR] IMPALA-8681: Fix null pointer exception in ValidWriteIdLists generation
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13845 ) Change subject: IMPALA-8681: Fix null pointer exception in ValidWriteIdLists generation .. IMPALA-8681: Fix null pointer exception in ValidWriteIdLists generation iTbl.getMetaStoreTable() returned null for tables that failed to load, which led to several test failures in Hive 3 builds. Also changed the name of member loadedTbls_ to indicate that loading may have failed. Change-Id: Id9d1dcf9b7496c4a80e9af82cadad8682085d849 Reviewed-on: http://gerrit.cloudera.org:8080/13845 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java 1 file changed, 20 insertions(+), 17 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/13845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id9d1dcf9b7496c4a80e9af82cadad8682085d849 Gerrit-Change-Number: 13845 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yongzhi Chen Gerrit-Reviewer: Zoltan Borok-Nagy
[Impala-ASF-CR] IMPALA-8681: Fix null pointer exception in ValidWriteIdLists generation
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13845 ) Change subject: IMPALA-8681: Fix null pointer exception in ValidWriteIdLists generation .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/13845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9d1dcf9b7496c4a80e9af82cadad8682085d849 Gerrit-Change-Number: 13845 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yongzhi Chen Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Fri, 12 Jul 2019 01:12:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8681: Fix null pointer exception in ValidWriteIdLists generation
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13845 ) Change subject: IMPALA-8681: Fix null pointer exception in ValidWriteIdLists generation .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4595/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/13845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9d1dcf9b7496c4a80e9af82cadad8682085d849 Gerrit-Change-Number: 13845 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yongzhi Chen Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 11 Jul 2019 18:54:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8681: Fix null pointer exception in ValidWriteIdLists generation
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13845 ) Change subject: IMPALA-8681: Fix null pointer exception in ValidWriteIdLists generation .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9d1dcf9b7496c4a80e9af82cadad8682085d849 Gerrit-Change-Number: 13845 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yongzhi Chen Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 11 Jul 2019 18:54:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8681: Fix null pointer exception in ValidWriteIdLists generation
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13845 ) Change subject: IMPALA-8681: Fix null pointer exception in ValidWriteIdLists generation .. Patch Set 1: Code-Review+2 (1 comment) Carry +2 http://gerrit.cloudera.org:8080/#/c/13845/1/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java File fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/13845/1/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java@61 PS1, Line 61: loadedOrFailedTbls_ > nit: maybe requestedTbls_? I like the current name better even if it is long and ugly. :) -- To view, visit http://gerrit.cloudera.org:8080/13845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9d1dcf9b7496c4a80e9af82cadad8682085d849 Gerrit-Change-Number: 13845 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yongzhi Chen Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 11 Jul 2019 18:54:06 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8681: Fix null pointer exception in ValidWriteIdLists generation
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13845 ) Change subject: IMPALA-8681: Fix null pointer exception in ValidWriteIdLists generation .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/13845/1/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java File fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/13845/1/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java@61 PS1, Line 61: loadedOrFailedTbls_ nit: maybe requestedTbls_? -- To view, visit http://gerrit.cloudera.org:8080/13845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9d1dcf9b7496c4a80e9af82cadad8682085d849 Gerrit-Change-Number: 13845 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yongzhi Chen Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 11 Jul 2019 18:05:39 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8681: Fix null pointer exception in ValidWriteIdLists generation
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13845 ) Change subject: IMPALA-8681: Fix null pointer exception in ValidWriteIdLists generation .. Patch Set 1: Code-Review+1 The change looks good. -- To view, visit http://gerrit.cloudera.org:8080/13845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9d1dcf9b7496c4a80e9af82cadad8682085d849 Gerrit-Change-Number: 13845 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yongzhi Chen Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 11 Jul 2019 16:42:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8681: Fix null pointer exception in ValidWriteIdLists generation
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13845 ) Change subject: IMPALA-8681: Fix null pointer exception in ValidWriteIdLists generation .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/3864/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/13845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9d1dcf9b7496c4a80e9af82cadad8682085d849 Gerrit-Change-Number: 13845 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Yongzhi Chen Gerrit-Reviewer: Zoltan Borok-Nagy Gerrit-Comment-Date: Thu, 11 Jul 2019 15:42:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8681: Fix null pointer exception in ValidWriteIdLists generation
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13845 Change subject: IMPALA-8681: Fix null pointer exception in ValidWriteIdLists generation .. IMPALA-8681: Fix null pointer exception in ValidWriteIdLists generation iTbl.getMetaStoreTable() returned null for tables that failed to load, which led to several test failures in Hive 3 builds. Also changed the name of member loadedTbls_ to indicate that loading may have failed. Change-Id: Id9d1dcf9b7496c4a80e9af82cadad8682085d849 --- M fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java 1 file changed, 20 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/13845/1 -- To view, visit http://gerrit.cloudera.org:8080/13845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id9d1dcf9b7496c4a80e9af82cadad8682085d849 Gerrit-Change-Number: 13845 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer
