[Impala-ASF-CR] IMPALA-9851: Truncate long error message.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16300 ) Change subject: IMPALA-9851: Truncate long error message. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/16300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9fa4d024fb3dc9de03c7484f41b5e420a710e5a Gerrit-Change-Number: 16300 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 07 Aug 2020 01:00:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9851: Truncate long error message.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16300 ) Change subject: IMPALA-9851: Truncate long error message. .. IMPALA-9851: Truncate long error message. Error message length was unbounded and can grow very large into couple of MB in size. This patch truncate error message to maximum 128kb in size. This patch also fix potentially long error message related to BufferPool::Client::DebugString(). Before this patch, DebugString() will print all pages in 'pinned_pages_', 'dirty_unpinned_pages_', and 'in_flight_write_pages_' PageList. With this patch, DebugString() only include maximum of 100 first pages in each PageList. Testing: - Add be test BufferPoolTest.ShortDebugString - Add test within ErrorMsg.GenericFormatting to test for truncation. - Run and pass core tests. Change-Id: Ic9fa4d024fb3dc9de03c7484f41b5e420a710e5a Reviewed-on: http://gerrit.cloudera.org:8080/16300 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/runtime/bufferpool/buffer-pool-internal.h M be/src/runtime/bufferpool/buffer-pool-test.cc M be/src/runtime/bufferpool/buffer-pool.cc M be/src/runtime/bufferpool/buffer-pool.h M be/src/util/error-util-test.cc M be/src/util/error-util.cc M be/src/util/error-util.h M be/src/util/internal-queue.h 8 files changed, 163 insertions(+), 62 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/16300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic9fa4d024fb3dc9de03c7484f41b5e420a710e5a Gerrit-Change-Number: 16300 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-9851: Truncate long error message.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16300 ) Change subject: IMPALA-9851: Truncate long error message. .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6241/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/16300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9fa4d024fb3dc9de03c7484f41b5e420a710e5a Gerrit-Change-Number: 16300 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 06 Aug 2020 19:48:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9851: Truncate long error message.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16300 ) Change subject: IMPALA-9851: Truncate long error message. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9fa4d024fb3dc9de03c7484f41b5e420a710e5a Gerrit-Change-Number: 16300 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 06 Aug 2020 19:48:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9851: Truncate long error message.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16300 ) Change subject: IMPALA-9851: Truncate long error message. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9fa4d024fb3dc9de03c7484f41b5e420a710e5a Gerrit-Change-Number: 16300 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 06 Aug 2020 19:48:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9851: Truncate long error message.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16300 ) Change subject: IMPALA-9851: Truncate long error message. .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/6812/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9fa4d024fb3dc9de03c7484f41b5e420a710e5a Gerrit-Change-Number: 16300 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 06 Aug 2020 18:51:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9851: Truncate long error message.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16300 ) Change subject: IMPALA-9851: Truncate long error message. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16300/1/be/src/util/internal-queue.h File be/src/util/internal-queue.h: http://gerrit.cloudera.org:8080/#/c/16300/1/be/src/util/internal-queue.h@279 PS1, Line 279: // reached. If 'fn' returns false, terminate iteration. It is invalid to call other > Comment what happens if n is greater than the size of the list? Done -- To view, visit http://gerrit.cloudera.org:8080/16300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9fa4d024fb3dc9de03c7484f41b5e420a710e5a Gerrit-Change-Number: 16300 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 06 Aug 2020 18:34:57 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9851: Truncate long error message.
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16300 to look at the new patch set (#2). Change subject: IMPALA-9851: Truncate long error message. .. IMPALA-9851: Truncate long error message. Error message length was unbounded and can grow very large into couple of MB in size. This patch truncate error message to maximum 128kb in size. This patch also fix potentially long error message related to BufferPool::Client::DebugString(). Before this patch, DebugString() will print all pages in 'pinned_pages_', 'dirty_unpinned_pages_', and 'in_flight_write_pages_' PageList. With this patch, DebugString() only include maximum of 100 first pages in each PageList. Testing: - Add be test BufferPoolTest.ShortDebugString - Add test within ErrorMsg.GenericFormatting to test for truncation. - Run and pass core tests. Change-Id: Ic9fa4d024fb3dc9de03c7484f41b5e420a710e5a --- M be/src/runtime/bufferpool/buffer-pool-internal.h M be/src/runtime/bufferpool/buffer-pool-test.cc M be/src/runtime/bufferpool/buffer-pool.cc M be/src/runtime/bufferpool/buffer-pool.h M be/src/util/error-util-test.cc M be/src/util/error-util.cc M be/src/util/error-util.h M be/src/util/internal-queue.h 8 files changed, 163 insertions(+), 62 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/16300/2 -- To view, visit http://gerrit.cloudera.org:8080/16300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic9fa4d024fb3dc9de03c7484f41b5e420a710e5a Gerrit-Change-Number: 16300 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-9851: Truncate long error message.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16300 ) Change subject: IMPALA-9851: Truncate long error message. .. Patch Set 1: Code-Review+2 (1 comment) One minor comment http://gerrit.cloudera.org:8080/#/c/16300/1/be/src/util/internal-queue.h File be/src/util/internal-queue.h: http://gerrit.cloudera.org:8080/#/c/16300/1/be/src/util/internal-queue.h@279 PS1, Line 279: // from 'fn'. Comment what happens if n is greater than the size of the list? -- To view, visit http://gerrit.cloudera.org:8080/16300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9fa4d024fb3dc9de03c7484f41b5e420a710e5a Gerrit-Change-Number: 16300 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 06 Aug 2020 18:11:37 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9851: Truncate long error message.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16300 ) Change subject: IMPALA-9851: Truncate long error message. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/6807/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic9fa4d024fb3dc9de03c7484f41b5e420a710e5a Gerrit-Change-Number: 16300 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 06 Aug 2020 15:04:43 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9851: Truncate long error message.
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16300 Change subject: IMPALA-9851: Truncate long error message. .. IMPALA-9851: Truncate long error message. Error message length was unbounded and can grow very large into couple of MB in size. This patch truncate error message to maximum 128kb in size. This patch also fix potentially long error message related to BufferPool::Client::DebugString(). Before this patch, DebugString() will print all pages in 'pinned_pages_', 'dirty_unpinned_pages_', and 'in_flight_write_pages_' PageList. With this patch, DebugString() only include maximum of 100 first pages in each PageList. Testing: - Add be test BufferPoolTest.ShortDebugString - Add test within ErrorMsg.GenericFormatting to test for truncation. - Run and pass core tests. Change-Id: Ic9fa4d024fb3dc9de03c7484f41b5e420a710e5a --- M be/src/runtime/bufferpool/buffer-pool-internal.h M be/src/runtime/bufferpool/buffer-pool-test.cc M be/src/runtime/bufferpool/buffer-pool.cc M be/src/runtime/bufferpool/buffer-pool.h M be/src/util/error-util-test.cc M be/src/util/error-util.cc M be/src/util/error-util.h M be/src/util/internal-queue.h 8 files changed, 162 insertions(+), 62 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/16300/1 -- To view, visit http://gerrit.cloudera.org:8080/16300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic9fa4d024fb3dc9de03c7484f41b5e420a710e5a Gerrit-Change-Number: 16300 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto
