[Impala-ASF-CR] IMPALA-4110: Clean up issues found by Apache RAT.

2016-09-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4110: Clean up issues found by Apache RAT. .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4361/6/be/.impala.doxy File be/.impala.doxy: Line

[Impala-ASF-CR] IMPALA-4110: Apache RAT script on Impala tarballs.

2016-09-14 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: IMPALA-4110: Apache RAT script on Impala tarballs. .. IMPALA-4110: Apache RAT script on Impala tarballs. Apache RAT is a tool for license auditing. It will

[Impala-ASF-CR] IMPALA-4110: Apache RAT script on Impala tarballs.

2016-09-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4110: Apache RAT script on Impala tarballs. .. Patch Set 1: Verified+1 No GVO implications, so self-verifying -- To view, visit http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-4110: Clean up issues found by Apache RAT.

2016-09-14 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#7). Change subject: IMPALA-4110: Clean up issues found by Apache RAT. .. IMPALA-4110: Clean up issues found by Apache RAT. The script and support files are in another patch: https://gerr

[Impala-ASF-CR] IMPALA-4110: Clean up issues found by Apache RAT.

2016-09-14 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#8). Change subject: IMPALA-4110: Clean up issues found by Apache RAT. .. IMPALA-4110: Clean up issues found by Apache RAT. Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962 --- M LICEN

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 4: Sahil can you please push the rebased commit to Gerrit? If you kept the Change-Id in the

[Impala-ASF-CR] IMPALA-1702: Enforce unique table ID

2016-09-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1702: Enforce unique table ID .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4349/2/fe/src/main/java/com/cloudera/impala/catalog

[Impala-ASF-CR] IMPALA-4110: Clean up issues found by Apache RAT.

2016-09-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4110: Clean up issues found by Apache RAT. .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4361/6/be/.impala.doxy File be/.impala.doxy: Line

[Impala-ASF-CR] Make gen build version.py resilient to a failing git rev-parse

2016-09-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Make gen_build_version.py resilient to a failing git rev-parse .. Patch Set 1: (3 comments) Thanks for fixing this. http://gerrit.cloudera.org:8080/#/c/4411/1/bi

[Impala-ASF-CR] IMPALA-4110: Clean up issues found by Apache RAT.

2016-09-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4110: Clean up issues found by Apache RAT. .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4361 To unsubscribe, visit http://

[Impala-ASF-CR] IMPALA-3718: Support subset of functional-query for Kudu

2016-09-14 Thread Matthew Jacobs (Code Review)
Hello Michael Brown, Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4175 to look at the new patch set (#5). Change subject: IMPALA-3718: Support subset of functional-query for Kudu ..

[Impala-ASF-CR] IMPALA-3718: Support subset of functional-query for Kudu

2016-09-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3718: Support subset of functional-query for Kudu .. Patch Set 5: Code-Review+2 planner test output had output from before a recent kudu client change so

[Impala-ASF-CR] IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-14 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#8). Change subject: IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION .. IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION Just like Hive, Impl

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-09-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/4414 Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. IMPALA-3719: Simplify CREATE TABLE statements w

[Impala-ASF-CR] IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-14 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 7: (9 comments) http://gerrit.cloudera.org:8080/#/c/4144/7/fe/src/main/cup/sq

[Impala-ASF-CR] IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-14 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#8). Change subject: IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION .. IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION Just like Hive, Impl

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-09-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 1: There are definitely some rough edges but I am posting the CR so that we c

[Impala-ASF-CR] IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 8: (15 comments) Flushing out some comments. Haven't looked at the t

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-14 Thread David Knupp (Code Review)
Hello Michael Brown, Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4348 to look at the new patch set (#9). Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. Patch Set 9: Harrison very astutely pointed out in an out-of-band message that I had

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. Patch Set 9: What about the other clients like for HDFS? -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-14 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. Patch Set 9: Harrison and I looked at that too, but the hdfs lib binds to the WebHDFS/

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. Patch Set 9: Code-Review+2 Thanks for the explanation. Harrison, thanks for reviewing!

[Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads

2016-09-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Patch Set 4: (15 comments) I was hoping to get to +1 this pass but there's a bit more still... Most

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-3739: Enable stress tests on Kudu .. IMPALA-3739: Enable stress tests on Kudu This commit modifies the stress test framework to run TPC-H and TPC-DS

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/4327/1//COMMIT_MSG Commit Message: PS1, Line

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4327/1//COMMIT_MSG Commit Message: Line 18: 3.

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 1: (2 comments) I'm still reviewing this, but since my name was called out, here are two comments. http:

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-3739: Enable stress tests on Kudu .. IMPALA-3739: Enable stress tests on Kudu This commit modifies the stress test framework to run TPC-H and TPC-DS

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-14 Thread Harrison Sheinblatt (Code Review)
Harrison Sheinblatt has posted comments on this change. Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/4348/9/testdata/

[Impala-ASF-CR] IMPALA-4110: Clean up issues found by Apache RAT.

2016-09-14 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4110: Clean up issues found by Apache RAT. .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4361 To unsubscribe, visit htt

[Impala-ASF-CR] IMPALA-4110: Clean up issues found by Apache RAT.

2016-09-14 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4110: Clean up issues found by Apache RAT. .. IMPALA-4110: Clean up issues found by Apache RAT. Change-Id: I5bfe77f9a871018e7a67553ed270e2df53

[Impala-ASF-CR] IMPALA-3718: Support subset of functional-query for Kudu

2016-09-14 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3718: Support subset of functional-query for Kudu .. IMPALA-3718: Support subset of functional-query for Kudu Adds initial support for the fun

[Impala-ASF-CR] IMPALA-3718: Support subset of functional-query for Kudu

2016-09-14 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3718: Support subset of functional-query for Kudu .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4175 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-14 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/4327/3/testdata/bin/load-tpc-kudu.py File testdata/bin

[Impala-ASF-CR] Make gen build version.py resilient to a failing git rev-parse

2016-09-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). Change subject: Make gen_build_version.py resilient to a failing git rev-parse .. Make gen_build_version.py resilient to a failing git rev-parse It was noticed that some build pro

[Impala-ASF-CR] Make gen build version.py resilient to a failing git rev-parse

2016-09-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: Make gen_build_version.py resilient to a failing git rev-parse .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4411/1/bin/gen_build_version.py

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-14 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4348 T

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-14 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-09-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 1: (28 comments) Ok, here's a bit to get started. Just made my way through most of

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-14 Thread Tim Armstrong (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3873 to look at the new patch set (#15). Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. IMPALA-

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 14: (53 comments) http://gerrit.cloudera.org:8080/#/c/3873/14/be/src/exec/analytic-eval-nod

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-09-14 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#11). Change subject: IMPALA-1654: General partition exprs in DDL operations. .. IMPALA-1654: General partition exprs in DDL operations. This commit handles partition related DDL in a more

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-09-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1654: General partition exprs in DDL operations. .. Patch Set 11: (6 comments) Amos, sorry to meddle with your patch but it seemed easier/faster this way si

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-14 Thread Tim Armstrong (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3873 to look at the new patch set (#16). Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. IMPALA-

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 16: Rebased onto master -- To view, visit http://gerrit.cloudera.org:8080/3873 To unsubscr

[Impala-ASF-CR] Make gen build version.py resilient to a failing git rev-parse

2016-09-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Make gen_build_version.py resilient to a failing git rev-parse .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4411/2/bin/gen_build_version.py Fi

[Impala-ASF-CR] IMPALA-3912: test random rpc timeout is flaky.

2016-09-14 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3912: test_random_rpc_timeout is flaky. .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4080 To unsubscribe, visit http:

[Impala-ASF-CR] IMPALA-4014: HEADERS ONLY: Introduce query-wide execution state.

2016-09-14 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has uploaded a new change for review. http://gerrit.cloudera.org:8080/4418 Change subject: IMPALA-4014: HEADERS ONLY: Introduce query-wide execution state. .. IMPALA-4014: HEADERS ONLY: Introduce query-wide ex

[Impala-ASF-CR] Make gen build version.py resilient to a failing git rev-parse

2016-09-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#3). Change subject: Make gen_build_version.py resilient to a failing git rev-parse .. Make gen_build_version.py resilient to a failing git rev-parse It was noticed that some build pro

[Impala-ASF-CR] Make gen build version.py resilient to a failing git rev-parse

2016-09-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: Make gen_build_version.py resilient to a failing git rev-parse .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4411/2/bin/gen_build_version.py

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-14 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has uploaded a new change for review. http://gerrit.cloudera.org:8080/4419 Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. IMPALA-4101: qgen: Hive join p

[Impala-ASF-CR] Bump Kudu version to 1.0-RC1

2016-09-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/4420 Change subject: Bump Kudu version to 1.0-RC1 .. Bump Kudu version to 1.0-RC1 Change-Id: Ibbe554d6782212f91db07757f429c5571a7a44da --- M

[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string

2016-09-14 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/4421 Change subject: IMPALA-4116: Remove 'cdh' from version string .. IMPALA-4116: Remove 'cdh' from version string Change-Id: I7754538a23e73dc

[Impala-ASF-CR] Make gen build version.py resilient to a failing git rev-parse

2016-09-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Make gen_build_version.py resilient to a failing git rev-parse .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4411/3/bin/gen_build_version.py Fil

[Impala-ASF-CR] Make gen build version.py resilient to a failing git rev-parse

2016-09-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#4). Change subject: Make gen_build_version.py resilient to a failing git rev-parse .. Make gen_build_version.py resilient to a failing git rev-parse It was noticed that some build pro

[Impala-ASF-CR] Make gen build version.py resilient to a failing git rev-parse

2016-09-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: Make gen_build_version.py resilient to a failing git rev-parse .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4411/3/bin/gen_build_version.py F

[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string

2016-09-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4116: Remove 'cdh' from version string .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4421/1/bin/save-version.sh File bin/save-version.sh:

[Impala-ASF-CR] Make gen build version.py resilient to a failing git rev-parse

2016-09-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Make gen_build_version.py resilient to a failing git rev-parse .. Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4411/3/bin/gen_build_

[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string

2016-09-14 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-4116: Remove 'cdh' from version string .. IMPALA-4116: Remove 'cdh' from version string Change-Id: I7754538a23e73dcdebc6e3df509f357cbe03198c --- M bin/save-ve

[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string

2016-09-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4116: Remove 'cdh' from version string .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4421/1/bin/save-version.sh File bin/save-version.sh:

[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string

2016-09-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4116: Remove 'cdh' from version string .. Patch Set 2: Code-Review+1 I'd like another +1 on this, just for another pair of eyes. Once this is done, I'll cher

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-14 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 5: > Uploaded patch set 5: Patch Set 4 was rebased. @Michael, not sure what happened

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-14 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has uploaded a new patch set (#2). Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. IMPALA-4101: qgen: Hive join predicates should only contains equality fun

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-14 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. Patch Set 2: > Uploaded patch set 2: Commit message was updated. @Mic

[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string

2016-09-14 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4116: Remove 'cdh' from version string .. Patch Set 2: Code-Review+2 I've rethought it and I'm convinced this has a very low probability of causing issues.

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/4327/3/testdata/bin/load-tpc-kudu.py File test

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-09-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-3739: Enable stress tests on Kudu .. IMPALA-3739: Enable stress tests on Kudu This commit modifies the stress test framework to run TPC-H and TPC-DS

[Impala-ASF-CR] Bump Kudu version to 1.0-RC1

2016-09-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: Bump Kudu version to 1.0-RC1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4420 To unsubscribe, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-09-14 Thread Amos Bird (Code Review)
Amos Bird has posted comments on this change. Change subject: IMPALA-1654: General partition exprs in DDL operations. .. Patch Set 11: (1 comment) Thanks for helping me fix the auditing bugs. I wish this wiki may help me get

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-09-14 Thread Amos Bird (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3942 to look at the new patch set (#12). Change subject: IMPALA-1654: General partition exprs in DDL operations. .. IMPALA-

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-09-14 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1654: General partition exprs in DDL operations. .. Patch Set 11: (1 comment) I agree we should follow up offline to fix your env issues and update the wiki

[Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads

2016-09-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#5). Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. IMPALA-3823: Add timer to measure Parquet footer reads It's been observed that Parquet footer reads perfo

[Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads

2016-09-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Patch Set 4: (15 comments) http://gerrit.cloudera.org:8080/#/c/4371/4/be/src/exec/hdfs-parquet-scanner

[Impala-ASF-CR] IMPALA-4116: Remove 'cdh' from version string

2016-09-14 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4116: Remove 'cdh' from version string .. Patch Set 2: Verified-1 Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-

[Impala-ASF-CR] IMPALA-4053: Address follow up comments for IMPALA-3610

2016-09-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#3). Change subject: IMPALA-4053: Address follow up comments for IMPALA-3610 .. IMPALA-4053: Address follow up comments for IMPALA-3610 This is a follow up to the 'Account memory for g

[Impala-ASF-CR] IMPALA-4053: Address follow up comments for IMPALA-3610

2016-09-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4053: Address follow up comments for IMPALA-3610 .. Patch Set 3: (15 comments) http://gerrit.cloudera.org:8080/#/c/4306/2/be/src/runtime/coordinator.cc F