[Impala-ASF-CR] IMPALA-3504: UDF for current timestamp in UTC

2016-10-04 Thread Youwei Wang (Code Review)
Youwei Wang has posted comments on this change. Change subject: IMPALA-3504: UDF for current timestamp in UTC .. Patch Set 8: > Carrying the previous +1 so it can be reviewed for a +2. Greetings, dear Matthew. Thank you so muc

[Impala-ASF-CR] IMPALA-889: Add support for an ISO-SQL compliant trim() function.

2016-10-04 Thread Youwei Wang (Code Review)
Youwei Wang has uploaded a new patch set (#7). Change subject: IMPALA-889: Add support for an ISO-SQL compliant trim() function. .. IMPALA-889: Add support for an ISO-SQL compliant trim() function. Purpose: Removes all instance

[Impala-ASF-CR] IMPALA-889: Add support for an ISO-SQL compliant trim() function.

2016-10-04 Thread Youwei Wang (Code Review)
Youwei Wang has posted comments on this change. Change subject: IMPALA-889: Add support for an ISO-SQL compliant trim() function. .. Patch Set 6: (32 comments) http://gerrit.cloudera.org:8080/#/c/4474/1//COMMIT_MSG Commit Mes

[Impala-ASF-CR] IMPALA-889: Add support for an ISO-SQL compliant trim() function.

2016-10-04 Thread Youwei Wang (Code Review)
Youwei Wang has uploaded a new patch set (#8). Change subject: IMPALA-889: Add support for an ISO-SQL compliant trim() function. .. IMPALA-889: Add support for an ISO-SQL compliant trim() function. Purpose: Removes all instance

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-10-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/4519/5//CO

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-10-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#6). Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. IMPALA-4135: Thrift threaded server times-out connections during high load

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-04 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency accross service .. Patch Set 4: (11 comments) http://gerrit.cloudera.org:8080/#/c/4349/4/fe/src/main/java/org/apache/im

[Impala-ASF-CR] IMPALA-784: Use `-s in SHOW CREATE TABLE output

2016-10-04 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-784: Use `-s in SHOW CREATE TABLE output .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4527/2/fe/src/main/java/com/cloudera/impala/anal

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-04 Thread Huaisi Xu (Code Review)
Huaisi Xu has uploaded a new patch set (#5). Change subject: IMPALA-1702: Enforce table level consistency accross service .. IMPALA-1702: Enforce table level consistency accross service Problems: 1. CatalogServiceCatalog::reset(

[Impala-ASF-CR] IMPALA-4042: count(distinct NULL) fails on a view

2016-10-04 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has uploaded a new patch set (#3). Change subject: IMPALA-4042: count(distinct NULL) fails on a view .. IMPALA-4042: count(distinct NULL) fails on a view In case of count(distinct), FunctionCallExpr.analyze() chan

[Impala-ASF-CR] IMPALA-4042: count(distinct NULL) fails on a view

2016-10-04 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has posted comments on this change. Change subject: IMPALA-4042: count(distinct NULL) fails on a view .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4600/2/fe/src/main/java/org/apache/impala/ana

[Impala-ASF-CR] IMPALA-3983: Delete function jar resources after load

2016-10-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new change for review. http://gerrit.cloudera.org:8080/4617 Change subject: IMPALA-3983: Delete function jar resources after load .. IMPALA-3983: Delete function jar resources after load Ca

[Impala-ASF-CR] Add vim-specific files to .gitignore

2016-10-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: Add vim-specific files to .gitignore .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4562 To unsubscribe, visit http://gerrit.cl

[Impala-ASF-CR] Add vim-specific files to .gitignore

2016-10-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: Add vim-specific files to .gitignore .. Add vim-specific files to .gitignore Change-Id: I1abcd8ca0e18178684c916ef6f7d55c25c0814a4 Reviewed-on: http:/

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-10-04 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 6: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4519/

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 14: (11 comments) http://gerrit.cloudera.org:8080/#/c/4144/14/fe/sr

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency accross service

2016-10-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency accross service .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/4349/4/fe/src/main/java/org/apache/imp

[Impala-ASF-CR] IMPALA-3229: Don't assume that AUX exists just because of shell env

2016-10-04 Thread Jim Apple (Code Review)
Hello Michael Brown, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4563 to look at the new patch set (#4). Change subject: IMPALA-3229: Don't assume that AUX exists just because of shell env

[Impala-ASF-CR](asf-site) IMPALA-3808: Add downloads page

2016-10-04 Thread Jim Apple (Code Review)
Hello Taras Bobrovytsky, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4544 to look at the new patch set (#6). Change subject: IMPALA-3808: Add downloads page .. IMPALA-3808:

[Impala-ASF-CR] IMPALA-4042: count(distinct NULL) fails on a view

2016-10-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4042: count(distinct NULL) fails on a view .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4600/3//COMMIT_MSG Commit Message: Line 7: IMPAL

[Impala-ASF-CR](asf-site) IMPALA-3808: Add downloads page

2016-10-04 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3808: Add downloads page .. Patch Set 6: Code-Review+2 Just changed commit message, carrying +2 -- To view, visit http://gerrit.cloudera.org:8080/4544 To un

[Impala-ASF-CR] IMPALA-784: Use `-s in SHOW CREATE TABLE output

2016-10-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-784: Use `-s in SHOW CREATE TABLE output .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4527/2/fe/src/main/java/com/cloudera/impala/analysis

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-4123: Fast bit unpacking .. IMPALA-4123: Fast bit unpacking Adds utility functions for fast unpacking of batches of bit-packed values. These support reading

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 2: (34 comments) http://gerrit.cloudera.org:8080/#/c/4494/2//COMMIT_MSG Commit Message: PS2, Line 12: was > "want"

[Impala-ASF-CR] IMPALA-3983: Delete function jar resources after load

2016-10-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3983: Delete function jar resources after load .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4617/1//COMMIT_MSG Commit Message: Line 9: C

[Impala-ASF-CR] IMPALA-3229: Don't assume that AUX exists just because of shell env

2016-10-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3229: Don't assume that AUX exists just because of shell env .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4563 To unsubsc

[Impala-ASF-CR] IMPALA-4042: Preserve root types when substituting grouping exprs

2016-10-04 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has uploaded a new patch set (#4). Change subject: IMPALA-4042: Preserve root types when substituting grouping exprs .. IMPALA-4042: Preserve root types when substituting grouping exprs In case of count(distinct)

[Impala-ASF-CR] IMPALA-4042: Preserve root types when substituting grouping exprs

2016-10-04 Thread Yonghyun Hwang (Code Review)
Yonghyun Hwang has posted comments on this change. Change subject: IMPALA-4042: Preserve root types when substituting grouping exprs .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4600/3//COMMIT_MSG Commit M

[Impala-ASF-CR] IMPALA-4042: Preserve root types when substituting grouping exprs

2016-10-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4042: Preserve root types when substituting grouping exprs .. Patch Set 4: Code-Review+2 Nice work! -- To view, visit http://gerrit.cloudera.org:8080/4600

[Impala-ASF-CR] IMPALA-4246: SleepForMs() utility function has undefined behavior for > 1s

2016-10-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/4622 Change subject: IMPALA-4246: SleepForMs() utility function has undefined behavior for > 1s .. IMPALA-4246: SleepForMs() utility function

[Impala-ASF-CR] IMPALA-4246: SleepForMs() utility function has undefined behavior for > 1s

2016-10-04 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4246: SleepForMs() utility function has undefined behavior for > 1s .. Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/4622

[Impala-ASF-CR] IMPALA-4246: SleepForMs() utility function has undefined behavior for > 1s

2016-10-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4246: SleepForMs() utility function has undefined behavior for > 1s .. Patch Set 1: Code-Review+2 (2 comments) Carry +2. http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-3983: Delete function jar resources after load

2016-10-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3983: Delete function jar resources after load .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4617/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4246: SleepForMs() utility function has undefined behavior for > 1s

2016-10-04 Thread Sailesh Mukil (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4622 to look at the new patch set (#2). Change subject: IMPALA-4246: SleepForMs() utility function has undefined behavior for > 1s ...

[Impala-ASF-CR] IMPALA-4246: SleepForMs() utility function has undefined behavior for > 1s

2016-10-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4246: SleepForMs() utility function has undefined behavior for > 1s .. Patch Set 2: Code-Review+2 Carry +2. -- To view, visit http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-3983: Delete function jar resources after load

2016-10-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3983: Delete function jar resources after load .. Patch Set 1: new patch? -- To view, visit http://gerrit.cloudera.org:8080/4617 To unsubscribe, visit http:

[Impala-ASF-CR] IMPALA-3983: Delete function jar resources after load

2016-10-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#2). Change subject: IMPALA-3983: Delete function jar resources after load .. IMPALA-3983: Delete function jar resources after load The Catalog copies the UDF jar files to the l

[Impala-ASF-CR] IMPALA-3983: Delete function jar resources after load

2016-10-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3983: Delete function jar resources after load .. Patch Set 2: Sorry I thought I sent ..but the push failed with some gerrit error. here it is. --

[Impala-ASF-CR] IMPALA-4231: fix codegen time regression

2016-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4623 Change subject: IMPALA-4231: fix codegen time regression .. IMPALA-4231: fix codegen time regression The commit "IMPALA-3567 Part 2, IMP

[Impala-ASF-CR] IMPALA-3983: Delete function jar resources after load

2016-10-04 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3983: Delete function jar resources after load .. Patch Set 2: Code-Review+1 (1 comment) Henry, can you check the catalog changes? http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-10-04 Thread Bharath Vissapragada (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4617 to look at the new patch set (#3). Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load .

[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-10-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load .. Patch Set 2: (1 comment) Thanks Alex. Carrying +1. http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-04 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 3: (34 comments) http://gerrit.cloudera.org:8080/#/c/4494/2/be/src/benchmarks/bit-packing-benchmark.cc File be/src/benc

[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-10-04 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load .. Patch Set 2: (1 comment) Any easy way to test this? Can you add some UDFs and then check

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-04 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#7). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. IMPALA-2905: Handle coordinator fragment lifecycle like all others The plan-root fragment i

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-04 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 7: (28 comments) This patch passes EE tests. I haven't completely addressed t

[Impala-ASF-CR] IMPALA-4213: Planner not pushing some Kudu predicates

2016-10-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-4213: Planner not pushing some Kudu predicates .. IMPALA-4213: Planner not pushing some Kudu predicates Folding const exprs where there were implicit casts

[Impala-ASF-CR] IMPALA-3229: Don't assume that AUX exists just because of shell env

2016-10-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3229: Don't assume that AUX exists just because of shell env .. Patch Set 4: Verified-1 Build failed: http://sandbox.jenkins.cloudera.com/job/impala-

[Impala-ASF-CR] IMPALA-4213: Planner not pushing some Kudu predicates

2016-10-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4213: Planner not pushing some Kudu predicates .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4613/1/fe/src/main/java/org/apache/impala

[Impala-ASF-CR] IMPALA-4042: Preserve root types when substituting grouping exprs

2016-10-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4042: Preserve root types when substituting grouping exprs .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4600 To unsub

[Impala-ASF-CR] IMPALA-4042: Preserve root types when substituting grouping exprs

2016-10-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4042: Preserve root types when substituting grouping exprs .. IMPALA-4042: Preserve root types when substituting grouping exprs In case of co

[Impala-ASF-CR] IMPALA-4246: SleepForMs() utility function has undefined behavior for > 1s

2016-10-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4246: SleepForMs() utility function has undefined behavior for > 1s .. IMPALA-4246: SleepForMs() utility function has undefined behavior for >

[Impala-ASF-CR] IMPALA-4246: SleepForMs() utility function has undefined behavior for > 1s

2016-10-04 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4246: SleepForMs() utility function has undefined behavior for > 1s .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4622