[Impala-ASF-CR] IMPALA-3918: Fix straggler Cloudera -> ASF license headers

Todd Lipcon has posted comments on this change. Change subject: IMPALA-3918: Fix straggler Cloudera -> ASF license headers .. Patch Set 1: lgtm, though it might be a good idea to document the reasoning that the "relicense" is

[Impala-ASF-CR] kudu: fix uninitialized variable usage warning

Hello Matthew Jacobs, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6098 to review the following change. Change subject: kudu: fix uninitialized variable usage warning .. kudu: fix uniniti

[Impala-ASF-CR] build: don't look in system paths for kudu client

Hello Matthew Jacobs, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6097 to review the following change. Change subject: build: don't look in system paths for kudu client .. build: don't l

[Impala-ASF-CR] Avoid including Boost cmake support from system path

Hello Matthew Jacobs, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6096 to review the following change. Change subject: Avoid including Boost cmake support from system path .. Avoid inclu

[Impala-ASF-CR] Avoid including Boost cmake support from system path

Todd Lipcon has abandoned this change. Change subject: Avoid including Boost cmake support from system path .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/6096 To unsubscribe, visit http://gerrit.cloudera.org:8

[Impala-ASF-CR] Avoid including Boost cmake support from system path

Todd Lipcon has posted comments on this change. Change subject: Avoid including Boost cmake support from system path .. Patch Set 1: Oh, interesting. He and I didn't coordinate, but I'm guessing we both tried building on the s

[Impala-ASF-CR] build: don't look in system paths for kudu client

Todd Lipcon has posted comments on this change. Change subject: build: don't look in system paths for kudu client .. Patch Set 1: I'm not sure I can trigger a GVM. Does your +2 automatically trigger it? LMK if there's anything

[Impala-ASF-CR] kudu: fix uninitialized variable usage warning

Todd Lipcon has posted comments on this change. Change subject: kudu: fix uninitialized variable usage warning .. Patch Set 1: I doubt we'd see this in real life, since as far as I know glog always sets the severity to one of

[Impala-ASF-CR] IMPALA-4758: (2/2) Impala-side changes to build with latest gutil

Todd Lipcon has posted comments on this change. Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest gutil .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/5688/9//COMMIT_MSG Commit Messa

[Impala-ASF-CR] IMPALA-5301: Set Kudu minicluster memory limit

Todd Lipcon has posted comments on this change. Change subject: IMPALA-5301: Set Kudu minicluster memory limit .. Patch Set 5: Code-Review+1 Seems fine from the Kudu side. Not quite familiar enough with the test_kudu.py part t

[Impala-ASF-CR] IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu

Todd Lipcon has posted comments on this change. Change subject: IMPALA-4616: [DOCS] Doc new ALTER TABLE options for Kudu .. Patch Set 1: did we also add ALTER TABLE ALTER COLUMN SET DEFAULT and such? -- To view, visit http://

[Impala-ASF-CR] IMPALA-3267 [DOCS] Docs about nan/inf are incorrect

Todd Lipcon has posted comments on this change. Change subject: IMPALA-3267 [DOCS] Docs about nan/inf are incorrect .. Patch Set 1: Code-Review+1 lgtm, but I'm not a committer, so you'll need a +2 from someone else -- To view

[Impala-ASF-CR] WIP: Use AUTO FLUSH BACKGROUND for Kudu sink

Hello Matthew Jacobs, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4670 to review the following change. Change subject: WIP: Use AUTO_FLUSH_BACKGROUND for Kudu sink .. WIP: Use AUTO_FLUSH

[Impala-ASF-CR] WIP: Use AUTO FLUSH BACKGROUND for Kudu sink

Todd Lipcon has posted comments on this change. Change subject: WIP: Use AUTO_FLUSH_BACKGROUND for Kudu sink .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4670/1/be/src/exec/kudu-table-sink.cc File be/src/exe

[Impala-ASF-CR] WIP: Use AUTO FLUSH BACKGROUND for Kudu sink

Todd Lipcon has uploaded a new patch set (#2). Change subject: WIP: Use AUTO_FLUSH_BACKGROUND for Kudu sink .. WIP: Use AUTO_FLUSH_BACKGROUND for Kudu sink Change-Id: I665ce82d1caf64cf5bdf4bc0e15edbf9f1dc5ba0 --- M be/src/exec/k

[Impala-ASF-CR] WIP: Use AUTO FLUSH BACKGROUND for Kudu sink

Todd Lipcon has posted comments on this change. Change subject: WIP: Use AUTO_FLUSH_BACKGROUND for Kudu sink .. Patch Set 2: new revision likely doesn't address MJ's comments from above, but this is the latest version that see

[Impala-ASF-CR] IMPALA-4134: Use AUTO FLUSH BACKGROUND for Kudu sink

Todd Lipcon has posted comments on this change. Change subject: IMPALA-4134: Use AUTO_FLUSH_BACKGROUND for Kudu sink .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4670/3/be/src/exec/kudu-table-sink.cc File b

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

Todd Lipcon has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4728/4/be/src/exec/kudu-table-sink.cc File be/sr

[Impala-ASF-CR] IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL"

Todd Lipcon has posted comments on this change. Change subject: IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL" .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5259 To

[Impala-ASF-CR] IMPALA-4553: ntpd must be synchronized for kudu to start.

Todd Lipcon has posted comments on this change. Change subject: IMPALA-4553: ntpd must be synchronized for kudu to start. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5258 To unsubscribe, vis

[Impala-ASF-CR] IMPALA-4654: KuduScanner must return when ReachedLimit()

Todd Lipcon has posted comments on this change. Change subject: IMPALA-4654: KuduScanner must return when ReachedLimit() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5493/2/be/src/exec/kudu-scanner.cc File b

[Impala-ASF-CR] Updates to DML statements for Impala + Kudu

Todd Lipcon has posted comments on this change. Change subject: Updates to DML statements for Impala + Kudu .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5646/1/docs/topics/impala_delete.xml File docs/topics

[Impala-ASF-CR] Major update to Impala + Kudu page

Todd Lipcon has posted comments on this change. Change subject: Major update to Impala + Kudu page .. Patch Set 4: (31 comments) http://gerrit.cloudera.org:8080/#/c/5649/4/docs/topics/impala_alter_table.xml File docs/topics/im

[Impala-ASF-CR] Updates to DML statements for Impala + Kudu

Todd Lipcon has posted comments on this change. Change subject: Updates to DML statements for Impala + Kudu .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5646/1/docs/topics/impala_update.xml File docs/topics/

[Impala-ASF-CR] IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8191 ) Change subject: IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8191/4/d

[Impala-ASF-CR] IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8191 ) Change subject: IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8191 ) Change subject: IMPALA-4622: [DOCS] New Kudu ALTER TABLE syntax .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 7: > Patch Set 7: > > Perf results: > ... I'm surprised that

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 7: > Patch Set 7: > > > > Patch Set 7: > > > > > > Perf resu

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 7: I know that He Lifu at NetEase also prototyped some support