Todd Lipcon has posted comments on this change. Change subject: WIP: Use AUTO_FLUSH_BACKGROUND for Kudu sink ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4670/1/be/src/exec/kudu-table-sink.cc File be/src/exec/kudu-table-sink.cc: PS1, Line 176: SetString > I assume this doesn't result in any more copying than we had before? It does result in an extra copy, which is unfortunate, but it's not safe otherwise, since the Kudu operation will live in the buffer even after this Impala row batch has been recycled. It might be possible to avoid this using various async APIs, some reference counting, releasing the memory pool of the RowBatch, etc, but I didn't think that optimization was worth the complexity, especially for an initial patch. On the write side we're using kudu-bound rather than CPU-bound in Impala anyway. -- To view, visit http://gerrit.cloudera.org:8080/4670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665ce82d1caf64cf5bdf4bc0e15edbf9f1dc5ba0 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
