[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 17: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/7526 To

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. IMPALA-3931: arbitrary fixed-size uda intermediate types Make many builtin aggregate

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 17: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7526 To

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 17: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1078/ --

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 16: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7526 To unsubscribe,

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 15: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/7526 To

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 14: (2 comments)

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-16 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 14: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/7526/12/be/src/udf/udf.h File

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-15 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7526 to look at the new patch set (#14). Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 13: (8 comments)

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 12: (12 comments) http://gerrit.cloudera.org:8080/#/c/7526/12/be/src/codegen/codegen-anyval.h

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 12: (9 comments)

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-15 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7526 to look at the new patch set (#13). Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 12: (9 comments) http://gerrit.cloudera.org:8080/#/c/7526/12/be/src/codegen/codegen-anyval.cc

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7526/8/be/src/codegen/llvm-codegen.cc

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 12: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 12: Code-Review+1 Carry +1 -- To view, visit http://gerrit.cloudera.org:8080/7526 To

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/7526/8/be/src/codegen/llvm-codegen.cc

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-14 Thread Tim Armstrong (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7526 to look at the new patch set (#12). Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types ..

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/7526/8/be/src/codegen/llvm-codegen.cc

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-12 Thread Tim Armstrong (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7526 to look at the new patch set (#11). Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types ..

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 11: Code-Review+1 Rebase -- To view, visit http://gerrit.cloudera.org:8080/7526 To

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 8: (4 comments)

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-12 Thread Tim Armstrong (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7526 to look at the new patch set (#9). Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types ..

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/7526/8/be/src/codegen/codegen-anyval.h

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 8: Code-Review+1 Rebase -- To view, visit http://gerrit.cloudera.org:8080/7526 To

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-08 Thread Tim Armstrong (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7526 to look at the new patch set (#8). Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types ..

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 7: Code-Review+1 LGTM, thanks. I didn't review the codegen code in detail, deferring to

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/7526/6//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. IMPALA-3931: arbitrary fixed-size uda intermediate types Make many builtin aggregate functions use