[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-29 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. IMPALA-4026: Implement double-buffering for BlockingQueue With recent changes to improve

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-29 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4350 To unsubscribe,

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 12: Code-Review+2 Carry +2 forward. -- To view, visit http://gerrit.cloudera.org:8080/4350

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/4350/11/be/src/exec/hdfs-scan-node.cc F

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-29 Thread Michael Ho (Code Review)
Hello Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4350 to look at the new patch set (#12). Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue ..

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 11: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/4350/11/be/src/exec/hdfs-s

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/4350/7/be/src/util/blocking-queue.h File

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-29 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4350 to look at the new patch set (#11). Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. I

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/9/be/src/util/blocking-queue.h File b

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/9/be/src/util/blocking-queue.h File

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/4350/9/be/src/util/blocking-queue.h Fil

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-28 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4350 to look at the new patch set (#10). Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. I

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 9: (3 comments) Is there a new patchset that addresses Juan's change? http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/9/be/src/exec/hdfs-scan-node.cc File

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-27 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/9/be/src/exec/hdfs-scan-node.cc File be

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/4350/7/be/src/util/blocking-queue.h File

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-27 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4350 to look at the new patch set (#9). Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. IM

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-27 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4350 to look at the new patch set (#8). Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. IM

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/4350/7/be/src/util/blocking-queue.h File

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/5/be/src/util/blocking-queue.h File b

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 5: (10 comments) http://gerrit.cloudera.org:8080/#/c/4350/5/be/src/exec/hdfs-scan-node.cc Fi

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-27 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4350 to look at the new patch set (#7). Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. IM

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/4350/5/be/src/exec/hdfs-scan-node.cc File

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 5: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/4350/5/be/src/util/bloc

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-19 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#5). Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. IMPALA-4026: Implement double-buffering for BlockingQueue With recent changes to improve the parquet scan

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/4350/4/be/src/util/blocking-queue.h File

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 4: (8 comments) I'm ok with this option if it generally provides better perf and avoids

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/3/be/src/util/blocking-queue.h File

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-17 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#4). Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. IMPALA-4026: Implement double-buffering for BlockingQueue With recent changes to improve the parquet scan

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/3/be/src/util/blocking-queue.h F

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/3/be/src/util/blocking-queue.h File

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/3/be/src/util/blocking-queue.h F

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/3/be/src/util/condition-variable.h

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/4350/3/be/src/util/blocking-queue.h Fil

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/4350/2/be/src/util/blocking-queue.h

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/4350/2/be/src/util/blocking-queue.h Fil

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-12 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#3). Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. IMPALA-4026: Implement double-buffering for BlockingQueue. With recent changes to improve the parquet sc

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4350/2/be/src/util/blocking-queue.h File

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/2/be/src/util/blocking-queue.h F

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/2/be/src/util/blocking-queue.h File

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 2: (5 comments) Thanks for switching back to unique_lock, it makes it a bit easier to re