[Impala-ASF-CR] IMPALA-5110: Add deb support to dump breakpad symbols.py

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5110: Add deb support to dump_breakpad_symbols.py
..


Patch Set 2:

Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/414/

-- 
To view, visit http://gerrit.cloudera.org:8080/6462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I524d2fe4660551c2fe4ff190b7e5bbb33d986b10
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5110: Add deb support to dump breakpad symbols.py

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5110: Add deb support to dump_breakpad_symbols.py
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I524d2fe4660551c2fe4ff190b7e5bbb33d986b10
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5110: Add deb support to dump breakpad symbols.py

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change.

Change subject: IMPALA-5110: Add deb support to dump_breakpad_symbols.py
..


Patch Set 2:

(3 comments)

Thank you for the review. Please see my comments and PS2.

http://gerrit.cloudera.org:8080/#/c/6462/1/bin/dump_breakpad_symbols.py
File bin/dump_breakpad_symbols.py:

Line 115:   parser.add_argument('-r', '--pkg', '--rpm', help="""RPM/DEB file 
containing the binaries
> Instead of adding a flag for every package type, should we just add a gener
Done. I changed the flag name so we don't have to worry about compatibility in 
the future. However I kept the help string as I have only seen RPM and DEB 
being used to package Impala and the code below won't work with anything else.


Line 117:   parser.add_argument('-s', '--symbol_pkg', '--debuginfo_rpm', 
help="""RPM/DEB file
> Same here - --symbol_pkg or similar?
Done


Line 208: logging.info('Extracting to %s: %s' % (tmp_dir, pkg))
> Mention the output directory? Might be helpful for debugging if it fails.
Done. The output directory will be removed in case of failure though.


-- 
To view, visit http://gerrit.cloudera.org:8080/6462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I524d2fe4660551c2fe4ff190b7e5bbb33d986b10
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5110: Add deb support to dump breakpad symbols.py

[Lars Volker (Code Review)]

Lars Volker has uploaded a new patch set (#2).

Change subject: IMPALA-5110: Add deb support to dump_breakpad_symbols.py
..

IMPALA-5110: Add deb support to dump_breakpad_symbols.py

Change-Id: I524d2fe4660551c2fe4ff190b7e5bbb33d986b10
---
M bin/dump_breakpad_symbols.py
1 file changed, 56 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/6462/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I524d2fe4660551c2fe4ff190b7e5bbb33d986b10
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-5110: Add deb support to dump breakpad symbols.py

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5110: Add deb support to dump_breakpad_symbols.py
..


Patch Set 1:

(3 comments)

Change looks ok to me, just some minor comments on the interface

http://gerrit.cloudera.org:8080/#/c/6462/1/bin/dump_breakpad_symbols.py
File bin/dump_breakpad_symbols.py:

Line 115:   parser.add_argument('-r', '--rpm', '--deb', help="""RPM/DEB file 
containing the binaries
Instead of adding a flag for every package type, should we just add a generic 
--pkg flag? And keep --rpm for backwards compatibility.


Line 117:   parser.add_argument('-s', '--debuginfo_rpm', '--debuginfo_deb', 
help="""RPM/DEB file
Same here - --symbol_pkg or similar?


Line 208: logging.info('Extracting: %s' % pkg)
Mention the output directory? Might be helpful for debugging if it fails.


-- 
To view, visit http://gerrit.cloudera.org:8080/6462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I524d2fe4660551c2fe4ff190b7e5bbb33d986b10
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5110: Add deb support to dump breakpad symbols.py

[Lars Volker (Code Review)]

Lars Volker has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6462

Change subject: IMPALA-5110: Add deb support to dump_breakpad_symbols.py
..

IMPALA-5110: Add deb support to dump_breakpad_symbols.py

Change-Id: I524d2fe4660551c2fe4ff190b7e5bbb33d986b10
---
M bin/dump_breakpad_symbols.py
1 file changed, 44 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/6462/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I524d2fe4660551c2fe4ff190b7e5bbb33d986b10
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker