[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

2017-08-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7658 To unsubscribe, visit http://g

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

2017-08-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad .. Patch Set 3: Code-Review+2 Rebased, carrying Tim's +2. -- To view, visit http://gerrit.cloudera.org:8080/765

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

2017-08-14 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad .. IMPALA-5477: Fix minidump-2-core tool in breakpad The recent PPC port broke the minidump-2-core tool

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

2017-08-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7658/2/buildall.sh File buildall

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

2017-08-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad .. Patch Set 2: > Yes, please do create a separate patch. We have done the same thing > in Thrift where we've re

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

2017-08-11 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad .. IMPALA-5477: Fix minidump-2-core tool in breakpad The recent PPC port broke the minidump-2-core tool in the tool

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad .. Patch Set 1: Yes, please do create a separate patch. We have done the same thing in Thrift where we've rev

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

2017-08-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad .. Patch Set 1: > Do you think should add this as a separate patch, rather than > updating an existing one? That

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

2017-08-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad .. Patch Set 1: Do you think should add this as a separate patch, rather than updating an existing one? That

[native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad

2017-08-11 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/7658 Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad .. IMPALA-5477: Fix minidump-2-core tool in breakpad The recent PPC port