[kudu-CR] KUDU-526: use on-disk cmeta when loading existing master state

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-526: use on-disk cmeta when loading existing master state .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2889/ -- To view, visit

[kudu-CR] KUDU-526: use on-disk cmeta when loading existing master state

2016-08-15 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3786 to look at the new patch set (#5). Change subject: KUDU-526: use on-disk cmeta when loading existing master state

[kudu-CR] Replace gscoped ptr with unique ptr for ConsensusMetadata

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: Replace gscoped_ptr with unique_ptr for ConsensusMetadata .. Replace gscoped_ptr with unique_ptr for ConsensusMetadata Change-Id:

[kudu-CR] integration tests: end-to-end master permanent failure test

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: integration_tests: end-to-end master permanent failure test .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/3969/2/src/kudu/tools/tool_action.cc

[kudu-CR] [util/env posix.cc] fixed build on MacOS X

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [util/env_posix.cc] fixed build on MacOS X .. Patch Set 1: Code-Review+2 oops, my bad! -- To view, visit http://gerrit.cloudera.org:8080/3978 To unsubscribe,

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Start a background thread to run ResultTracker GC .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2891/ -- To view, visit

[kudu-CR] Memory tracking for result tracker

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 21: Build Started http://104.196.14.100/job/kudu-gerrit/2893/ -- To view, visit

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-15 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3961 to look at the new patch set (#3). Change subject: Start a background thread to run ResultTracker GC .. Start a

[kudu-CR] Memory tracking for result tracker

2016-08-15 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3627 to look at the new patch set (#21). Change subject: Memory tracking for result tracker .. Memory tracking

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 15: Build Started http://104.196.14.100/job/kudu-gerrit/2892/ -- To view, visit

[kudu-CR] Memory tracking for result tracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 20: (3 comments) http://gerrit.cloudera.org:8080/#/c/3627/19/src/kudu/rpc/result_tracker.cc File

[kudu-CR] [util/env posix.cc] fixed build on MacOS X

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [util/env_posix.cc] fixed build on MacOS X .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2890/ -- To view, visit

[kudu-CR] KUDU-526: use on-disk cmeta when loading existing master state

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-526: use on-disk cmeta when loading existing master state .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2894/ -- To view, visit

[kudu-CR] KUDU-526: use on-disk cmeta when loading existing master state

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-526: use on-disk cmeta when loading existing master state .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3786 To

[kudu-CR] KUDU-526: use on-disk cmeta when loading existing master state

2016-08-15 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3786 to look at the new patch set (#7). Change subject: KUDU-526: use on-disk cmeta when loading existing master state

[kudu-CR] KUDU-526: use on-disk cmeta when loading existing master state

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-526: use on-disk cmeta when loading existing master state .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2895/ -- To view, visit

[kudu-CR] [util/env posix.cc] fixed build on MacOS X

2016-08-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3978 Change subject: [util/env_posix.cc] fixed build on MacOS X .. [util/env_posix.cc] fixed build on MacOS X Fixed a tiny typo which broke

[kudu-CR] [util/env posix.cc] fixed build on MacOS X

2016-08-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util/env_posix.cc] fixed build on MacOS X .. Patch Set 1: > oops, my bad! np, and thank you for the instant review! -- To view, visit

[kudu-CR] [util/env posix.cc] fixed build on MacOS X

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [util/env_posix.cc] fixed build on MacOS X .. [util/env_posix.cc] fixed build on MacOS X Fixed a tiny typo which broke build on MacOS X. This is a

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2896/ -- To view, visit

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-15 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#5). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456

[kudu-CR] KUDU-526: use on-disk cmeta when loading existing master state

2016-08-15 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3786 to look at the new patch set (#6). Change subject: KUDU-526: use on-disk cmeta when loading existing master state

[kudu-CR] Another pass on 0.10.0 release notes

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Another pass on 0.10.0 release notes .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2897/ -- To view, visit

[kudu-CR] Another pass on 0.10.0 release notes

2016-08-15 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3979 to review the following change. Change subject: Another pass on 0.10.0 release notes ..

[kudu-CR] KUDU-1522 Fix AlterTable Timestamp col with default value

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1522 Fix AlterTable Timestamp col with default value .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2898/ -- To view, visit

[kudu-CR] KUDU-1522 Fix AlterTable Timestamp col with default value

2016-08-15 Thread Ram Mettu (Code Review)
Ram Mettu has uploaded a new change for review. http://gerrit.cloudera.org:8080/3980 Change subject: KUDU-1522 Fix AlterTable Timestamp col with default value .. KUDU-1522 Fix AlterTable Timestamp col with default value

[kudu-CR] KUDU-1522 Fix AlterTable Timestamp col with default value

2016-08-15 Thread Ram Mettu (Code Review)
Ram Mettu has posted comments on this change. Change subject: KUDU-1522 Fix AlterTable Timestamp col with default value .. Patch Set 1: @Todd I fixed your comments, it created a new gerrit code review - may be something wrong

[kudu-CR] Update some comments in Tablet impl and rename a method

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Update some comments in Tablet impl and rename a method .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2903/ -- To view, visit

[kudu-CR] Update some comments in Tablet impl and rename a method

2016-08-15 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3981 to review the following change. Change subject: Update some comments in Tablet impl and rename a method .. Update

[kudu-CR] KUDU-236 (part 2). Create randomized tablet history GC itest

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236 (part 2). Create randomized tablet history GC itest .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2899/ -- To view, visit

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 13: Build Started http://104.196.14.100/job/kudu-gerrit/2901/ -- To view, visit

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#13). Change subject: KUDU-236 (part 1). Implement tablet history GC ..

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 12: (6 comments)

[kudu-CR] MergeIterator: don't stop iterating on an empty block

2016-08-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: MergeIterator: don't stop iterating on an empty block .. Patch Set 2: (1 comment)

[kudu-CR] Various comment / doc improvements

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Various comment / doc improvements .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2902/ -- To view, visit

[kudu-CR] Create base class for MiniCluster and ExternalMiniCluster

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Create base class for MiniCluster and ExternalMiniCluster .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2900/ -- To view, visit

[kudu-CR] KUDU-236 (part 2). Create randomized tablet history GC itest

2016-08-15 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3975 to look at the new patch set (#6). Change subject: KUDU-236 (part 2). Create randomized tablet history GC itest

[kudu-CR] Various comment / doc improvements

2016-08-15 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3977 to look at the new patch set (#2). Change subject: Various comment / doc improvements .. Various

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 13: > Could you also add a GCing thread to mt-tablet-test? It's a good > way to test interactions

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: rewrite parser logic .. Patch Set 2: looks good but the patch it's based on seems to have exploded. -- To view, visit http://gerrit.cloudera.org:8080/3996

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: rewrite parser logic .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3996 To unsubscribe, visit

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/2940/ -- To view, visit

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-15 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#8). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 17: Yea, gerrit's poor at dealing with renames. git show -M does a better job. For your

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: rewrite parser logic .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2942/ -- To view, visit http://gerrit.cloudera.org:8080/3996 To

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 18: Code-Review+2 (1 comment)

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 17: (6 comments)

[kudu-CR] integration tests: end-to-end master permanent failure test

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: integration_tests: end-to-end master permanent failure test .. integration_tests: end-to-end master permanent failure test This commit defines a workflow

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 18: kicked off dist-test runs with 1000 of each of the integration tests here:

[kudu-CR] integration tests: end-to-end master permanent failure test

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: integration_tests: end-to-end master permanent failure test .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3969 To unsubscribe,

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3628 to look at the new patch set (#18). Change subject: Add time/watermark based garbage collection to ResultTracker

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: rewrite parser logic .. Patch Set 3: > looks good but the patch it's based on seems to have exploded. Yeah, I rebased to switch the order around. And I

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: rewrite parser logic .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3996 To unsubscribe, visit

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: tool: rewrite parser logic .. tool: rewrite parser logic While leaf and non-leaf actions share some common properties, there is much they don't share.

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 17: (1 comment)

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Start a background thread to run ResultTracker GC .. Start a background thread to run ResultTracker GC Change-Id:

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 18: Verified+1 the test failure was some weird dist-test flakiness that I'm looking into

[kudu-CR] MergeIterator: don't stop iterating on an empty block

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: MergeIterator: don't stop iterating on an empty block .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2909/ -- To view, visit

[kudu-CR] KUDU-236 (part 3). Enable tablet history GC by default

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236 (part 3). Enable tablet history GC by default .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2910/ -- To view, visit

[kudu-CR] KUDU-236 (part 2). Create randomized tablet history GC itest

2016-08-15 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3975 to look at the new patch set (#7). Change subject: KUDU-236 (part 2). Create randomized tablet history GC itest

[kudu-CR] KUDU-236 (part 2). Create randomized tablet history GC itest

2016-08-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-236 (part 2). Create randomized tablet history GC itest .. Patch Set 7: I ran 3000 loops of this with 3000 rounds each and they all passed (in RELEASE mode).

[kudu-CR] MergeIterator: don't stop iterating on an empty block

2016-08-15 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3976 to look at the new patch set (#4). Change subject: MergeIterator: don't stop iterating on an empty block ..

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#14). Change subject: KUDU-236 (part 1). Implement tablet history GC ..

[kudu-CR] KUDU-236 (part 2). Create randomized tablet history GC itest

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236 (part 2). Create randomized tablet history GC itest .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2904/ -- To view, visit

[kudu-CR] Update some comments in Tablet impl and rename a method

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Update some comments in Tablet impl and rename a method .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2906/ -- To view, visit

[kudu-CR] KUDU-236 (part 3). Enable tablet history GC by default

2016-08-15 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3983 to review the following change. Change subject: KUDU-236 (part 3). Enable tablet history GC by default .. KUDU-236

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 14: Build Started http://104.196.14.100/job/kudu-gerrit/2907/ -- To view, visit

[kudu-CR] Add release notes for tablet history GC

2016-08-15 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3988 to review the following change. Change subject: Add release notes for tablet history GC .. Add release notes for

[kudu-CR] MergeIterator: don't stop iterating on an empty block

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: MergeIterator: don't stop iterating on an empty block .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2913/ -- To view, visit

[kudu-CR] MergeIterator: don't stop iterating on an empty block

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: MergeIterator: don't stop iterating on an empty block .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1522 Fix AlterTable Timestamp col with default value

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. Change subject: KUDU-1522 Fix AlterTable Timestamp col with default value .. Abandoned Yea, looks like the new commit had a different 'Change-Id' line than the original. That causes it

[kudu-CR] Another pass on 0.10.0 release notes

2016-08-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Another pass on 0.10.0 release notes .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3979/1/docs/release_notes.adoc File docs/release_notes.adoc:

[kudu-CR] Add release notes for tablet history GC

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add release notes for tablet history GC .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2912/ -- To view, visit

[kudu-CR] Support downgrade to version that has LocalConsensus

2016-08-15 Thread Mike Percy (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3985 to review the following change. Change subject: Support downgrade to version that has LocalConsensus ..

[kudu-CR] Support downgrade to version that has LocalConsensus

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Support downgrade to version that has LocalConsensus .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2911/ -- To view, visit

[kudu-CR] Various comment / doc improvements

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Various comment / doc improvements .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2908/ -- To view, visit

[kudu-CR] KUDU-1522 Fix AlterTable Timestamp col with default value

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1522 Fix AlterTable Timestamp col with default value .. KUDU-1522 Fix AlterTable Timestamp col with default value Change-Id:

[kudu-CR] KUDU-1522 Fix AlterTable Timestamp col with default value

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1522 Fix AlterTable Timestamp col with default value .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3980 To unsubscribe,

[kudu-CR] MergeIterator: don't stop iterating on an empty block

2016-08-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: MergeIterator: don't stop iterating on an empty block .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3976 To unsubscribe, visit

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Start a background thread to run ResultTracker GC .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3961/3/src/kudu/rpc/result_tracker.cc File

[kudu-CR] Support downgrade to version that has LocalConsensus

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Support downgrade to version that has LocalConsensus .. Patch Set 1: Code-Review+2 Can you please give this a manual test as part of voting on 0.10 RC? -- To

[kudu-CR] Support downgrade to version that has LocalConsensus

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Support downgrade to version that has LocalConsensus .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3985 To unsubscribe, visit

[kudu-CR] Add docs for non-covering range partitioning

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add docs for non-covering range partitioning .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2914/ -- To view, visit

[kudu-CR] Add docs for non-covering range partitioning

2016-08-15 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3796 to look at the new patch set (#4). Change subject: Add docs for non-covering range partitioning .. Add docs for

[kudu-CR] Memory tracking for result tracker

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 21: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/3627/19/src/kudu/rpc/result_tracker.cc File

[kudu-CR] Memory tracking for result tracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 21: yep, your analysis matches my understanding. -- To view, visit http://gerrit.cloudera.org:8080/3627 To

[kudu-CR] MergeIterator: don't stop iterating on an empty block

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: MergeIterator: don't stop iterating on an empty block .. MergeIterator: don't stop iterating on an empty block The MergeIterator implementation was

[kudu-CR] Support downgrade to version that has LocalConsensus

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Support downgrade to version that has LocalConsensus .. Support downgrade to version that has LocalConsensus Continue writing the "local=false" field

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Start a background thread to run ResultTracker GC .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3961/3/src/kudu/rpc/result_tracker.cc File

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Start a background thread to run ResultTracker GC .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3961/3/src/kudu/rpc/result_tracker.cc File

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 14: > > Could you also add a GCing thread to mt-tablet-test? It's a good > > way to test interactions

[kudu-CR] Predicate evaluation pushdown

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2915/ -- To view, visit http://gerrit.cloudera.org:8080/3990

[kudu-CR] Another pass on 0.10.0 release notes

2016-08-15 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3979 to look at the new patch set (#2). Change subject: Another pass on 0.10.0 release notes .. Another pass on 0.10.0

[kudu-CR] Another pass on 0.10.0 release notes

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Another pass on 0.10.0 release notes .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2922/ -- To view, visit

[kudu-CR] KUDU-1517 Implement doc feedback from Sue M

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1517 Implement doc feedback from Sue M .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2923/ -- To view, visit

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 6: (7 comments) Thank you for the review! I posted a new version (patchset 7) because the

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Start a background thread to run ResultTracker GC .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3961 To unsubscribe, visit

[kudu-CR] fs: allow format with user-specified uuid

2016-08-15 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3968 to look at the new patch set (#3). Change subject: fs: allow format with user-specified uuid .. fs: allow format

[kudu-CR] Add docs for non-covering range partitioning

2016-08-15 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Add docs for non-covering range partitioning .. Patch Set 5: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/3796/3/docs/schema_design.adoc File

[kudu-CR] Add docs for non-covering range partitioning

2016-08-15 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Add docs for non-covering range partitioning .. Patch Set 5: woops, disregard those comments. -- To view, visit http://gerrit.cloudera.org:8080/3796 To

  1   2   >