[kudu-CR] [cluster itest util] update WaitForReplicasReportedToMaster
Hello Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8671 to look at the new patch set (#4). Change subject: [cluster_itest_util] update WaitForReplicasReportedToMaster .. [cluster_itest_util] update WaitForReplicasReportedToMaster Updated signature of the itest::WaitForReplicasReportedToMaster utility function to make the tablet locations and has_leader output parameters optional. This benefits tests which are only interested in the total count of tablet replicas regardless of their locations. This changelist does not contain any functional modifications. Change-Id: Id665f2f54b2642ae62f0bae96ec8f0e4871630cc --- M src/kudu/integration-tests/cluster_itest_util.cc M src/kudu/integration-tests/cluster_itest_util.h M src/kudu/integration-tests/linked_list-test.cc M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc M src/kudu/tools/kudu-admin-test.cc 6 files changed, 67 insertions(+), 127 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/8671/4 -- To view, visit http://gerrit.cloudera.org:8080/8671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id665f2f54b2642ae62f0bae96ec8f0e4871630cc Gerrit-Change-Number: 8671 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] [cluster itest util] update WaitForReplicasReportedToMaster
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8671 to look at the new patch set (#3). Change subject: [cluster_itest_util] update WaitForReplicasReportedToMaster .. [cluster_itest_util] update WaitForReplicasReportedToMaster Updated signature of the itest::WaitForReplicasReportedToMaster utility function to make the tablet locations and has_leader output parameters optional. This benefits tests which are only interested in the total count of tablet replicas regardless of their locations. Change-Id: Id665f2f54b2642ae62f0bae96ec8f0e4871630cc --- M src/kudu/integration-tests/cluster_itest_util.cc M src/kudu/integration-tests/cluster_itest_util.h M src/kudu/integration-tests/linked_list-test.cc M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc M src/kudu/tools/kudu-admin-test.cc 6 files changed, 65 insertions(+), 126 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/8671/3 -- To view, visit http://gerrit.cloudera.org:8080/8671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id665f2f54b2642ae62f0bae96ec8f0e4871630cc Gerrit-Change-Number: 8671 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] [cluster itest util] update WaitForReplicasReportedToMaster
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8671 to look at the new patch set (#2). Change subject: [cluster_itest_util] update WaitForReplicasReportedToMaster .. [cluster_itest_util] update WaitForReplicasReportedToMaster Updated signature of the itest::WaitForReplicasReportedToMaster utility function to make the tablet locations and has_leader output parameters optional. This benefits tests which are only interested in the total count of tablet replicas regardless of their locations. Change-Id: Id665f2f54b2642ae62f0bae96ec8f0e4871630cc --- M src/kudu/integration-tests/cluster_itest_util.cc M src/kudu/integration-tests/cluster_itest_util.h M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc M src/kudu/tools/kudu-admin-test.cc 5 files changed, 60 insertions(+), 105 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/8671/2 -- To view, visit http://gerrit.cloudera.org:8080/8671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id665f2f54b2642ae62f0bae96ec8f0e4871630cc Gerrit-Change-Number: 8671 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] [cluster itest util] update WaitForReplicasReportedToMaster
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8671 ) Change subject: [cluster_itest_util] update WaitForReplicasReportedToMaster .. Patch Set 1: > > Patch Set 1: > > > > > > squash this into a test that needs it? > > > > > > This is not exactly a requirement for particular test, it's > more a > > > convenience update for already existing tests. I think it's > easier > > > to track and review with in a separate changelist, if you > don't > > > mind. > > > > And the new tests are about to benefit the new signature of the > utility function, resulting in less lines of the code. > > If you don't need this yet, I'd rather prioritize reviewing other > stuff until we need this if that's alright Sure, it's not a priority, just a small clean-up. -- To view, visit http://gerrit.cloudera.org:8080/8671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id665f2f54b2642ae62f0bae96ec8f0e4871630cc Gerrit-Change-Number: 8671 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 29 Nov 2017 01:28:33 + Gerrit-HasComments: No
[kudu-CR] [cluster itest util] update WaitForReplicasReportedToMaster
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8671 ) Change subject: [cluster_itest_util] update WaitForReplicasReportedToMaster .. Patch Set 1: > Patch Set 1: > > > > squash this into a test that needs it? > > > > This is not exactly a requirement for particular test, it's more a > > convenience update for already existing tests. I think it's easier > > to track and review with in a separate changelist, if you don't > > mind. > > And the new tests are about to benefit the new signature of the utility > function, resulting in less lines of the code. If you don't need this yet, I'd rather prioritize reviewing other stuff until we need this if that's alright -- To view, visit http://gerrit.cloudera.org:8080/8671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id665f2f54b2642ae62f0bae96ec8f0e4871630cc Gerrit-Change-Number: 8671 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 29 Nov 2017 01:22:24 + Gerrit-HasComments: No
[kudu-CR] [cluster itest util] update WaitForReplicasReportedToMaster
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8671 ) Change subject: [cluster_itest_util] update WaitForReplicasReportedToMaster .. Patch Set 1: > > squash this into a test that needs it? > > This is not exactly a requirement for particular test, it's more a > convenience update for already existing tests. I think it's easier > to track and review with in a separate changelist, if you don't > mind. And the new tests are about to benefit the new signature of the utility function, resulting in less lines of the code. -- To view, visit http://gerrit.cloudera.org:8080/8671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id665f2f54b2642ae62f0bae96ec8f0e4871630cc Gerrit-Change-Number: 8671 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 29 Nov 2017 01:21:03 + Gerrit-HasComments: No
[kudu-CR] [cluster itest util] update WaitForReplicasReportedToMaster
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8671 ) Change subject: [cluster_itest_util] update WaitForReplicasReportedToMaster .. Patch Set 1: > squash this into a test that needs it? This is not exactly a requirement for particular test, it's more a convenience update for already existing tests. I think it's easier to track and review with in a separate changelist, if you don't mind. -- To view, visit http://gerrit.cloudera.org:8080/8671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id665f2f54b2642ae62f0bae96ec8f0e4871630cc Gerrit-Change-Number: 8671 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 29 Nov 2017 01:20:14 + Gerrit-HasComments: No
[kudu-CR] [cluster itest util] update WaitForReplicasReportedToMaster
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8671 ) Change subject: [cluster_itest_util] update WaitForReplicasReportedToMaster .. Patch Set 1: squash this into a test that needs it? -- To view, visit http://gerrit.cloudera.org:8080/8671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id665f2f54b2642ae62f0bae96ec8f0e4871630cc Gerrit-Change-Number: 8671 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 29 Nov 2017 01:12:04 + Gerrit-HasComments: No
[kudu-CR] [cluster itest util] update WaitForReplicasReportedToMaster
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8671 Change subject: [cluster_itest_util] update WaitForReplicasReportedToMaster .. [cluster_itest_util] update WaitForReplicasReportedToMaster Updated signature of the itest::WaitForReplicasReportedToMaster utility function to make the tablet locations and has_leader output parameters optional. This benefits tests which are only interested in the total count of tablet replicas regardless of their locations. Change-Id: Id665f2f54b2642ae62f0bae96ec8f0e4871630cc --- M src/kudu/integration-tests/cluster_itest_util.cc M src/kudu/integration-tests/cluster_itest_util.h M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc M src/kudu/tools/kudu-admin-test.cc 5 files changed, 56 insertions(+), 113 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/8671/1 -- To view, visit http://gerrit.cloudera.org:8080/8671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id665f2f54b2642ae62f0bae96ec8f0e4871630cc Gerrit-Change-Number: 8671 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
