[kudu-CR] [java] KUDU-2407: Fix leaked protubuf generated class

[Grant Henke (Code Review)]

Grant Henke has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10057 )

Change subject: [java] KUDU-2407: Fix leaked protubuf generated class
..

[java] KUDU-2407: Fix leaked protubuf generated class

Change-Id: I5fd93e592133cb15c1b5d6390bf69051355a8907
Reviewed-on: http://gerrit.cloudera.org:8080/10057
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo 
Reviewed-by: Dan Burkert 
---
M java/kudu-client/src/main/java/org/apache/kudu/client/LocatedTablet.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, but someone else must approve
  Dan Burkert: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/10057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5fd93e592133cb15c1b5d6390bf69051355a8907
Gerrit-Change-Number: 10057
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [java] KUDU-2407: Fix leaked protubuf generated class

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10057 )

Change subject: [java] KUDU-2407: Fix leaked protubuf generated class
..


Patch Set 1:

Seems fine to me, this is clearly not an API meant to be publicly consumed.  No 
point in tying ourselves up over a mistake.


--
To view, visit http://gerrit.cloudera.org:8080/10057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fd93e592133cb15c1b5d6390bf69051355a8907
Gerrit-Change-Number: 10057
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 13 Apr 2018 17:35:40 +
Gerrit-HasComments: No

[kudu-CR] [java] KUDU-2407: Fix leaked protubuf generated class

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10057 )

Change subject: [java] KUDU-2407: Fix leaked protubuf generated class
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fd93e592133cb15c1b5d6390bf69051355a8907
Gerrit-Change-Number: 10057
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 13 Apr 2018 17:35:16 +
Gerrit-HasComments: No

[kudu-CR] [java] KUDU-2407: Fix leaked protubuf generated class

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10057 )

Change subject: [java] KUDU-2407: Fix leaked protubuf generated class
..


Patch Set 1: Code-Review+1

> Patch Set 1:
>
> It is and we don't. It was added in 1.5.0 and I can't see a reason anyone 
> would use it. We could just mark it as private with an interface annotation 
> if you think thats better.
>
> I think the risk of leaving it public is potential breakage in the exposed 
> Protobuf generated Role class that we don't have control over.

Ah, I forgot that the entire Replica class is @InterfaceStability.Evolving.

OK, I'm +1. Let's see what others think.


--
To view, visit http://gerrit.cloudera.org:8080/10057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fd93e592133cb15c1b5d6390bf69051355a8907
Gerrit-Change-Number: 10057
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 13 Apr 2018 16:49:28 +
Gerrit-HasComments: No

[kudu-CR] [java] KUDU-2407: Fix leaked protubuf generated class

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10057 )

Change subject: [java] KUDU-2407: Fix leaked protubuf generated class
..


Patch Set 1:

Note: This interface is marked @InterfaceStability.Evolving. Signifying it can 
break compatibility at minor release (i.e. m.x).


--
To view, visit http://gerrit.cloudera.org:8080/10057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fd93e592133cb15c1b5d6390bf69051355a8907
Gerrit-Change-Number: 10057
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 13 Apr 2018 16:44:14 +
Gerrit-HasComments: No

[kudu-CR] [java] KUDU-2407: Fix leaked protubuf generated class

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10057 )

Change subject: [java] KUDU-2407: Fix leaked protubuf generated class
..


Patch Set 1:

It is and we don't. It was added in 1.5.0 and I can't see a reason anyone would 
use it. We could just mark it as private with an interface annotation if you 
think thats better.

I think the risk of leaving it public is potential breakage in the exposed 
Protobuf generated Role class that we don't have control over.


--
To view, visit http://gerrit.cloudera.org:8080/10057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fd93e592133cb15c1b5d6390bf69051355a8907
Gerrit-Change-Number: 10057
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 13 Apr 2018 16:43:12 +
Gerrit-HasComments: No

[kudu-CR] [java] KUDU-2407: Fix leaked protubuf generated class

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10057 )

Change subject: [java] KUDU-2407: Fix leaked protubuf generated class
..


Patch Set 1:

How do we know that it's safe to do this? Technically it's both an ABI and API 
compatibility break, right?


--
To view, visit http://gerrit.cloudera.org:8080/10057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fd93e592133cb15c1b5d6390bf69051355a8907
Gerrit-Change-Number: 10057
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 13 Apr 2018 16:40:22 +
Gerrit-HasComments: No

[kudu-CR] [java] KUDU-2407: Fix leaked protubuf generated class

[Grant Henke (Code Review)]

Grant Henke has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10057


Change subject: [java] KUDU-2407: Fix leaked protubuf generated class
..

[java] KUDU-2407: Fix leaked protubuf generated class

Change-Id: I5fd93e592133cb15c1b5d6390bf69051355a8907
---
M java/kudu-client/src/main/java/org/apache/kudu/client/LocatedTablet.java
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/10057/1
--
To view, visit http://gerrit.cloudera.org:8080/10057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5fd93e592133cb15c1b5d6390bf69051355a8907
Gerrit-Change-Number: 10057
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke