[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: API and style improvements to the Kudu Flume Sink .. Patch Set 3: > > don't forget about RegexpKuduEventProducer, > > which I need to rebase and refactor as Reg

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: API and style improvements to the Kudu Flume Sink .. API and style improvements to the Kudu Flume Sink This patch cleans up the Flume integration code a bi

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: API and style improvements to the Kudu Flume Sink .. Patch Set 3: OK perfect -- To view, visit http://gerrit.cloudera.org:8080/4320 To unsubscribe, visit http://g

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: API and style improvements to the Kudu Flume Sink .. Patch Set 3: Code-Review+2 > don't forget about RegexpKuduEventProducer, > which I need to rebase and refactor

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: API and style improvements to the Kudu Flume Sink .. Patch Set 3: > > Do we also want something in the release notes about the API > change > > + AvroKuduOpera

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: API and style improvements to the Kudu Flume Sink .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3284/ -- To view, visit http://gerrit.clou

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4320 to look at the new patch set (#3). Change subject: API and style improvements to the Kudu Flume Sink .. API and sty

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: API and style improvements to the Kudu Flume Sink .. Patch Set 2: > Do we also want something in the release notes about the API change > + AvroKuduOperationsProdu

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: API and style improvements to the Kudu Flume Sink .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3282/ -- To view, visit http://gerrit.clou

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: API and style improvements to the Kudu Flume Sink .. Patch Set 1: (8 comments) Do we also want something in the release notes about the API change + AvroKuduOp

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-08 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4320 to look at the new patch set (#2). Change subject: API and style improvements to the Kudu Flume Sink .. API and sty

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-07 Thread Ara Ebrahimi (Code Review)
Ara Ebrahimi has posted comments on this change. Change subject: API and style improvements to the Kudu Flume Sink .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4320/1/java/kudu-flume-sink/src/main/java/org/a

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: API and style improvements to the Kudu Flume Sink .. Patch Set 1: I also added Ara to the review in case he has input on this -- To view, visit http://gerrit.clou

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: API and style improvements to the Kudu Flume Sink .. Patch Set 1: (7 comments) Looks like good changes, and if we are going to break the API then we should do it

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-06 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: API and style improvements to the Kudu Flume Sink .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3237/ -- To view, visit http://gerrit.clou

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-06 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/4320 Change subject: API and style improvements to the Kudu Flume Sink .. API and style improvements to the Kudu Flume Sink This patch cleans