[kudu-CR] Expose RPC method info map and various metrics

2018-02-12 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9269 )

Change subject: Expose RPC method info map and various metrics
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bda390ea92cceb0d696767402c978a83b386825
Gerrit-Change-Number: 9269
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Mon, 12 Feb 2018 19:27:30 +
Gerrit-HasComments: No

[kudu-CR] Expose RPC method info map and various metrics

2018-02-12 Thread Todd Lipcon (Code Review) 
Todd Lipcon has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9269 )

Change subject: Expose RPC method info map and various metrics
..

Expose RPC method info map and various metrics

These changes are needed for IMPALA-6269.

Change-Id: I8bda390ea92cceb0d696767402c978a83b386825
Reviewed-on: http://gerrit.cloudera.org:8080/9269
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin 
Reviewed-by: Todd Lipcon 
---
M src/kudu/rpc/acceptor_pool.cc
M src/kudu/rpc/acceptor_pool.h
M src/kudu/rpc/rpc-bench.cc
M src/kudu/rpc/service_if.h
M src/kudu/util/metrics.h
5 files changed, 19 insertions(+), 5 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, but someone else must approve
  Todd Lipcon: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/9269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8bda390ea92cceb0d696767402c978a83b386825
Gerrit-Change-Number: 9269
Gerrit-PatchSet: 5
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Expose RPC method info map and various metrics

2018-02-12 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9269 )

Change subject: Expose RPC method info map and various metrics
..


Patch Set 4: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/9269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bda390ea92cceb0d696767402c978a83b386825
Gerrit-Change-Number: 9269
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Mon, 12 Feb 2018 18:36:18 +
Gerrit-HasComments: No

[kudu-CR] Expose RPC method info map and various metrics

2018-02-11 Thread Lars Volker (Code Review) 
Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9269 )

Change subject: Expose RPC method info map and various metrics
..


Patch Set 4:

(2 comments)

Thanks for the review. Please see PS4.

http://gerrit.cloudera.org:8080/#/c/9269/3/src/kudu/util/metrics.h
File src/kudu/util/metrics.h:

http://gerrit.cloudera.org:8080/#/c/9269/3/src/kudu/util/metrics.h@1098
PS3, Line 1098: histogram()
> nit: maybe, name it histogram() since it's just an accessor?
Done


http://gerrit.cloudera.org:8080/#/c/9269/3/src/kudu/util/metrics.h@1105
PS3, Line 1105:   virtual bool IsUntouched() const override {
> nit: maybe, drop this method and use the newly introduced one in rpc-bench.
Done



--
To view, visit http://gerrit.cloudera.org:8080/9269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bda390ea92cceb0d696767402c978a83b386825
Gerrit-Change-Number: 9269
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Sun, 11 Feb 2018 23:07:39 +
Gerrit-HasComments: Yes

[kudu-CR] Expose RPC method info map and various metrics

2018-02-11 Thread Lars Volker (Code Review) 
Lars Volker has uploaded a new patch set (#4). ( 
http://gerrit.cloudera.org:8080/9269 )

Change subject: Expose RPC method info map and various metrics
..

Expose RPC method info map and various metrics

These changes are needed for IMPALA-6269.

Change-Id: I8bda390ea92cceb0d696767402c978a83b386825
---
M src/kudu/rpc/acceptor_pool.cc
M src/kudu/rpc/acceptor_pool.h
M src/kudu/rpc/rpc-bench.cc
M src/kudu/rpc/service_if.h
M src/kudu/util/metrics.h
5 files changed, 19 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/9269/4
--
To view, visit http://gerrit.cloudera.org:8080/9269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8bda390ea92cceb0d696767402c978a83b386825
Gerrit-Change-Number: 9269
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Expose RPC method info map and various metrics

2018-02-10 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9269 )

Change subject: Expose RPC method info map and various metrics
..


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9269/3/src/kudu/util/metrics.h
File src/kudu/util/metrics.h:

http://gerrit.cloudera.org:8080/#/c/9269/3/src/kudu/util/metrics.h@1098
PS3, Line 1098: GetHistogram
nit: maybe, name it histogram() since it's just an accessor?


http://gerrit.cloudera.org:8080/#/c/9269/3/src/kudu/util/metrics.h@1105
PS3, Line 1105:   const HdrHistogram* histogram_for_tests() const { return 
histogram_.get(); }
nit: maybe, drop this method and use the newly introduced one in rpc-bench.cc?



--
To view, visit http://gerrit.cloudera.org:8080/9269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bda390ea92cceb0d696767402c978a83b386825
Gerrit-Change-Number: 9269
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Sun, 11 Feb 2018 07:14:01 +
Gerrit-HasComments: Yes

[kudu-CR] Expose RPC method info map and various metrics

2018-02-10 Thread Lars Volker (Code Review) 
Hello Michael Ho, Kudu Jenkins, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9269

to look at the new patch set (#3).

Change subject: Expose RPC method info map and various metrics
..

Expose RPC method info map and various metrics

These changes are needed for IMPALA-6269.

Change-Id: I8bda390ea92cceb0d696767402c978a83b386825
---
M src/kudu/rpc/acceptor_pool.cc
M src/kudu/rpc/acceptor_pool.h
M src/kudu/rpc/service_if.h
M src/kudu/util/metrics.h
4 files changed, 17 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/9269/3
--
To view, visit http://gerrit.cloudera.org:8080/9269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8bda390ea92cceb0d696767402c978a83b386825
Gerrit-Change-Number: 9269
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Expose RPC method info map and various metrics

2018-02-09 Thread Lars Volker (Code Review) 
Hello Michael Ho, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9269

to look at the new patch set (#2).

Change subject: Expose RPC method info map and various metrics
..

Expose RPC method info map and various metrics

These changes are needed for IMPALA-6269.

Change-Id: I8bda390ea92cceb0d696767402c978a83b386825
---
M src/kudu/rpc/acceptor_pool.cc
M src/kudu/rpc/acceptor_pool.h
M src/kudu/rpc/service_if.h
M src/kudu/util/metrics.h
4 files changed, 16 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/9269/2
--
To view, visit http://gerrit.cloudera.org:8080/9269
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8bda390ea92cceb0d696767402c978a83b386825
Gerrit-Change-Number: 9269
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Michael Ho 
Gerrit-Reviewer: Todd Lipcon