[kudu-CR] KUDU-1682. Lock contention on table locations cache in Java client
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1682. Lock contention on table locations cache in Java client .. KUDU-1682. Lock contention on table locations cache in Java client Change-Id: I0f6ba8f4fced6f043f7132fd11078044b004ea21 Reviewed-on: http://gerrit.cloudera.org:8080/4706 Reviewed-by: Adar Dembo Reviewed-by: Dan Burkert Tested-by: Kudu Jenkins --- M java/kudu-client/src/main/java/org/apache/kudu/client/TableLocationsCache.java 1 file changed, 23 insertions(+), 6 deletions(-) Approvals: Dan Burkert: Looks good to me, but someone else must approve Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4706 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f6ba8f4fced6f043f7132fd11078044b004ea21 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1682. Lock contention on table locations cache in Java client
Dan Burkert has posted comments on this change. Change subject: KUDU-1682. Lock contention on table locations cache in Java client .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4706/1/java/kudu-client/src/main/java/org/apache/kudu/client/TableLocationsCache.java File java/kudu-client/src/main/java/org/apache/kudu/client/TableLocationsCache.java: Line 58: rwl.readLock().lock(); > I don't suppose synchronized(rwl.readLock()) would work? The try/finally is It will compile, but it has different (wrong) semantics. -- To view, visit http://gerrit.cloudera.org:8080/4706 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f6ba8f4fced6f043f7132fd11078044b004ea21 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] KUDU-1682. Lock contention on table locations cache in Java client
Adar Dembo has posted comments on this change. Change subject: KUDU-1682. Lock contention on table locations cache in Java client .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4706/1/java/kudu-client/src/main/java/org/apache/kudu/client/TableLocationsCache.java File java/kudu-client/src/main/java/org/apache/kudu/client/TableLocationsCache.java: Line 58: rwl.readLock().lock(); I don't suppose synchronized(rwl.readLock()) would work? The try/finally is a lot of noise. -- To view, visit http://gerrit.cloudera.org:8080/4706 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f6ba8f4fced6f043f7132fd11078044b004ea21 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] KUDU-1682. Lock contention on table locations cache in Java client
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/4706 Change subject: KUDU-1682. Lock contention on table locations cache in Java client .. KUDU-1682. Lock contention on table locations cache in Java client Change-Id: I0f6ba8f4fced6f043f7132fd11078044b004ea21 --- M java/kudu-client/src/main/java/org/apache/kudu/client/TableLocationsCache.java 1 file changed, 23 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/4706/1 -- To view, visit http://gerrit.cloudera.org:8080/4706 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0f6ba8f4fced6f043f7132fd11078044b004ea21 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans
