[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Adar Dembo (Code Review)]

Adar Dembo has submitted this change and it was merged.

Change subject: KUDU-2066. Add experimental Gradle build support
..


KUDU-2066. Add experimental Gradle build support

Adds an experimental Gradle build that results in similar
tasks and artifacts as the existing maven build. See the
readme for usage and common commands.

The build is broken out by module with common configurations
in the root build.gradle file. Additionally the gradle
directory contains “drop in” scripts containing functional
pieces of the build configuration to simplify sharing
configurations and the unclutter the main build files.

Includes support for:
- Shaded dependencies that can be used across modules
- Running unit tests before integration tests
- Reporting available dependency updates
- Protobuf and Avro code generation
- Publishing to remote and local maven repositories
- Cross compiling scala
- Code quality checks (checkstyle, findbugs, pmd)

Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Reviewed-on: http://gerrit.cloudera.org:8080/7258
Reviewed-by: Adar Dembo 
Tested-by: Kudu Jenkins
---
M build-support/release/rat_exclude_files.txt
M java/.gitignore
M java/README.md
A java/build.gradle
A java/gradle.properties
A java/gradle/artifacts.gradle
A java/gradle/buildscript.gradle
A java/gradle/compile.gradle
A java/gradle/dependencies.gradle
A java/gradle/properties.gradle
A java/gradle/protobuf.gradle
A java/gradle/publishing.gradle
A java/gradle/quality.gradle
A java/gradle/scopes.gradle
A java/gradle/shadow.gradle
A java/gradle/tests.gradle
A java/gradle/wrapper.gradle
A java/gradle/wrapper/gradle-wrapper.properties
A java/gradlew
A java/kudu-client-tools/build.gradle
A java/kudu-client/build.gradle
A java/kudu-flume-sink/build.gradle
M 
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducer.java
M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/KuduSink.java
M 
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/SimpleKeyedKuduOperationsProducer.java
M 
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/SimpleKuduOperationsProducer.java
A java/kudu-jepsen/build.gradle
A java/kudu-mapreduce/build.gradle
A java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
R 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
A java/kudu-spark/build.gradle
M java/kudu-spark/pom.xml
A java/settings.gradle
34 files changed, 1,453 insertions(+), 6 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 19
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: KUDU-2066. Add experimental Gradle build support
..


Patch Set 18: Code-Review+2

Thanks for addressing all of my concerns. We can decide whether or not to shade 
kudu-mapreduce later.

-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 18
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Hello Dan Burkert, Todd Lipcon, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7258

to look at the new patch set (#18).

Change subject: KUDU-2066. Add experimental Gradle build support
..

KUDU-2066. Add experimental Gradle build support

Adds an experimental Gradle build that results in similar
tasks and artifacts as the existing maven build. See the
readme for usage and common commands.

The build is broken out by module with common configurations
in the root build.gradle file. Additionally the gradle
directory contains “drop in” scripts containing functional
pieces of the build configuration to simplify sharing
configurations and the unclutter the main build files.

Includes support for:
- Shaded dependencies that can be used across modules
- Running unit tests before integration tests
- Reporting available dependency updates
- Protobuf and Avro code generation
- Publishing to remote and local maven repositories
- Cross compiling scala
- Code quality checks (checkstyle, findbugs, pmd)

Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
---
M build-support/release/rat_exclude_files.txt
M java/.gitignore
M java/README.md
A java/build.gradle
A java/gradle.properties
A java/gradle/artifacts.gradle
A java/gradle/buildscript.gradle
A java/gradle/compile.gradle
A java/gradle/dependencies.gradle
A java/gradle/properties.gradle
A java/gradle/protobuf.gradle
A java/gradle/publishing.gradle
A java/gradle/quality.gradle
A java/gradle/scopes.gradle
A java/gradle/shadow.gradle
A java/gradle/tests.gradle
A java/gradle/wrapper.gradle
A java/gradle/wrapper/gradle-wrapper.properties
A java/gradlew
A java/kudu-client-tools/build.gradle
A java/kudu-client/build.gradle
A java/kudu-flume-sink/build.gradle
M 
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducer.java
M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/KuduSink.java
M 
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/SimpleKeyedKuduOperationsProducer.java
M 
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/SimpleKuduOperationsProducer.java
A java/kudu-jepsen/build.gradle
A java/kudu-mapreduce/build.gradle
A java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
R 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
A java/kudu-spark/build.gradle
M java/kudu-spark/pom.xml
A java/settings.gradle
34 files changed, 1,453 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/7258/18
-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 18
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change.

Change subject: KUDU-2066. Add experimental Gradle build support
..


Patch Set 17:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7258/17/java/build.gradle
File java/build.gradle:

Line 19: // common logic for the various subprojects in the build. 
> Got trailing whitespace here.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 17
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: KUDU-2066. Add experimental Gradle build support
..


Patch Set 14:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7258/17/java/build.gradle
File java/build.gradle:

Line 19: buildscript { apply from: file('gradle/buildscript.gradle'), to: 
buildscript }
Got trailing whitespace here.


http://gerrit.cloudera.org:8080/#/c/7258/14/java/gradle/dependencies.gradle
File java/gradle/dependencies.gradle:

Line 60: versions["scalaBase"] = versions.scala.substring(0, 
versions.scala.lastIndexOf("."))
> Oh sorry meant to respond. If the Scala version doesn't match this expected
Sure.


-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 14
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change.

Change subject: KUDU-2066. Add experimental Gradle build support
..


Patch Set 14:

(10 comments)

http://gerrit.cloudera.org:8080/#/c/7258/14/java/gradle/compile.gradle
File java/gradle/compile.gradle:

Line 24: options.fork = true // enable compilation in a separate daemon 
process.
> I didn't mean to suggest it should be removed. I just didn't know whether i
I didn't have a great reason either. So removing it keeps things simple.


Line 31: }
> You'd have to add a Maven profile. See https://stackoverflow.com/a/16743137
After spending more time on this and making the maven profile work. It turns 
out Kudu doesn't have too many errors to overcome like other projects I have 
worked on. I think I will drop this and fix the lint errors. It should make for 
cleaner javadoc in the long run.


http://gerrit.cloudera.org:8080/#/c/7258/14/java/gradle/dependencies.gradle
File java/gradle/dependencies.gradle:

Line 60: versions["scalaBase"] = versions.scala.substring(0, 
versions.scala.lastIndexOf("."))
> Missed this?
Oh sorry meant to respond. If the Scala version doesn't match this expected 
pattern, the build would fail and it would show that the "malformed" version 
couldn't be resolved. Perhaps that is good enough?


http://gerrit.cloudera.org:8080/#/c/7258/16/java/gradle/quality.gradle
File java/gradle/quality.gradle:

Line 22: 
> for
Done


http://gerrit.cloudera.org:8080/#/c/7258/14/java/gradle/wrapper.gradle
File java/gradle/wrapper.gradle:

Line 28:   doLast {
> Could you add a comment explaining that?
Done


http://gerrit.cloudera.org:8080/#/c/7258/16/java/gradle/wrapper.gradle
File java/gradle/wrapper.gradle:

Line 27: task bootstrapWrapper() {
> Single quote was better here.
oopsa little trigger happy on the find and replace.


http://gerrit.cloudera.org:8080/#/c/7258/14/java/kudu-mapreduce/build.gradle
File java/kudu-mapreduce/build.gradle:

Line 17: 
> Hmm, ask Dan?
Will ask.


Line 23:   }
> Nice. Can you add a link to the pull request in each place where you apply 
Done


http://gerrit.cloudera.org:8080/#/c/7258/16/java/kudu-spark/pom.xml
File java/kudu-spark/pom.xml:

Line 108: process-resources
> I didn't see this in the gradle build. Is it built-in to gradle's scala plu
I was playing with the args and left these in. Fixed to match the gradle build 
in compile.gradle. I also added docs for the flags.


http://gerrit.cloudera.org:8080/#/c/7258/16/java/settings.gradle
File java/settings.gradle:

> File-level comment.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 14
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Hello Dan Burkert, Todd Lipcon, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7258

to look at the new patch set (#17).

Change subject: KUDU-2066. Add experimental Gradle build support
..

KUDU-2066. Add experimental Gradle build support

Adds an experimental Gradle build that results in similar
tasks and artifacts as the existing maven build. See the
readme for usage and common commands.

The build is broken out by module with common configurations
in the root build.gradle file. Additionally the gradle
directory contains “drop in” scripts containing functional
pieces of the build configuration to simplify sharing
configurations and the unclutter the main build files.

Includes support for:
- Shaded dependencies that can be used across modules
- Running unit tests before integration tests
- Reporting available dependency updates
- Protobuf and Avro code generation
- Publishing to remote and local maven repositories
- Cross compiling scala
- Code quality checks (checkstyle, findbugs, pmd)

Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
---
M build-support/release/rat_exclude_files.txt
M java/.gitignore
M java/README.md
A java/build.gradle
A java/gradle.properties
A java/gradle/artifacts.gradle
A java/gradle/buildscript.gradle
A java/gradle/compile.gradle
A java/gradle/dependencies.gradle
A java/gradle/properties.gradle
A java/gradle/protobuf.gradle
A java/gradle/publishing.gradle
A java/gradle/quality.gradle
A java/gradle/scopes.gradle
A java/gradle/shadow.gradle
A java/gradle/tests.gradle
A java/gradle/wrapper.gradle
A java/gradle/wrapper/gradle-wrapper.properties
A java/gradlew
A java/kudu-client-tools/build.gradle
A java/kudu-client/build.gradle
A java/kudu-flume-sink/build.gradle
M 
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducer.java
M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/KuduSink.java
M 
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/SimpleKeyedKuduOperationsProducer.java
M 
java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/SimpleKuduOperationsProducer.java
A java/kudu-jepsen/build.gradle
A java/kudu-mapreduce/build.gradle
A java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
R 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
A java/kudu-spark/build.gradle
M java/kudu-spark/pom.xml
A java/settings.gradle
34 files changed, 1,453 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/7258/17
-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 17
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: KUDU-2066. Add experimental Gradle build support
..


Patch Set 16:

(14 comments)

http://gerrit.cloudera.org:8080/#/c/7258/16/java/build.gradle
File java/build.gradle:

File-level comment for the purpose of this file ("This is the entry-point for 
the gradle build, yada yada yada")?


http://gerrit.cloudera.org:8080/#/c/7258/16/java/gradle.properties
File java/gradle.properties:

File-level comment here.


http://gerrit.cloudera.org:8080/#/c/7258/14/java/gradle/compile.gradle
File java/gradle/compile.gradle:

Line 24:   options.incremental = true // enable incremental compilation.
> Done
I didn't mean to suggest it should be removed. I just didn't know whether it's 
good or bad; there was no information to help me understand why it's a good 
thing.


Line 31: }
> I am not sure I know how to do this in the maven build. Mainly the ability 
You'd have to add a Maven profile. See https://stackoverflow.com/a/16743137.


http://gerrit.cloudera.org:8080/#/c/7258/14/java/gradle/dependencies.gradle
File java/gradle/dependencies.gradle:

PS14, Line 60: .
> Perhaps add some checking just beforehand to ensure that the scalaVersions 
Missed this?


Line 64: versions["scalaBase"] = versions.scala.substring(0, 
versions.scala.lastIndexOf("."))
> I thought this made the below logic more explicit and readable.
No problem, I can buy that.


http://gerrit.cloudera.org:8080/#/c/7258/16/java/gradle/publishing.gradle
File java/gradle/publishing.gradle:

Line 37:   // To test locally, replace mavenUrl in gradle.properties to 
file://localhost/tmp/myRepo/
Now that mavenUrl uses propertyWithDefault(), is this guidance necessary? I 
think -D or -P is better than modifying gradle.properties.


http://gerrit.cloudera.org:8080/#/c/7258/16/java/gradle/quality.gradle
File java/gradle/quality.gradle:

PS16, Line 22: fro
for


http://gerrit.cloudera.org:8080/#/c/7258/14/java/gradle/wrapper.gradle
File java/gradle/wrapper.gradle:

Line 28: // This allows us to avoid checking in the jar to our repository.
> Otherwise this code is run during project configuration and not when the ta
Could you add a comment explaining that?


http://gerrit.cloudera.org:8080/#/c/7258/16/java/gradle/wrapper.gradle
File java/gradle/wrapper.gradle:

PS16, Line 27: doesn"t
Single quote was better here.


http://gerrit.cloudera.org:8080/#/c/7258/14/java/kudu-mapreduce/build.gradle
File java/kudu-mapreduce/build.gradle:

Line 17: 
> It could be a bug, but in the maven build we don't shade these jars. Happy 
Hmm, ask Dan?


Line 23:   }
> There isn't a super clean way to do this. What I did instead was create a p
Nice. Can you add a link to the pull request in each place where you apply this 
pattern? That way we'll be more likely to notice and remove it once async 
merges the pull request.


http://gerrit.cloudera.org:8080/#/c/7258/16/java/kudu-spark/pom.xml
File java/kudu-spark/pom.xml:

PS16, Line 104: 
  : -unchecked
  : -deprecation
  : -explaintypes
  : 
I didn't see this in the gradle build. Is it built-in to gradle's scala plugin?


http://gerrit.cloudera.org:8080/#/c/7258/16/java/settings.gradle
File java/settings.gradle:

File-level comment.


-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 16
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Hello Dan Burkert, Todd Lipcon, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7258

to look at the new patch set (#15).

Change subject: KUDU-2066. Add experimental Gradle build support
..

KUDU-2066. Add experimental Gradle build support

Adds an experimental Gradle build that results in similar
tasks and artifacts as the existing maven build. See the
readme for usage and common commands.

The build is broken out by module with common configurations
in the root build.gradle file. Additionally the gradle
directory contains “drop in” scripts containing functional
pieces of the build configuration to simplify sharing
configurations and the unclutter the main build files.

Includes support for:
- Shaded dependencies that can be used across modules
- Running unit tests before integration tests
- Reporting available dependency updates
- Protobuf and Avro code generation
- Publishing to remote and local maven repositories
- Cross compiling scala
- Code quality checks (checkstyle, findbugs, pmd)

Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
---
M build-support/release/rat_exclude_files.txt
M java/.gitignore
M java/README.md
A java/build.gradle
A java/gradle.properties
A java/gradle/artifacts.gradle
A java/gradle/buildscript.gradle
A java/gradle/compile.gradle
A java/gradle/dependencies.gradle
A java/gradle/properties.gradle
A java/gradle/protobuf.gradle
A java/gradle/publishing.gradle
A java/gradle/quality.gradle
A java/gradle/scopes.gradle
A java/gradle/shadow.gradle
A java/gradle/tests.gradle
A java/gradle/wrapper.gradle
A java/gradle/wrapper/gradle-wrapper.properties
A java/gradlew
A java/kudu-client-tools/build.gradle
A java/kudu-client/build.gradle
A java/kudu-flume-sink/build.gradle
A java/kudu-jepsen/build.gradle
A java/kudu-mapreduce/build.gradle
A java/kudu-spark-tools/build.gradle
R 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
A java/kudu-spark/build.gradle
M java/kudu-spark/pom.xml
M java/pom.xml
A java/settings.gradle
30 files changed, 1,432 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/7258/15
-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 15
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: KUDU-2066. Add experimental Gradle build support
..


Patch Set 14:

(48 comments)

For the non-generated code, could you add a file level comment to each file 
explaining its use and purpose?

http://gerrit.cloudera.org:8080/#/c/7258/14/build-support/release/rat_exclude_files.txt
File build-support/release/rat_exclude_files.txt:

Line 14: java/gradlew.bat
Isn't this deleted by wrapper.gradle?


http://gerrit.cloudera.org:8080/#/c/7258/14/java/.gitignore
File java/.gitignore:

Line 31: bin
Hmm, what does gradle put in here? I thought all the build output was isolated 
to build/


http://gerrit.cloudera.org:8080/#/c/7258/14/java/build.gradle
File java/build.gradle:

PS14, Line 29:   // Plugins and scripts are applied in the natural "build order"
 :   // they are used to ensure there are no dependency issues
It'd also be good to note that individual subprojects may include other 
gradle/foo.gradle files; these are included here because they apply to _all_ 
subprojects.


http://gerrit.cloudera.org:8080/#/c/7258/14/java/gradle/artifacts.gradle
File java/gradle/artifacts.gradle:

Line 18: task testJar(type: Jar, dependsOn: testClasses, group: "Build") {
Why doesn't this one need extension "jar"?


Line 21:   from sourceSets.test.output
Nit: to be consistent with the other definitions, put this before classifier.


http://gerrit.cloudera.org:8080/#/c/7258/14/java/gradle/buildscript.gradle
File java/gradle/buildscript.gradle:

Line 18: repositories {
If any of these are used for just 1-2 plugins, it'd be good to precede their 
definitions with a comment listing the derived plugins. That way we know how to 
prune this list if/when we were to remove a plugin.


Line 26: // Manage plugin dependencies since the plugin block can't be used in 
included build scripts yet.
Might be good to link to the online docs that can contextualize "yet".


http://gerrit.cloudera.org:8080/#/c/7258/14/java/gradle/compile.gradle
File java/gradle/compile.gradle:

Line 18: // Set compilation settings for the project
Can you beef this up a little? For one, this isn't just one "project", right?


Line 19: allprojects {
Why allprojects and not subprojects?


Line 24: options.fork = true // enable compilation in a separate daemon 
process.
Hmm, why do this?


PS14, Line 26: if (JavaVersion.current().isJava8Compatible()) {
 :   tasks.withType(Javadoc) {
 : // disable the crazy super-strict doclint tool in Java 8
 : options.addStringOption('Xdoclint:none', '-quiet')
 :   }
 : }
This doesn't seem specific to Gradle; should it be ported to the Maven build 
too?


Line 37: scalaCompileOptions.encoding = 'UTF-8' // make sure the encoding 
is utf-8 regardless of system default.
Since this is repeated for the Java configuration, perhaps it should be defined 
in properties.gradle?


Line 38: scalaCompileOptions.additionalParameters = ["-Xlint", "-feature"] 
// turn on compiler warnings for potential mistakes
Maybe this belongs in Maven too?


http://gerrit.cloudera.org:8080/#/c/7258/14/java/gradle/dependencies.gradle
File java/gradle/dependencies.gradle:

Line 28: commonsIo  : "2.5",
Nit: not alphabetically sorted. Check the rest too.


PS14, Line 60: versions.scala.substring(0, versions.scala.lastIndexOf("."))
Perhaps add some checking just beforehand to ensure that the scalaVersions 
property meets this expectation? The default value is obviously fine but it can 
be set by the user to be anything, right?


PS14, Line 63: def spark1Version = '1.6.3'
 : def spark2Version = '2.1.1'
Nit: these are only used once on L65-68; may be clearer to just define them 
inline in the versions["spark"] calls.


Line 81: flumeConfiguration: 
"org.apache.flume:flume-ng-configuration:$versions.flume",
Not alphabetically sorted.


http://gerrit.cloudera.org:8080/#/c/7258/14/java/gradle/properties.gradle
File java/gradle/properties.gradle:

PS14, Line 18: Common
Nit: should be lower-case unless it's referring to something with the proper 
name Common.


http://gerrit.cloudera.org:8080/#/c/7258/14/java/gradle/publishing.gradle
File java/gradle/publishing.gradle:

PS14, Line 26: project.hasProperty
I thought by defining hasProperty inside ext, you wouldn't need to prefix it 
with "project." when referring to it?


Line 35:   // To test locally, replace mavenUrl in gradle.properties to 
file://localhost/tmp/myRepo/
Would it be useful to use propertyWithDefault() so that mavenUrl could be 
specified via -D or -P?


http://gerrit.cloudera.org:8080/#/c/7258/14/java/gradle/quality.gradle
File java/gradle/quality.gradle:

PS14, Line 18: project.apply plugin: 'checkstyle'
 : project.apply plugin: 'findbugs'
 : project.apply plugin: 'pmd'
I think it'd be nice to add a short one-line 

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change.

Change subject: KUDU-2066. Add experimental Gradle build support
..


Patch Set 13:

Pushed a fix to unblock Todds iterative testing. Will follow up for a fix to 
the multibuild support.

-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 13
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Hello Dan Burkert, Todd Lipcon, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7258

to look at the new patch set (#14).

Change subject: KUDU-2066. Add experimental Gradle build support
..

KUDU-2066. Add experimental Gradle build support

Adds an experimental Gradle build that results in similar
tasks and artifacts as the existing maven build. See the
readme for usage and common commands.

The build is broken out by module with common configurations
in the root build.gradle file. Additionally the gradle
directory contains “drop in” scripts containing functional
pieces of the build configuration to simplify sharing
configurations and the unclutter the main build files.

Includes support for:
- Shaded dependencies that can be used across modules
- Running unit tests before integration tests
- Reporting available dependency updates
- Protobuf and Avro code generation
- Publishing to remote and local maven repositories
- Cross compiling scala in a single build command
- Code quality checks (checkstyle, findbugs, pmd)

Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
---
M build-support/release/rat_exclude_files.txt
M java/.gitignore
M java/README.md
A java/build.gradle
A java/gradle.properties
A java/gradle/artifacts.gradle
A java/gradle/buildscript.gradle
A java/gradle/compile.gradle
A java/gradle/dependencies.gradle
A java/gradle/multibuild.gradle
A java/gradle/properties.gradle
A java/gradle/protobuf.gradle
A java/gradle/publishing.gradle
A java/gradle/quality.gradle
A java/gradle/scopes.gradle
A java/gradle/shadow.gradle
A java/gradle/tests.gradle
A java/gradle/wrapper.gradle
A java/gradle/wrapper/gradle-wrapper.properties
A java/gradlew
A java/kudu-client-tools/build.gradle
A java/kudu-client/build.gradle
A java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
A java/kudu-jepsen/build.gradle
M java/kudu-jepsen/pom.xml
A java/kudu-mapreduce/build.gradle
A java/kudu-spark-tools/build.gradle
R 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
A java/kudu-spark/build.gradle
M java/pom.xml
A java/settings.gradle
32 files changed, 1,422 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/7258/14
-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 14
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: KUDU-2066. Add experimental Gradle build support
..


Patch Set 13: Code-Review+1

lgtm as a starting point. seems to be some issue still with running tests in 
kudu-spark-tools but I think it's OK to iterate from here

-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 13
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Hello Dan Burkert, Todd Lipcon, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7258

to look at the new patch set (#13).

Change subject: KUDU-2066. Add experimental Gradle build support
..

KUDU-2066. Add experimental Gradle build support

Adds an experimental Gradle build that results in similar
tasks and artifacts as the existing maven build. See the
readme for usage and common commands.

The build is broken out by module with common configurations
in the root build.gradle file. Additionally the gradle
directory contains “drop in” scripts containing functional
pieces of the build configuration to simplify sharing
configurations and the unclutter the main build files.

Includes support for:
- Shaded dependencies that can be used across modules
- Running unit tests before integration tests
- Reporting available dependency updates
- Protobuf and Avro code generation
- Publishing to remote and local maven repositories
- Cross compiling scala in a single build command
- Code quality checks (checkstyle, findbugs, pmd)

Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
---
M build-support/release/rat_exclude_files.txt
M java/.gitignore
M java/README.md
A java/build.gradle
A java/gradle.properties
A java/gradle/artifacts.gradle
A java/gradle/buildscript.gradle
A java/gradle/compile.gradle
A java/gradle/dependencies.gradle
A java/gradle/multibuild.gradle
A java/gradle/properties.gradle
A java/gradle/protobuf.gradle
A java/gradle/publishing.gradle
A java/gradle/quality.gradle
A java/gradle/scopes.gradle
A java/gradle/shadow.gradle
A java/gradle/tests.gradle
A java/gradle/wrapper.gradle
A java/gradle/wrapper/gradle-wrapper.properties
A java/gradlew
A java/kudu-client-tools/build.gradle
A java/kudu-client/build.gradle
A java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
A java/kudu-jepsen/build.gradle
M java/kudu-jepsen/pom.xml
A java/kudu-mapreduce/build.gradle
A java/kudu-spark-tools/build.gradle
R 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
A java/kudu-spark/build.gradle
M java/pom.xml
A java/settings.gradle
32 files changed, 1,419 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/7258/13
-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 13
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change.

Change subject: KUDU-2066. Add experimental Gradle build support
..


Patch Set 11:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7258/11/java/gradle/wrapper.gradle
File java/gradle/wrapper.gradle:

Line 29: def wrapperJarPath = "gradle/wrapper/gradle-wrapper.jar"
> I think this should be prefixed with APP_HOME. Otherwise gradlew doesn't wo
Good catch. Done.


-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 11
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: KUDU-2066. Add experimental Gradle build support
..


Patch Set 11:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7258/11/java/gradle/wrapper.gradle
File java/gradle/wrapper.gradle:

Line 29: def wrapperJarPath = "gradle/wrapper/gradle-wrapper.jar"
I think this should be prefixed with APP_HOME. Otherwise gradlew doesn't work 
from other cwds


-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 11
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Hello Dan Burkert, Todd Lipcon, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7258

to look at the new patch set (#12).

Change subject: KUDU-2066. Add experimental Gradle build support
..

KUDU-2066. Add experimental Gradle build support

Adds an experimental Gradle build that results in similar
tasks and artifacts as the existing maven build. See the
readme for usage and common commands.

The build is broken out by module with common configurations
in the root build.gradle file. Additionally the gradle
directory contains “drop in” scripts containing functional
pieces of the build configuration to simplify sharing
configurations and the unclutter the main build files.

Includes support for:
- Shaded dependencies that can be used across modules
- Running unit tests before integration tests
- Reporting available dependency updates
- Protobuf and Avro code generation
- Publishing to remote and local maven repositories
- Cross compiling scala in a single build command
- Code quality checks (checkstyle, findbugs, pmd)

Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
---
M build-support/release/rat_exclude_files.txt
M java/.gitignore
M java/README.md
A java/build.gradle
A java/gradle.properties
A java/gradle/artifacts.gradle
A java/gradle/buildscript.gradle
A java/gradle/compile.gradle
A java/gradle/dependencies.gradle
A java/gradle/multibuild.gradle
A java/gradle/properties.gradle
A java/gradle/protobuf.gradle
A java/gradle/publishing.gradle
A java/gradle/quality.gradle
A java/gradle/scopes.gradle
A java/gradle/shadow.gradle
A java/gradle/tests.gradle
A java/gradle/wrapper.gradle
A java/gradle/wrapper/gradle-wrapper.properties
A java/gradlew
A java/kudu-client-tools/build.gradle
A java/kudu-client/build.gradle
A java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
A java/kudu-jepsen/build.gradle
M java/kudu-jepsen/pom.xml
A java/kudu-mapreduce/build.gradle
A java/kudu-spark-tools/build.gradle
R 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
A java/kudu-spark/build.gradle
M java/pom.xml
A java/settings.gradle
32 files changed, 1,419 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/7258/12
-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 12
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: KUDU-2066. Add experimental Gradle build support
..


Patch Set 10: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change.

Change subject: KUDU-2066. Add experimental Gradle build support
..


Patch Set 10:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7258/10/java/gradle/wrapper.gradle
File java/gradle/wrapper.gradle:

Line 1: // Ensure the wrapper script is generated based on the version defined 
in the project
> License header?
Done


http://gerrit.cloudera.org:8080/#/c/7258/10/java/gradlew
File java/gradlew:

Line 1: #!/usr/bin/env sh
> Does this need a copyright/license header?
It's a good question. It's auto-generated by gradle except for a small snippet 
of code that is injected. That small snippet of code comes from wrapper.gradle 
which does have a license header. So I think this falls under the "generated" 
code exception.


Line 69:curl -o gradle/wrapper/gradle-wrapper.jar 
https://raw.githubusercontent.com/gradle/gradle/master/gradle/wrapper/gradle-wrapper.jar
> This should probably point to a specific tag instead of master.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Hello Dan Burkert, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7258

to look at the new patch set (#11).

Change subject: KUDU-2066. Add experimental Gradle build support
..

KUDU-2066. Add experimental Gradle build support

Adds an experimental Gradle build that results in similar
tasks and artifacts as the existing maven build. See the
readme for usage and common commands.

The build is broken out by module with common configurations
in the root build.gradle file. Additionally the gradle
directory contains “drop in” scripts containing functional
pieces of the build configuration to simplify sharing
configurations and the unclutter the main build files.

Includes support for:
- Shaded dependencies that can be used across modules
- Running unit tests before integration tests
- Reporting available dependency updates
- Protobuf and Avro code generation
- Publishing to remote and local maven repositories
- Cross compiling scala in a single build command
- Code quality checks (checkstyle, findbugs, pmd)

Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
---
M build-support/release/rat_exclude_files.txt
M java/.gitignore
M java/README.md
A java/build.gradle
A java/gradle.properties
A java/gradle/artifacts.gradle
A java/gradle/buildscript.gradle
A java/gradle/compile.gradle
A java/gradle/dependencies.gradle
A java/gradle/multibuild.gradle
A java/gradle/properties.gradle
A java/gradle/protobuf.gradle
A java/gradle/publishing.gradle
A java/gradle/quality.gradle
A java/gradle/scopes.gradle
A java/gradle/shadow.gradle
A java/gradle/tests.gradle
A java/gradle/wrapper.gradle
A java/gradle/wrapper/gradle-wrapper.properties
A java/gradlew
A java/kudu-client-tools/build.gradle
A java/kudu-client/build.gradle
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
A java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
A java/kudu-jepsen/build.gradle
M java/kudu-jepsen/pom.xml
A java/kudu-mapreduce/build.gradle
A java/kudu-spark-tools/build.gradle
R 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
A java/kudu-spark/build.gradle
M java/pom.xml
A java/settings.gradle
33 files changed, 1,420 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/7258/11
-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 11
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: KUDU-2066. Add experimental Gradle build support
..


Patch Set 10:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7258/10/java/gradle/wrapper.gradle
File java/gradle/wrapper.gradle:

Line 1: // Ensure the wrapper script is generated based on the version defined 
in the project
License header?


http://gerrit.cloudera.org:8080/#/c/7258/10/java/gradlew
File java/gradlew:

Line 1: #!/usr/bin/env sh
Does this need a copyright/license header?


Line 69:curl -o gradle/wrapper/gradle-wrapper.jar 
https://raw.githubusercontent.com/gradle/gradle/master/gradle/wrapper/gradle-wrapper.jar
This should probably point to a specific tag instead of master.


-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change.

Change subject: KUDU-2066. Add experimental Gradle build support
..


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7258/7/java/gradle/wrapper/gradle-wrapper.jar
File java/gradle/wrapper/gradle-wrapper.jar:

> hrm, then we'd need to change our 'build_source_release.py' script to remov
My latest revision removed this jar and created a workaround to "bootstrap" it 
in the gradlew file if it were missing. Sorry I didn't update this comment.


-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Hello Dan Burkert, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7258

to look at the new patch set (#10).

Change subject: KUDU-2066. Add experimental Gradle build support
..

KUDU-2066. Add experimental Gradle build support

Adds an experimental Gradle build that results in similar
tasks and artifacts as the existing maven build. See the
readme for usage and common commands.

The build is broken out by module with common configurations
in the root build.gradle file. Additionally the gradle
directory contains “drop in” scripts containing functional
pieces of the build configuration to simplify sharing
configurations and the unclutter the main build files.

Includes support for:
- Shaded dependencies that can be used across modules
- Running unit tests before integration tests
- Reporting available dependency updates
- Protobuf and Avro code generation
- Publishing to remote and local maven repositories
- Cross compiling scala in a single build command
- Code quality checks (checkstyle, findbugs, pmd)

Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
---
M build-support/release/rat_exclude_files.txt
M java/.gitignore
M java/README.md
A java/build.gradle
A java/gradle.properties
A java/gradle/artifacts.gradle
A java/gradle/buildscript.gradle
A java/gradle/compile.gradle
A java/gradle/dependencies.gradle
A java/gradle/multibuild.gradle
A java/gradle/properties.gradle
A java/gradle/protobuf.gradle
A java/gradle/publishing.gradle
A java/gradle/quality.gradle
A java/gradle/scopes.gradle
A java/gradle/shadow.gradle
A java/gradle/tests.gradle
A java/gradle/wrapper.gradle
A java/gradle/wrapper/gradle-wrapper.properties
A java/gradlew
A java/kudu-client-tools/build.gradle
A java/kudu-client/build.gradle
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
A java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
A java/kudu-jepsen/build.gradle
M java/kudu-jepsen/pom.xml
A java/kudu-mapreduce/build.gradle
A java/kudu-spark-tools/build.gradle
R 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
A java/kudu-spark/build.gradle
M java/pom.xml
A java/settings.gradle
33 files changed, 1,402 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/7258/10
-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Hello Dan Burkert, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7258

to look at the new patch set (#9).

Change subject: KUDU-2066. Add experimental Gradle build support
..

KUDU-2066. Add experimental Gradle build support

Adds an experimental Gradle build that results in similar
tasks and artifacts as the existing maven build. See the
readme for usage and common commands.

The build is broken out by module with common configurations
in the root build.gradle file. Additionally the gradle
directory contains “drop in” scripts containing functional
pieces of the build configuration to simplify sharing
configurations and the unclutter the main build files.

Includes support for:
- Shaded dependencies that can be used across modules
- Running unit tests before integration tests
- Reporting available dependency updates
- Protobuf and Avro code generation
- Publishing to remote and local maven repositories
- Cross compiling scala in a single build command
- Code quality checks (checkstyle, findbugs, pmd)

Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
---
M build-support/release/rat_exclude_files.txt
M java/.gitignore
M java/README.md
A java/build.gradle
A java/gradle.properties
A java/gradle/artifacts.gradle
A java/gradle/buildscript.gradle
A java/gradle/compile.gradle
A java/gradle/dependencies.gradle
A java/gradle/multibuild.gradle
A java/gradle/properties.gradle
A java/gradle/protobuf.gradle
A java/gradle/publishing.gradle
A java/gradle/quality.gradle
A java/gradle/scopes.gradle
A java/gradle/shadow.gradle
A java/gradle/tests.gradle
A java/gradle/wrapper.gradle
A java/gradle/wrapper/gradle-wrapper.properties
A java/gradlew
A java/kudu-client-tools/build.gradle
A java/kudu-client/build.gradle
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
A java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
A java/kudu-jepsen/build.gradle
M java/kudu-jepsen/pom.xml
A java/kudu-mapreduce/build.gradle
A java/kudu-spark-tools/build.gradle
R 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
A java/kudu-spark/build.gradle
M java/pom.xml
A java/settings.gradle
33 files changed, 1,407 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/7258/9
-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Hello Dan Burkert, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7258

to look at the new patch set (#8).

Change subject: KUDU-2066. Add experimental Gradle build support
..

KUDU-2066. Add experimental Gradle build support

Adds an experimental Gradle build that results in similar
tasks and artifacts as the existing maven build. See the
readme for usage and common commands.

The build is broken out by module with common configurations
in the root build.gradle file. Additionally the gradle
directory contains “drop in” scripts containing functional
pieces of the build configuration to simplify sharing
configurations and the unclutter the main build files.

Includes support for:
- Shaded dependencies that can be used across modules
- Running unit tests before integration tests
- Reporting available dependency updates
- Protobuf and Avro code generation
- Publishing to remote and local maven repositories
- Cross compiling scala in a single build command
- Code quality checks (checkstyle, findbugs, pmd)

Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
---
M build-support/release/rat_exclude_files.txt
M java/.gitignore
M java/README.md
A java/build.gradle
A java/gradle.properties
A java/gradle/artifacts.gradle
A java/gradle/buildscript.gradle
A java/gradle/compile.gradle
A java/gradle/dependencies.gradle
A java/gradle/multibuild.gradle
A java/gradle/properties.gradle
A java/gradle/protobuf.gradle
A java/gradle/publishing.gradle
A java/gradle/quality.gradle
A java/gradle/scopes.gradle
A java/gradle/shadow.gradle
A java/gradle/tests.gradle
A java/gradle/wrapper/gradle-wrapper.jar
A java/gradle/wrapper/gradle-wrapper.properties
A java/gradlew
A java/gradlew.bat
A java/kudu-client-tools/build.gradle
A java/kudu-client/build.gradle
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
A java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
A java/kudu-jepsen/build.gradle
M java/kudu-jepsen/pom.xml
A java/kudu-mapreduce/build.gradle
A java/kudu-spark-tools/build.gradle
R 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
A java/kudu-spark/build.gradle
M java/pom.xml
A java/settings.gradle
34 files changed, 1,442 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/7258/8
-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change.

Change subject: KUDU-2066. Add experimental Gradle build support
..


Patch Set 7:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/7258/7/java/gradle/shadow.gradle
File java/gradle/shadow.gradle:

Line 21: tasks.remove(knows)  // Remove "easter egg" knows task.
> what's this? tried googling but couldn't find it
The person who wrote the gradle shadow plugin added a task that just outputs 
ascii art. I didn't want it cluttering `gradle tasks` output and resulting in 
questions.


Line 49: )
> not understanding this part at all
This plugin assumes you are shading all dependencies. In the kudu-client we 
only shade a few so we need a way to signify that. I added a configuration 
called "compileUnshaded" to track this information, but need to map it back to 
a maven scope for publishing. Otherwise these dependencies would not show up in 
the published maven poms. 

I can definitely add more docs around this and link to issue on the plugin 
tracking improvements so this isn't necessary.


http://gerrit.cloudera.org:8080/#/c/7258/7/java/gradle/wrapper/gradle-wrapper.jar
File java/gradle/wrapper/gradle-wrapper.jar:

> the ASF is against checking in binary jars
My understanding is that this is okay as long as they are not included in 
distributions. The samza project also doing this: 
https://github.com/apache/samza/tree/master/gradle/wrapper

There is some discussion on it on SAMZA-283 too. 

We could consider some other method of downloading this as a sort of "custom 
bootstrap".


http://gerrit.cloudera.org:8080/#/c/7258/7/java/gradlew.bat
File java/gradlew.bat:

Line 1: @if "%DEBUG%" == "" @echo off
> can we add these files to the RAT excludes file?
Done


http://gerrit.cloudera.org:8080/#/c/7258/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java:

Line 35:   @Ignore
> why is this change in here? if you want to disable a test please do it in a
This test is super flaky and failed my build almost all the time. I didn't mean 
to check this in, but its probably something worth fixing.


http://gerrit.cloudera.org:8080/#/c/7258/7/java/kudu-spark/build.gradle
File java/kudu-spark/build.gradle:

Line 40:   } else {
> is it possible to be explicit about == "2" and then give a build error if i
Done


Line 50: } else {
> same
I think the pattern would likely stay the same for any major spark build going 
forward. The only reason this exists is because spark 1 uses "spark" instead of 
"spark1" in the artifact name.


-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: KUDU-2066. Add experimental Gradle build support
..


Patch Set 7:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/7258/7/java/gradle/shadow.gradle
File java/gradle/shadow.gradle:

Line 21: tasks.remove(knows)  // Remove "easter egg" knows task.
what's this? tried googling but couldn't find it


PS7, Line 45: project.conf2ScopeMappings.addMapping(
: MavenPlugin.COMPILE_PRIORITY + 1,
: configurations.compileUnshaded,
: Conf2ScopeMappingContainer.COMPILE
: )
not understanding this part at all


http://gerrit.cloudera.org:8080/#/c/7258/7/java/gradle/wrapper/gradle-wrapper.jar
File java/gradle/wrapper/gradle-wrapper.jar:

the ASF is against checking in binary jars


http://gerrit.cloudera.org:8080/#/c/7258/7/java/gradlew.bat
File java/gradlew.bat:

Line 1: @if "%DEBUG%" == "" @echo off
can we add these files to the RAT excludes file?


http://gerrit.cloudera.org:8080/#/c/7258/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java:

Line 35:   @Ignore
why is this change in here? if you want to disable a test please do it in a 
separate unrelated commit.


http://gerrit.cloudera.org:8080/#/c/7258/7/java/kudu-spark/build.gradle
File java/kudu-spark/build.gradle:

Line 40:   } else {
is it possible to be explicit about == "2" and then give a build error if it is 
anything else?


Line 50: } else {
same


-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7258

to look at the new patch set (#7).

Change subject: KUDU-2066. Add experimental Gradle build support
..

KUDU-2066. Add experimental Gradle build support

Adds an experimental Gradle build that results in similar
tasks and artifacts as the existing maven build. See the
readme for usage and common commands.

The build is broken out by module with common configurations
in the root build.gradle file. Additionally the gradle
directory contains “drop in” scripts containing functional
pieces of the build configuration to simplify sharing
configurations and the unclutter the main build files.

Includes support for:
- Shaded dependencies that can be used across modules
- Running unit tests before integration tests
- Reporting available dependency updates
- Protobuf and Avro code generation
- Publishing to remote and local maven repositories
- Cross compiling scala in a single build command
- Code quality checks (checkstyle, findbugs, pmd)

Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
---
M java/.gitignore
M java/README.md
A java/build.gradle
A java/gradle.properties
A java/gradle/artifacts.gradle
A java/gradle/buildscript.gradle
A java/gradle/compile.gradle
A java/gradle/dependencies.gradle
A java/gradle/multibuild.gradle
A java/gradle/properties.gradle
A java/gradle/protobuf.gradle
A java/gradle/publishing.gradle
A java/gradle/quality.gradle
A java/gradle/scopes.gradle
A java/gradle/shadow.gradle
A java/gradle/tests.gradle
A java/gradle/wrapper/gradle-wrapper.jar
A java/gradle/wrapper/gradle-wrapper.properties
A java/gradlew
A java/gradlew.bat
A java/kudu-client-tools/build.gradle
A java/kudu-client/build.gradle
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
A java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
A java/kudu-jepsen/build.gradle
M java/kudu-jepsen/pom.xml
A java/kudu-mapreduce/build.gradle
A java/kudu-spark-tools/build.gradle
R 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
A java/kudu-spark/build.gradle
M java/pom.xml
A java/settings.gradle
33 files changed, 1,437 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/7258/7
-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7258

to look at the new patch set (#6).

Change subject: KUDU-2066. Add experimental Gradle build support
..

KUDU-2066. Add experimental Gradle build support

Adds an experimental Gradle build that results in similar
tasks and artifacts as the existing maven build. See the
readme for usage and common commands.

The build is broken out by module with common configurations
in the root build.gradle file. Additionally the gradle
directory contains “drop in” scripts containing functional
pieces of the build configuration to simplify sharing
configurations and the unclutter the main build files.

Includes support for:
- Shaded dependencies that can be used across modules
- Running unit tests before integration tests
- Reporting available dependency updates
- Protobuf and Avro code generation
- Publishing to remote and local maven repositories
- Cross compiling scala in a single build command
- Code quality checks (checkstyle, findbugs, pmd)

Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
---
M java/.gitignore
M java/README.md
A java/build.gradle
A java/gradle.properties
A java/gradle/artifacts.gradle
A java/gradle/buildscript.gradle
A java/gradle/compile.gradle
A java/gradle/dependencies.gradle
A java/gradle/multibuild.gradle
A java/gradle/properties.gradle
A java/gradle/protobuf.gradle
A java/gradle/publishing.gradle
A java/gradle/quality.gradle
A java/gradle/scopes.gradle
A java/gradle/shadow.gradle
A java/gradle/tests.gradle
A java/gradle/wrapper/gradle-wrapper.jar
A java/gradle/wrapper/gradle-wrapper.properties
A 
java/gradle/yetus-repo/org/apache/yetus/yetus-project/0.4.0/yetus-project-0.4.0.pom
A java/gradlew
A java/gradlew.bat
A java/kudu-client-tools/build.gradle
A java/kudu-client/build.gradle
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
A java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
A java/kudu-jepsen/build.gradle
M java/kudu-jepsen/pom.xml
A java/kudu-mapreduce/build.gradle
A java/kudu-spark-tools/build.gradle
R 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
A java/kudu-spark/build.gradle
M java/pom.xml
A java/settings.gradle
34 files changed, 1,494 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/7258/6
-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change.

Change subject: KUDU-2066. Add experimental Gradle build support
..


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7258/4/java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala
File 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala:

Line 43: object IntegrationTestBigLinkedList {
> I think we decided this shouldn't be renamed?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7258

to look at the new patch set (#5).

Change subject: KUDU-2066. Add experimental Gradle build support
..

KUDU-2066. Add experimental Gradle build support

Adds an experimental Gradle build that results in similar
tasks and artifacts as the existing maven build. See the
readme for usage and common commands.

The build is broken out by module with common configurations
in the root build.gradle file. Additionally the gradle
directory contains “drop in” scripts containing functional
pieces of the build configuration to simplify sharing
configurations and the unclutter the main build files.

Includes support for:
- Shaded dependencies that can be used across modules
- Running unit tests before integration tests
- Reporting available dependency updates
- Protobuf and Avro code generation
- Publishing to remote and local maven repositories
- Cross compiling scala in a single build command
- Code quality checks (checkstyle, findbugs, pmd)

Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
---
M java/.gitignore
M java/README.md
A java/build.gradle
A java/gradle.properties
A java/gradle/artifacts.gradle
A java/gradle/buildscript.gradle
A java/gradle/compile.gradle
A java/gradle/dependencies.gradle
A java/gradle/multibuild.gradle
A java/gradle/properties.gradle
A java/gradle/protobuf.gradle
A java/gradle/publishing.gradle
A java/gradle/quality.gradle
A java/gradle/scopes.gradle
A java/gradle/shadow.gradle
A java/gradle/tests.gradle
A java/gradle/wrapper/gradle-wrapper.jar
A java/gradle/wrapper/gradle-wrapper.properties
A 
java/gradle/yetus-repo/org/apache/yetus/yetus-project/0.4.0/yetus-project-0.4.0.pom
A java/gradlew
A java/gradlew.bat
A java/kudu-client-tools/build.gradle
A java/kudu-client/build.gradle
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
A java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
A java/kudu-jepsen/build.gradle
M java/kudu-jepsen/pom.xml
A java/kudu-mapreduce/build.gradle
A java/kudu-spark-tools/build.gradle
R 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
A java/kudu-spark/build.gradle
M java/pom.xml
A java/settings.gradle
34 files changed, 1,495 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/7258/5
-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: KUDU-2066. Add experimental Gradle build support
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7258/4/java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala
File 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala:

Line 43: object ITBigLinkedList {
I think we decided this shouldn't be renamed?


-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2066. Add experimental Gradle build support

[Grant Henke (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7258

to look at the new patch set (#4).

Change subject: KUDU-2066. Add experimental Gradle build support
..

KUDU-2066. Add experimental Gradle build support

Adds an experimental Gradle build that results in similar
tasks and artifacts as the existing maven build. See the
readme for usage and common commands.

The build is broken out by module with common configurations
in the root build.gradle file. Additionally the gradle
directory contains “drop in” scripts containing functional
pieces of the build configuration to simplify sharing
configurations and the unclutter the main build files.

Includes support for:
- Shaded dependencies that can be used across modules
- Running unit tests before integration tests
- Reporting available dependency updates
- Protobuf and Avro code generation
- Publishing to remote and local maven repositories
- Cross compiling scala in a single build command
- Code quality checks (checkstyle, findbugs, pmd)

Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
---
M java/README.md
A java/build.gradle
A java/gradle.properties
A java/gradle/artifacts.gradle
A java/gradle/buildscript.gradle
A java/gradle/compile.gradle
A java/gradle/dependencies.gradle
A java/gradle/multibuild.gradle
A java/gradle/properties.gradle
A java/gradle/protobuf.gradle
A java/gradle/publishing.gradle
A java/gradle/quality.gradle
A java/gradle/scopes.gradle
A java/gradle/shadow.gradle
A java/gradle/tests.gradle
A java/gradle/wrapper/gradle-wrapper.jar
A java/gradle/wrapper/gradle-wrapper.properties
A 
java/gradle/yetus-repo/org/apache/yetus/yetus-project/0.4.0/yetus-project-0.4.0.pom
A java/gradlew
A java/gradlew.bat
A java/kudu-client-tools/build.gradle
A java/kudu-client/build.gradle
M java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java
A java/kudu-flume-sink/build.gradle
M java/kudu-flume-sink/pom.xml
A java/kudu-jepsen/build.gradle
M java/kudu-jepsen/pom.xml
A java/kudu-mapreduce/build.gradle
A java/kudu-spark-tools/build.gradle
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala
R 
java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
A java/kudu-spark/build.gradle
M java/pom.xml
A java/settings.gradle
34 files changed, 1,119 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/7258/4
-- 
To view, visit http://gerrit.cloudera.org:8080/7258
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon