[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 12: (6 comments) http://gerrit.cloudera.org:8080/#/c/3076/12/src/kudu/integration-tests/tablet_history_gc-itest.

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/3076/12/src/kudu/integration-tests/tablet_history_gc-itest

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#12). Change subject: KUDU-236. Implement tablet history GC .. KUDU-236.

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 12: Build Started http://104.196.14.100/job/kudu-gerrit/2885/ -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/3076/11/src/kudu/tablet/tablet_history_gc-test.cc File src/k

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 11: Could you also add a GCing thread to mt-tablet-test? It's a good way to test interactions between concurrent

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 11: (1 comment) Just passing through with a question. http://gerrit.cloudera.org:8080/#/c/3076/11/src/kudu/tabl

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 11: Build Started http://104.196.14.100/job/kudu-gerrit/2877/ -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#11). Change subject: KUDU-236. Implement tablet history GC .. KUDU-236. Implement ta

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/3076/6/src/kudu/tablet/compaction.cc File src/kudu/tablet/com

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 10: Build Started http://104.196.14.100/job/kudu-gerrit/2868/ -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-14 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#10). Change subject: KUDU-236. Implement tablet history GC .. KUDU-236.

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 9: Build Started http://104.196.14.100/job/kudu-gerrit/2853/ -- To view, visit http://gerrit.cloudera.org:808

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-12 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#9). Change subject: KUDU-236. Implement tablet history GC .. KUDU-236. Implement tab

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/2850/ -- To view, visit http://gerrit.cloudera.org:808

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-12 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#8). Change subject: KUDU-236. Implement tablet history GC .. KUDU-236. Implement tab

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 6: (11 comments) Posting partially addressed feedback except for 2 comments in compaction.cc and 2 comments in

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-12 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#6). Change subject: KUDU-236. Implement tablet history GC .. KUDU-236. Implement tab

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/3076/7/src/kudu/tablet/compaction.cc File src/kudu/tablet/co

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 6: (14 comments) http://gerrit.cloudera.org:8080/#/c/3076/6/src/kudu/tablet/compaction.cc File src/kudu/tablet/

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236. Implement tablet history GC .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2833/ -- To view, visit http://gerrit.cloudera.org:808

[kudu-CR] KUDU-236. Implement tablet history GC

2016-08-11 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#7). Change subject: KUDU-236. Implement tablet history GC .. KUDU-236. Implement tab