[kudu-CR] KUDU-721: [Spark] Add DECIMAL type support

2018-02-13 Thread Grant Henke (Code Review) 
Grant Henke has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9213 )

Change subject: KUDU-721: [Spark] Add DECIMAL type support
..

KUDU-721: [Spark] Add DECIMAL type support

Adds DECIMAL support to the Kudu Spark source and RDD.

Change-Id: Ia5f7a801778ed81b68949bbf8d7c08d1a13ed840
Reviewed-on: http://gerrit.cloudera.org:8080/9213
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert 
---
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
6 files changed, 84 insertions(+), 25 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Dan Burkert: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/9213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5f7a801778ed81b68949bbf8d7c08d1a13ed840
Gerrit-Change-Number: 9213
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-721: [Spark] Add DECIMAL type support

2018-02-13 Thread Dan Burkert (Code Review) 
Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9213 )

Change subject: KUDU-721: [Spark] Add DECIMAL type support
..


Patch Set 5: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5f7a801778ed81b68949bbf8d7c08d1a13ed840
Gerrit-Change-Number: 9213
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 13 Feb 2018 22:13:48 +
Gerrit-HasComments: No

[kudu-CR] KUDU-721: [Spark] Add DECIMAL type support

2018-02-09 Thread Grant Henke (Code Review) 
Hello Dan Burkert, Kudu Jenkins, Hao Hao,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9213

to look at the new patch set (#4).

Change subject: KUDU-721: [Spark] Add DECIMAL type support
..

KUDU-721: [Spark] Add DECIMAL type support

Adds DECIMAL support to the Kudu Spark source and RDD.

Change-Id: Ia5f7a801778ed81b68949bbf8d7c08d1a13ed840
---
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
6 files changed, 84 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/9213/4
--
To view, visit http://gerrit.cloudera.org:8080/9213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia5f7a801778ed81b68949bbf8d7c08d1a13ed840
Gerrit-Change-Number: 9213
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-721: [Spark] Add DECIMAL type support

2018-02-09 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9213 )

Change subject: KUDU-721: [Spark] Add DECIMAL type support
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9213/2/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
File 
java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala:

http://gerrit.cloudera.org:8080/#/c/9213/2/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@308
PS2, Line 308: _: DecimalType
> Does DecimalType() means we are only matching for the case when precision i
DecimalType() is actually calling unapply(t: DataType) which internally calls 
t.isInstanceOf[DecimalType]. It's effectively the same as _: DecimalType. Meant 
to change it here too. will push the update.



--
To view, visit http://gerrit.cloudera.org:8080/9213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5f7a801778ed81b68949bbf8d7c08d1a13ed840
Gerrit-Change-Number: 9213
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 09 Feb 2018 14:35:36 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-721: [Spark] Add DECIMAL type support

2018-02-09 Thread Hao Hao (Code Review) 
Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9213 )

Change subject: KUDU-721: [Spark] Add DECIMAL type support
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9213/2/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
File 
java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala:

http://gerrit.cloudera.org:8080/#/c/9213/2/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@308
PS2, Line 308: _: DecimalType
> Done
Does DecimalType() means we are only matching for the case when precision is 
10? Why is that? I saw you changed it in the latest patch for L203, why not do 
the same here?



--
To view, visit http://gerrit.cloudera.org:8080/9213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5f7a801778ed81b68949bbf8d7c08d1a13ed840
Gerrit-Change-Number: 9213
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 09 Feb 2018 08:15:50 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-721: [Spark] Add DECIMAL type support

2018-02-07 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9213 )

Change subject: KUDU-721: [Spark] Add DECIMAL type support
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9213/2/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
File 
java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala:

http://gerrit.cloudera.org:8080/#/c/9213/2/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@308
PS2, Line 308: _: DecimalType
> Should be able to do
Done



--
To view, visit http://gerrit.cloudera.org:8080/9213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5f7a801778ed81b68949bbf8d7c08d1a13ed840
Gerrit-Change-Number: 9213
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 07 Feb 2018 23:03:04 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-721: [Spark] Add DECIMAL type support

2018-02-07 Thread Grant Henke (Code Review) 
Hello Dan Burkert, Kudu Jenkins, Hao Hao,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9213

to look at the new patch set (#3).

Change subject: KUDU-721: [Spark] Add DECIMAL type support
..

KUDU-721: [Spark] Add DECIMAL type support

Adds DECIMAL support to the Kudu Spark source and RDD.

Change-Id: Ia5f7a801778ed81b68949bbf8d7c08d1a13ed840
---
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
6 files changed, 84 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/9213/3
--
To view, visit http://gerrit.cloudera.org:8080/9213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia5f7a801778ed81b68949bbf8d7c08d1a13ed840
Gerrit-Change-Number: 9213
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-721: [Spark] Add DECIMAL type support

2018-02-07 Thread Dan Burkert (Code Review) 
Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9213 )

Change subject: KUDU-721: [Spark] Add DECIMAL type support
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9213/2/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
File 
java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala:

http://gerrit.cloudera.org:8080/#/c/9213/2/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala@308
PS2, Line 308: _: DecimalType
Should be able to do

case DecimalType() =>  ...


to make it match better with the other cases.



--
To view, visit http://gerrit.cloudera.org:8080/9213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5f7a801778ed81b68949bbf8d7c08d1a13ed840
Gerrit-Change-Number: 9213
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 07 Feb 2018 20:24:15 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-721: [Spark] Add DECIMAL type support

2018-02-05 Thread Grant Henke (Code Review) 
Grant Henke has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9213


Change subject: KUDU-721: [Spark] Add DECIMAL type support
..

KUDU-721: [Spark] Add DECIMAL type support

Adds DECIMAL support to the Kudu Spark source and RDD.

Change-Id: Ia5f7a801778ed81b68949bbf8d7c08d1a13ed840
---
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
6 files changed, 84 insertions(+), 25 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/9213/1
--
To view, visit http://gerrit.cloudera.org:8080/9213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia5f7a801778ed81b68949bbf8d7c08d1a13ed840
Gerrit-Change-Number: 9213
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke