[kudu-CR] WIP [java client] Support add/remove partition
Dan Burkert has abandoned this change. Change subject: WIP [java client] Support add/remove partition .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/3731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Iba18cbaf87bb738af7f108311ecc5738129ae092 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] WIP [java client] Support add/remove partition
Dan Burkert has posted comments on this change. Change subject: WIP [java client] Support add/remove partition .. Patch Set 2: Just put up https://gerrit.cloudera.org/#/c/3735/. It's meant to be rebased into this one. Definitely still needs more tests, but the existing tests are passing. -- To view, visit http://gerrit.cloudera.org:8080/3731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba18cbaf87bb738af7f108311ecc5738129ae092 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] WIP [java client] Support add/remove partition
Kudu Jenkins has posted comments on this change. Change subject: WIP [java client] Support add/remove partition .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2651/ -- To view, visit http://gerrit.cloudera.org:8080/3731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba18cbaf87bb738af7f108311ecc5738129ae092 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] WIP [java client] Support add/remove partition
Dan Burkert has posted comments on this change. Change subject: WIP [java client] Support add/remove partition .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3731/1/java/kudu-client/src/main/java/org/kududb/client/AlterTableOptions.java File java/kudu-client/src/main/java/org/kududb/client/AlterTableOptions.java: Line 34: private boolean addsRangePartitions = false; In the latest version of the c++ patch this has been simplified to a single flag that's set if either add or drop is happening. The caches get cleared in either case. http://gerrit.cloudera.org:8080/#/c/3731/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java: Line 367: // TODO something about feature flags. if either add/or drop is happening then we need to make sure the RPC sets the ADD_DROP_RANGE_PARTITIONS flag. -- To view, visit http://gerrit.cloudera.org:8080/3731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba18cbaf87bb738af7f108311ecc5738129ae092 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] WIP [java client] Support add/remove partition
Kudu Jenkins has posted comments on this change. Change subject: WIP [java client] Support add/remove partition .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2642/ -- To view, visit http://gerrit.cloudera.org:8080/3731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba18cbaf87bb738af7f108311ecc5738129ae092 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] WIP [java client] Support add/remove partition
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/3731 Change subject: WIP [java client] Support add/remove partition .. WIP [java client] Support add/remove partition Putting up what I have for the Java client since I might have to disappear for a few weeks soon. I tried making it work using the current two caches but it's messy. The non-covered range cache isn't being cleaned up at all. The unit test is rather simple, I didn't look at what the C++ side is doing since I was just poking around. Change-Id: Iba18cbaf87bb738af7f108311ecc5738129ae092 --- M java/kudu-client/src/main/java/org/kududb/client/AlterTableOptions.java M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/kududb/client/NonCoveredRangeCache.java M java/kudu-client/src/main/java/org/kududb/client/Operation.java M java/kudu-client/src/test/java/org/kududb/client/TestKuduTable.java 5 files changed, 232 insertions(+), 33 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/3731/1 -- To view, visit http://gerrit.cloudera.org:8080/3731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iba18cbaf87bb738af7f108311ecc5738129ae092 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans
