[kudu-CR] build: don't name unsharded tests with a shard suffix
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9524 ) Change subject: build: don't name unsharded tests with a shard suffix .. build: don't name unsharded tests with a shard suffix Change-Id: I33611f9766381d367c7a5ac7b09a00f01c48fe74 Reviewed-on: http://gerrit.cloudera.org:8080/9524 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo --- M CMakeLists.txt M build-support/run-test.sh 2 files changed, 12 insertions(+), 3 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/9524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I33611f9766381d367c7a5ac7b09a00f01c48fe74 Gerrit-Change-Number: 9524 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] build: don't name unsharded tests with a shard suffix
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9524 ) Change subject: build: don't name unsharded tests with a shard suffix .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33611f9766381d367c7a5ac7b09a00f01c48fe74 Gerrit-Change-Number: 9524 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Mon, 12 Mar 2018 22:26:30 + Gerrit-HasComments: No
[kudu-CR] build: don't name unsharded tests with a shard suffix
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9524 ) Change subject: build: don't name unsharded tests with a shard suffix .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9524/1/build-support/run-test.sh File build-support/run-test.sh: http://gerrit.cloudera.org:8080/#/c/9524/1/build-support/run-test.sh@68 PS1, Line 68: :?} > yea probably. It seems gtest will fail if you try it: Changed it to an error here -- To view, visit http://gerrit.cloudera.org:8080/9524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33611f9766381d367c7a5ac7b09a00f01c48fe74 Gerrit-Change-Number: 9524 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Mon, 12 Mar 2018 17:59:42 + Gerrit-HasComments: Yes
[kudu-CR] build: don't name unsharded tests with a shard suffix
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9524 to look at the new patch set (#2). Change subject: build: don't name unsharded tests with a shard suffix .. build: don't name unsharded tests with a shard suffix Change-Id: I33611f9766381d367c7a5ac7b09a00f01c48fe74 --- M CMakeLists.txt M build-support/run-test.sh 2 files changed, 12 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/9524/2 -- To view, visit http://gerrit.cloudera.org:8080/9524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I33611f9766381d367c7a5ac7b09a00f01c48fe74 Gerrit-Change-Number: 9524 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] build: don't name unsharded tests with a shard suffix
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9524 ) Change subject: build: don't name unsharded tests with a shard suffix .. Patch Set 1: (1 comment) No need to purge the flaky test DB since we track flakiness on a per-suite level rather than per-shard currently (see http://dist-test.cloudera.org:8080/) http://gerrit.cloudera.org:8080/#/c/9524/1/build-support/run-test.sh File build-support/run-test.sh: http://gerrit.cloudera.org:8080/#/c/9524/1/build-support/run-test.sh@68 PS1, Line 68: :-0 > Under what circumstances would we have more than one shard but GTEST_SHARD_ yea probably. It seems gtest will fail if you try it: todd@todd-laptop:/src/kudu$ GTEST_TOTAL_SHARDS=1 ./build/latest/bin/rpc-test Invalid environment variables: you have GTEST_TOTAL_SHARDS = 1, but have left GTEST_SHARD_INDEX unset. -- To view, visit http://gerrit.cloudera.org:8080/9524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33611f9766381d367c7a5ac7b09a00f01c48fe74 Gerrit-Change-Number: 9524 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 07 Mar 2018 19:26:46 + Gerrit-HasComments: Yes
[kudu-CR] build: don't name unsharded tests with a shard suffix
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9524 ) Change subject: build: don't name unsharded tests with a shard suffix .. Patch Set 1: (1 comment) Thanks. Does it make sense to also purge the flaky test database of "foo.0" entries for tests that were actually unsharded? http://gerrit.cloudera.org:8080/#/c/9524/1/build-support/run-test.sh File build-support/run-test.sh: http://gerrit.cloudera.org:8080/#/c/9524/1/build-support/run-test.sh@68 PS1, Line 68: :-0 Under what circumstances would we have more than one shard but GTEST_SHARD_INDEX is undefined? Seems like an error, no? -- To view, visit http://gerrit.cloudera.org:8080/9524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33611f9766381d367c7a5ac7b09a00f01c48fe74 Gerrit-Change-Number: 9524 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 07 Mar 2018 18:22:50 + Gerrit-HasComments: Yes
[kudu-CR] build: don't name unsharded tests with a shard suffix
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9524 to review the following change. Change subject: build: don't name unsharded tests with a shard suffix .. build: don't name unsharded tests with a shard suffix Change-Id: I33611f9766381d367c7a5ac7b09a00f01c48fe74 --- M CMakeLists.txt M build-support/run-test.sh 2 files changed, 12 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/9524/1 -- To view, visit http://gerrit.cloudera.org:8080/9524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I33611f9766381d367c7a5ac7b09a00f01c48fe74 Gerrit-Change-Number: 9524 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo
