[kudu-CR] improvements to /table

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: improvements to /table
..


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4021/3/src/kudu/server/webui_util.h
File src/kudu/server/webui_util.h:

Line 41: string FriendlyEncodingTypeName(EncodingType enc);
Is this needed?  Could not find the implementation in PS2.

If it's needed, consider returning 'const string&' here.  As I see, the 
EncodingType_Name() returns a const reference to string (i.e. const string&), 
so it would be possible to change the return type accorndingly.  Probably, that 
would require wrap the literals into static strings.


Line 43: string FriendlyCompressionTypeName(CompressionType enc);
Ditto.


-- 
To view, visit http://gerrit.cloudera.org:8080/4021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6724348b1cd199c4d651c1282f1eadb58226bea
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] improvements to /table

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: improvements to /table
..


Patch Set 3:

Build Started http://104.196.14.100/job/kudu-gerrit/2969/

-- 
To view, visit http://gerrit.cloudera.org:8080/4021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6724348b1cd199c4d651c1282f1eadb58226bea
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] improvements to /table

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: improvements to /table
..


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/2967/

-- 
To view, visit http://gerrit.cloudera.org:8080/4021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6724348b1cd199c4d651c1282f1eadb58226bea
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] improvements to /table

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: improvements to /table
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2966/

-- 
To view, visit http://gerrit.cloudera.org:8080/4021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6724348b1cd199c4d651c1282f1eadb58226bea
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] improvements to /table

[Will Berkeley (Code Review)]

Will Berkeley has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4021

Change subject: improvements to /table
..

improvements to /table

This is a bunch of improvements to the /table endpoint:

0. The order of elements has been made more logical. It's now basic
info, then schema, then partition schema, then the tablets table,
then the Impala create table statement, and finally the tasks list.
Every section now has a title.

1. The partition schema section has been reformatted and improved to
show the table's range bounds.

2. The column RaftConfig in the tablets table has been renamed to
Peers.

3. The peers are now sorted so the leader appears at the top of the
list in the Peers column.

4. A rendering issue where the Impala create table's container would
"leak" a little bit of background to a line above and below it has
been fixed.

5. The ALL_CAPS enum names for the encoding and compression types
have been replaced with friendlier, lower-cased names.

See 
https://raw.githubusercontent.com/wdberkeley/kudu-cr/master/table_after_top.png
for a sample of the new look.

Change-Id: Ib6724348b1cd199c4d651c1282f1eadb58226bea
---
M src/kudu/common/partition.cc
M src/kudu/master/master-path-handlers.cc
M src/kudu/server/webui_util.cc
M src/kudu/server/webui_util.h
4 files changed, 99 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/4021/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib6724348b1cd199c4d651c1282f1eadb58226bea
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley