[kudu-CR] remote bootstrap client: mild API changes

2016-08-04 Thread Adar Dembo (Code Review) 
Adar Dembo has submitted this change and it was merged.

Change subject: remote_bootstrap_client: mild API changes
..


remote_bootstrap_client: mild API changes

1. I removed the uuid argument from the constructor; it's always the uuid of
   the FsManager.
2. I made the TabletStatusListener argument to FetchAll() optional. I think
   that was the original intent (because the TabletMetadata OUT parameter in
   Start() is optional), but a CHECK_NOTNULL() got added at some point.
3. I removed the peer uuid argument from Start(). It was only used for
   logging, so I added an equivalent field to the response protocol.

Change-Id: Id7f482d1193a5a46fa51488eab4712c0c4bfceb1
Reviewed-on: http://gerrit.cloudera.org:8080/3811
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon 
---
M src/kudu/integration-tests/remote_bootstrap-itest.cc
M src/kudu/tserver/remote_bootstrap.proto
M src/kudu/tserver/remote_bootstrap_client-test.cc
M src/kudu/tserver/remote_bootstrap_client.cc
M src/kudu/tserver/remote_bootstrap_client.h
M src/kudu/tserver/remote_bootstrap_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
7 files changed, 49 insertions(+), 52 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id7f482d1193a5a46fa51488eab4712c0c4bfceb1
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] remote bootstrap client: mild API changes

2016-08-04 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change.

Change subject: remote_bootstrap_client: mild API changes
..


Patch Set 4: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7f482d1193a5a46fa51488eab4712c0c4bfceb1
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] remote bootstrap client: mild API changes

2016-08-02 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: remote_bootstrap_client: mild API changes
..


Patch Set 4:

Build Started http://104.196.14.100/job/kudu-gerrit/2709/

-- 
To view, visit http://gerrit.cloudera.org:8080/3811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7f482d1193a5a46fa51488eab4712c0c4bfceb1
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] remote bootstrap client: mild API changes

2016-08-02 Thread Adar Dembo (Code Review) 
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3811

to look at the new patch set (#4).

Change subject: remote_bootstrap_client: mild API changes
..

remote_bootstrap_client: mild API changes

1. I removed the uuid argument from the constructor; it's always the uuid of
   the FsManager.
2. I made the TabletStatusListener argument to FetchAll() optional. I think
   that was the original intent (because the TabletMetadata OUT parameter in
   Start() is optional), but a CHECK_NOTNULL() got added at some point.
3. I removed the peer uuid argument from Start(). It was only used for
   logging, so I added an equivalent field to the response protocol.

Change-Id: Id7f482d1193a5a46fa51488eab4712c0c4bfceb1
---
M src/kudu/integration-tests/remote_bootstrap-itest.cc
M src/kudu/tserver/remote_bootstrap.proto
M src/kudu/tserver/remote_bootstrap_client-test.cc
M src/kudu/tserver/remote_bootstrap_client.cc
M src/kudu/tserver/remote_bootstrap_client.h
M src/kudu/tserver/remote_bootstrap_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
7 files changed, 49 insertions(+), 52 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/3811/4
-- 
To view, visit http://gerrit.cloudera.org:8080/3811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id7f482d1193a5a46fa51488eab4712c0c4bfceb1
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] remote bootstrap client: mild API changes

2016-08-02 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change.

Change subject: remote_bootstrap_client: mild API changes
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3811/3//COMMIT_MSG
Commit Message:

Line 15:logging, so I added an equivalent field to the response protocol.
> Can I just drop the peer uuid argument altogether then? It's only used for 
hrm.. ok, now I see your point. guess I'm OK with the slightly-ugly RPC change 
then


-- 
To view, visit http://gerrit.cloudera.org:8080/3811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7f482d1193a5a46fa51488eab4712c0c4bfceb1
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] remote bootstrap client: mild API changes

2016-08-02 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change.

Change subject: remote_bootstrap_client: mild API changes
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3811/3//COMMIT_MSG
Commit Message:

Line 15:logging, so I added an equivalent field to the response protocol.
> I'm not super keen on changing the RPC protocol to avoid the extra paramete
Can I just drop the peer uuid argument altogether then? It's only used for 
logging.

If not dropped, a user who wants to remote bootstrap from the command line 
needs to provide it...just so it'll appear in some log messages.


-- 
To view, visit http://gerrit.cloudera.org:8080/3811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7f482d1193a5a46fa51488eab4712c0c4bfceb1
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] remote bootstrap client: mild API changes

2016-08-02 Thread Adar Dembo (Code Review) 
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3811

to look at the new patch set (#3).

Change subject: remote_bootstrap_client: mild API changes
..

remote_bootstrap_client: mild API changes

1. I removed the uuid argument from the constructor; it's always the uuid of
   the FsManager.
2. I made the TabletStatusListener argument to FetchAll() optional. I think
   that was the original intent (because the TabletMetadata OUT parameter in
   Start() is optional), but a CHECK_NOTNULL() got added at some point.
3. I removed the peer uuid argument from Start(). It was only used for
   logging, so I added an equivalent field to the response protocol.

Change-Id: Id7f482d1193a5a46fa51488eab4712c0c4bfceb1
---
M src/kudu/integration-tests/remote_bootstrap-itest.cc
M src/kudu/tserver/remote_bootstrap.proto
M src/kudu/tserver/remote_bootstrap_client-test.cc
M src/kudu/tserver/remote_bootstrap_client.cc
M src/kudu/tserver/remote_bootstrap_client.h
M src/kudu/tserver/remote_bootstrap_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
7 files changed, 48 insertions(+), 52 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/3811/3
-- 
To view, visit http://gerrit.cloudera.org:8080/3811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id7f482d1193a5a46fa51488eab4712c0c4bfceb1
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy

[kudu-CR] remote bootstrap client: mild API changes

2016-08-02 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: remote_bootstrap_client: mild API changes
..


Patch Set 3:

Build Started http://104.196.14.100/job/kudu-gerrit/2702/

-- 
To view, visit http://gerrit.cloudera.org:8080/3811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7f482d1193a5a46fa51488eab4712c0c4bfceb1
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] remote bootstrap client: mild API changes

2016-07-28 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: remote_bootstrap_client: mild API changes
..


Patch Set 2: -Verified

Build Started http://104.196.14.100/job/kudu-gerrit/2684/

-- 
To view, visit http://gerrit.cloudera.org:8080/3811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7f482d1193a5a46fa51488eab4712c0c4bfceb1
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] remote bootstrap client: mild API changes

2016-07-28 Thread Adar Dembo (Code Review) 
Adar Dembo has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3811

Change subject: remote_bootstrap_client: mild API changes
..

remote_bootstrap_client: mild API changes

1. I removed the uuid argument from the constructor; it's always the uuid of
   the FsManager.
2. I made the TabletStatusListener argument to FetchAll() optional. I think
   that was the original intent (because the TabletMetadata OUT parameter in
   Start() is optional), but a CHECK_NOTNULL() got added at some point.

Change-Id: Id7f482d1193a5a46fa51488eab4712c0c4bfceb1
---
M src/kudu/integration-tests/remote_bootstrap-itest.cc
M src/kudu/tserver/remote_bootstrap_client-test.cc
M src/kudu/tserver/remote_bootstrap_client.cc
M src/kudu/tserver/remote_bootstrap_client.h
M src/kudu/tserver/ts_tablet_manager.cc
5 files changed, 30 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/3811/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7f482d1193a5a46fa51488eab4712c0c4bfceb1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo