[kudu-CR] tool: port ts-cli

[Todd Lipcon (Code Review)]

Todd Lipcon has submitted this change and it was merged.

Change subject: tool: port ts-cli
..


tool: port ts-cli

I chose to expose common server functionality in new 'master' and 'tserver'
modes rather than consolidating them into a shared 'server' mode; I found
this to be more more intuitive.

I also snuck in a change to ksck to use FLAGS_timeout_ms for RPC timeouts
in client-based operations.

Change-Id: Ifb5a59fd690c2dd09e4e76858469d81f9d501371
Reviewed-on: http://gerrit.cloudera.org:8080/4373
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon 
---
M build-support/dist_test.py
M docs/release_notes.adoc
M src/kudu/client/scan_batch.h
M src/kudu/client/schema.h
M src/kudu/tablet/tablet_peer.h
M src/kudu/tools/CMakeLists.txt
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/kudu-ts-cli-test.cc
M src/kudu/tools/tool_action.h
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_common.h
A src/kudu/tools/tool_action_master.cc
A src/kudu/tools/tool_action_remote_replica.cc
M src/kudu/tools/tool_action_tablet.cc
A src/kudu/tools/tool_action_tserver.cc
M src/kudu/tools/tool_main.cc
D src/kudu/tools/ts-cli.cc
18 files changed, 758 insertions(+), 522 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4373
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb5a59fd690c2dd09e4e76858469d81f9d501371
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] tool: port ts-cli

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: tool: port ts-cli
..


Patch Set 5:

Just rebased

-- 
To view, visit http://gerrit.cloudera.org:8080/4373
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb5a59fd690c2dd09e4e76858469d81f9d501371
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] tool: port ts-cli

[Todd Lipcon (Code Review)]

Hello Dinesh Bhat, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4373

to look at the new patch set (#5).

Change subject: tool: port ts-cli
..

tool: port ts-cli

I chose to expose common server functionality in new 'master' and 'tserver'
modes rather than consolidating them into a shared 'server' mode; I found
this to be more more intuitive.

I also snuck in a change to ksck to use FLAGS_timeout_ms for RPC timeouts
in client-based operations.

Change-Id: Ifb5a59fd690c2dd09e4e76858469d81f9d501371
---
M build-support/dist_test.py
M docs/release_notes.adoc
M src/kudu/client/scan_batch.h
M src/kudu/client/schema.h
M src/kudu/tablet/tablet_peer.h
M src/kudu/tools/CMakeLists.txt
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/kudu-ts-cli-test.cc
M src/kudu/tools/tool_action.h
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_common.h
A src/kudu/tools/tool_action_master.cc
A src/kudu/tools/tool_action_remote_replica.cc
M src/kudu/tools/tool_action_tablet.cc
A src/kudu/tools/tool_action_tserver.cc
M src/kudu/tools/tool_main.cc
D src/kudu/tools/ts-cli.cc
18 files changed, 758 insertions(+), 522 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/4373/5
-- 
To view, visit http://gerrit.cloudera.org:8080/4373
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb5a59fd690c2dd09e4e76858469d81f9d501371
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] tool: port ts-cli

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: tool: port ts-cli
..


Patch Set 4: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4373
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb5a59fd690c2dd09e4e76858469d81f9d501371
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] tool: port ts-cli

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: tool: port ts-cli
..


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4373/3/src/kudu/tools/ksck_remote.cc
File src/kudu/tools/ksck_remote.cc:

Line 265:   builder.default_rpc_timeout(GetDefaultTimeout());
> is this worth mentioning in commit-message or just a cleanup ?
I'll add a note to the commit message.


http://gerrit.cloudera.org:8080/#/c/4373/3/src/kudu/tools/tool_action_tserver.cc
File src/kudu/tools/tool_action_tserver.cc:

PS3, Line 69: Change a gflag value on a Kudu Tablet Server
> Extending this with an example flag could be useful.
I'm going to punt on this for now. We don't use examples in other actions, and 
this is already far better documentation than what existed before in ts-cli.


http://gerrit.cloudera.org:8080/#/c/4373/3/src/kudu/tools/tool_main.cc
File src/kudu/tools/tool_main.cc:

Line 117: .AddMode(BuildMasterMode())
> We could have made 'tablet' as a sub-mode of this actually given that the c
I too prefer deeper nesting, but others (Todd, Dan) have expressed a preference 
for more top-level modes and less nesting. So we'll need to reach some sort of 
consensus; for now we'll be a bit top-heavy.


-- 
To view, visit http://gerrit.cloudera.org:8080/4373
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb5a59fd690c2dd09e4e76858469d81f9d501371
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] tool: port ts-cli

[Adar Dembo (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4373

to look at the new patch set (#4).

Change subject: tool: port ts-cli
..

tool: port ts-cli

I chose to expose common server functionality in new 'master' and 'tserver'
modes rather than consolidating them into a shared 'server' mode; I found
this to be more more intuitive.

I also snuck in a change to ksck to use FLAGS_timeout_ms for RPC timeouts
in client-based operations.

Change-Id: Ifb5a59fd690c2dd09e4e76858469d81f9d501371
---
M build-support/dist_test.py
M docs/release_notes.adoc
M src/kudu/client/scan_batch.h
M src/kudu/client/schema.h
M src/kudu/tablet/tablet_peer.h
M src/kudu/tools/CMakeLists.txt
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/kudu-ts-cli-test.cc
M src/kudu/tools/tool_action.h
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_common.h
A src/kudu/tools/tool_action_master.cc
A src/kudu/tools/tool_action_remote_replica.cc
M src/kudu/tools/tool_action_tablet.cc
A src/kudu/tools/tool_action_tserver.cc
M src/kudu/tools/tool_main.cc
D src/kudu/tools/ts-cli.cc
18 files changed, 758 insertions(+), 522 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/4373/4
-- 
To view, visit http://gerrit.cloudera.org:8080/4373
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb5a59fd690c2dd09e4e76858469d81f9d501371
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] tool: port ts-cli

[Dinesh Bhat (Code Review)]

Dinesh Bhat has posted comments on this change.

Change subject: tool: port ts-cli
..


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4373/3/src/kudu/tools/ksck_remote.cc
File src/kudu/tools/ksck_remote.cc:

Line 265:   builder.default_rpc_timeout(GetDefaultTimeout());
is this worth mentioning in commit-message or just a cleanup ?


http://gerrit.cloudera.org:8080/#/c/4373/3/src/kudu/tools/tool_action_tserver.cc
File src/kudu/tools/tool_action_tserver.cc:

PS3, Line 69: Change a gflag value on a Kudu Tablet Server
Extending this with an example flag could be useful.


http://gerrit.cloudera.org:8080/#/c/4373/3/src/kudu/tools/tool_main.cc
File src/kudu/tools/tool_main.cc:

Line 117: .AddMode(BuildMasterMode())
We could have made 'tablet' as a sub-mode of this actually given that the 
consensus config change takes master_addresses. Something like 'kudu master 
change_config '. I think we can tackle this later, but I am somewhat 
not so fan of intro'ing many top level modes.


-- 
To view, visit http://gerrit.cloudera.org:8080/4373
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb5a59fd690c2dd09e4e76858469d81f9d501371
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] tool: port ts-cli

[Adar Dembo (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4373

to look at the new patch set (#3).

Change subject: tool: port ts-cli
..

tool: port ts-cli

I chose to expose common server functionality in new 'master' and 'tserver'
modes rather than consolidating them into a shared 'server' mode; I found
this to be more more intuitive.

Change-Id: Ifb5a59fd690c2dd09e4e76858469d81f9d501371
---
M build-support/dist_test.py
M docs/release_notes.adoc
M src/kudu/client/scan_batch.h
M src/kudu/client/schema.h
M src/kudu/tablet/tablet_peer.h
M src/kudu/tools/CMakeLists.txt
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/kudu-ts-cli-test.cc
M src/kudu/tools/tool_action.h
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_common.h
A src/kudu/tools/tool_action_master.cc
A src/kudu/tools/tool_action_remote_replica.cc
M src/kudu/tools/tool_action_tablet.cc
A src/kudu/tools/tool_action_tserver.cc
M src/kudu/tools/tool_main.cc
D src/kudu/tools/ts-cli.cc
18 files changed, 758 insertions(+), 522 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/4373/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4373
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb5a59fd690c2dd09e4e76858469d81f9d501371
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] tool: port ts-cli

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: tool: port ts-cli
..


Patch Set 3:

Build Started http://104.196.14.100/job/kudu-gerrit/3367/

-- 
To view, visit http://gerrit.cloudera.org:8080/4373
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb5a59fd690c2dd09e4e76858469d81f9d501371
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] tool: port ts-cli

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: tool: port ts-cli
..


Patch Set 2:

(5 comments)

> (5 comments)
 > 
 > I agree from the user perspective it's nice to expose the generic
 > stuff in both 'master' and 'tserver', but wonder if we could share
 > slightly more code between them. Could you reuse the same 'action'
 > in both places?

I started to implement this, but it got ugly pretty fast:
1. Need an enum to differentiate between the two server types. OK, fine.
2. Need to bind that enum to each function so the function itself knows what 
variant it is (e.g. in order to use the right default port). A little ugly, but 
OK.
3. When building the actions, need to use the enum values to figure out what 
argument names to use, and whether to use "Tablet Server" or "Master" in the 
action and argument descriptions. Er...
4. Need to consider each enum value in each function in order to FindOrDie() 
the argument with the right name (unless we change 'master_address' and 
'tserver_address' to just 'address', but I'm trying to keep it nice for the 
user). Gah, not good.

I didn't mind #1, #2, and #3, but #4 (a switch statement per function) made it 
look too ugly.

So unless you can see a cleaner way to do this, I'd rather leave it as-is.

http://gerrit.cloudera.org:8080/#/c/4373/2/src/kudu/tools/tool_action_common.cc
File src/kudu/tools/tool_action_common.cc:

Line 53: DECLARE_int64(timeout_ms); // defined in ksck
> maybe move to 'common' since it's a "common" flag?
Doing that would break the encapsulation of ksck in that it (as a 
module/library/whatever) would now depend on the CLI tool.

I wasn't quite sure how to handle it, so I went with this quick and dirty hack.


Line 55: DEFINE_bool(force, false, "If true, allows the set_flag command to set 
a flag "
> I foresee a future issue here: I bet we'll have other flags with '--force' 
Yeah. It may make sense to stop using gflags for optional parameters at that 
juncture. We'll see.


Line 213:   MessengerBuilder builder("kudu");
> odd name
Eh, the name doesn't matter. But I'll use 'tool' instead.


Line 214:   RETURN_NOT_OK(builder.Build());
> perhaps just define the builder inline here? MessengerBuilder("tool").Build
Done


http://gerrit.cloudera.org:8080/#/c/4373/2/src/kudu/tools/tool_action_common.h
File src/kudu/tools/tool_action_common.h:

PS2, Line 44: typename T
> I think 'class ProxyClass' would be clearer (I usually only use 'typename' 
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4373
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb5a59fd690c2dd09e4e76858469d81f9d501371
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] tool: port ts-cli

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: tool: port ts-cli
..


Patch Set 2:

(5 comments)

I agree from the user perspective it's nice to expose the generic stuff in both 
'master' and 'tserver', but wonder if we could share slightly more code between 
them. Could you reuse the same 'action' in both places?

http://gerrit.cloudera.org:8080/#/c/4373/2/src/kudu/tools/tool_action_common.cc
File src/kudu/tools/tool_action_common.cc:

Line 53: DECLARE_int64(timeout_ms); // defined in ksck
maybe move to 'common' since it's a "common" flag?


Line 55: DEFINE_bool(force, false, "If true, allows the set_flag command to set 
a flag "
I foresee a future issue here: I bet we'll have other flags with '--force' 
arguments, and we're going to need to have per-subtool overrides of this help 
text. No action here yet but just noticing that our yak is looking a little 
hairy and may need some shaving soon.


Line 213:   MessengerBuilder builder("kudu");
odd name


Line 214:   RETURN_NOT_OK(builder.Build());
perhaps just define the builder inline here? 
MessengerBuilder("tool").Build()


http://gerrit.cloudera.org:8080/#/c/4373/2/src/kudu/tools/tool_action_common.h
File src/kudu/tools/tool_action_common.h:

PS2, Line 44: typename T
I think 'class ProxyClass' would be clearer (I usually only use 'typename' if 
it is expected to plausibly be a primitive)


-- 
To view, visit http://gerrit.cloudera.org:8080/4373
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb5a59fd690c2dd09e4e76858469d81f9d501371
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] tool: port ts-cli

[Adar Dembo (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4373

to look at the new patch set (#2).

Change subject: tool: port ts-cli
..

tool: port ts-cli

I chose to expose common server functionality in new 'master' and 'tserver'
modes rather than consolidating them into a shared 'server' mode; I found
this to be more more intuitive.

Change-Id: Ifb5a59fd690c2dd09e4e76858469d81f9d501371
---
M build-support/dist_test.py
M docs/release_notes.adoc
M src/kudu/client/scan_batch.h
M src/kudu/client/schema.h
M src/kudu/tablet/tablet_peer.h
M src/kudu/tools/CMakeLists.txt
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/kudu-ts-cli-test.cc
M src/kudu/tools/tool_action.h
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_common.h
A src/kudu/tools/tool_action_master.cc
A src/kudu/tools/tool_action_remote_replica.cc
M src/kudu/tools/tool_action_tablet.cc
A src/kudu/tools/tool_action_tserver.cc
M src/kudu/tools/tool_main.cc
D src/kudu/tools/ts-cli.cc
18 files changed, 759 insertions(+), 522 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/4373/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4373
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb5a59fd690c2dd09e4e76858469d81f9d501371
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] tool: port ts-cli

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: tool: port ts-cli
..


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/3354/

-- 
To view, visit http://gerrit.cloudera.org:8080/4373
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb5a59fd690c2dd09e4e76858469d81f9d501371
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] tool: port ts-cli

[Adar Dembo (Code Review)]

Hello Dinesh Bhat, Todd Lipcon,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/4373

to review the following change.

Change subject: tool: port ts-cli
..

tool: port ts-cli

I chose to expose common server functionality in new 'master' and 'tserver'
modes rather than consolidating them into a shared 'server' mode; I found
this to be more more intuitive.

Change-Id: Ifb5a59fd690c2dd09e4e76858469d81f9d501371
---
M docs/release_notes.adoc
M src/kudu/client/scan_batch.h
M src/kudu/client/schema.h
M src/kudu/tablet/tablet_peer.h
M src/kudu/tools/CMakeLists.txt
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/kudu-ts-cli-test.cc
M src/kudu/tools/tool_action.h
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_common.h
A src/kudu/tools/tool_action_master.cc
A src/kudu/tools/tool_action_remote_replica.cc
M src/kudu/tools/tool_action_tablet.cc
A src/kudu/tools/tool_action_tserver.cc
M src/kudu/tools/tool_main.cc
D src/kudu/tools/ts-cli.cc
17 files changed, 759 insertions(+), 521 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/4373/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4373
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb5a59fd690c2dd09e4e76858469d81f9d501371
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Todd Lipcon