[kudu-CR](branch-0.9.x) catalog_manager: move VLOG(1) messages above Async RPC calls to avoid crash
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: catalog_manager: move VLOG(1) messages above Async RPC calls to avoid crash .. catalog_manager: move VLOG(1) messages above Async RPC calls to avoid crash Several functions in this file used a pattern of sending an Async RPC, followed by logging that the RPC had been sent. However, the callback for the async RPC could delete the 'this' instance, which would cause the log message to crash. This only showed up as flakiness in Java unit tests, because they set --v=1 and these messages were VLOG(1). Change-Id: Ic6beaf940fe42a0c7a3aa5877b7ef65136af210b Reviewed-on: http://gerrit.cloudera.org:8080/3181 Reviewed-by: Jean-Daniel Cryans Tested-by: Kudu Jenkins (cherry picked from commit 2a34d81f84529bc307dd494dbc2c952b3256aa65) Reviewed-on: http://gerrit.cloudera.org:8080/3188 --- M src/kudu/master/catalog_manager.cc 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6beaf940fe42a0c7a3aa5877b7ef65136af210b Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: branch-0.9.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](branch-0.9.x) catalog_manager: move VLOG(1) messages above Async RPC calls to avoid crash
Jean-Daniel Cryans has posted comments on this change. Change subject: catalog_manager: move VLOG(1) messages above Async RPC calls to avoid crash .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6beaf940fe42a0c7a3aa5877b7ef65136af210b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.9.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR](branch-0.9.x) catalog_manager: move VLOG(1) messages above Async RPC calls to avoid crash
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3188 Change subject: catalog_manager: move VLOG(1) messages above Async RPC calls to avoid crash .. catalog_manager: move VLOG(1) messages above Async RPC calls to avoid crash Several functions in this file used a pattern of sending an Async RPC, followed by logging that the RPC had been sent. However, the callback for the async RPC could delete the 'this' instance, which would cause the log message to crash. This only showed up as flakiness in Java unit tests, because they set --v=1 and these messages were VLOG(1). Change-Id: Ic6beaf940fe42a0c7a3aa5877b7ef65136af210b Reviewed-on: http://gerrit.cloudera.org:8080/3181 Reviewed-by: Jean-Daniel Cryans Tested-by: Kudu Jenkins (cherry picked from commit 2a34d81f84529bc307dd494dbc2c952b3256aa65) --- M src/kudu/master/catalog_manager.cc 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/3188/1 -- To view, visit http://gerrit.cloudera.org:8080/3188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic6beaf940fe42a0c7a3aa5877b7ef65136af210b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.9.x Gerrit-Owner: Todd Lipcon
