[kudu-CR] [java-client] RPC timeout may sometimes be reported as max attempts violation
Dan Burkert has submitted this change and it was merged. Change subject: [java-client] RPC timeout may sometimes be reported as max attempts violation .. [java-client] RPC timeout may sometimes be reported as max attempts violation Fixes an issue where an RPC timeout could be reported in the error message as too many attempts. Change-Id: I9c5676ab5bd05170505ef0313b919c5475ae6b37 Reviewed-on: http://gerrit.cloudera.org:8080/3330 Tested-by: Kudu Jenkins Reviewed-by: Dan Burkert --- M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c5676ab5bd05170505ef0313b919c5475ae6b37 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java-client] RPC timeout may sometimes be reported as max attempts violation
Dan Burkert has posted comments on this change. Change subject: [java-client] RPC timeout may sometimes be reported as max attempts violation .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c5676ab5bd05170505ef0313b919c5475ae6b37 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [java-client] RPC timeout may sometimes be reported as max attempts violation
Kudu Jenkins has posted comments on this change. Change subject: [java-client] RPC timeout may sometimes be reported as max attempts violation .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/1775/ -- To view, visit http://gerrit.cloudera.org:8080/3330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c5676ab5bd05170505ef0313b919c5475ae6b37 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [java-client] RPC timeout may sometimes be reported as max attempts violation
Kudu Jenkins has posted comments on this change. Change subject: [java-client] RPC timeout may sometimes be reported as max attempts violation .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/1768/ -- To view, visit http://gerrit.cloudera.org:8080/3330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c5676ab5bd05170505ef0313b919c5475ae6b37 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [java-client] RPC timeout may sometimes be reported as max attempts violation
Kudu Jenkins has posted comments on this change. Change subject: [java-client] RPC timeout may sometimes be reported as max attempts violation .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/1771/ -- To view, visit http://gerrit.cloudera.org:8080/3330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c5676ab5bd05170505ef0313b919c5475ae6b37 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [java-client] RPC timeout may sometimes be reported as max attempts violation
Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] RPC timeout may sometimes be reported as max attempts violation .. Patch Set 3: > Why do we even bother limiting the number of attempts? The C++ > client doesn't do this; what does it buy us here? I've caught quite a few runaway retries that way. Right now if you end up with a tight loop somewhere (like when using multi-master) you can have RPCs spinning forever... unless there's something to block them. -- To view, visit http://gerrit.cloudera.org:8080/3330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c5676ab5bd05170505ef0313b919c5475ae6b37 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [java-client] RPC timeout may sometimes be reported as max attempts violation
Adar Dembo has posted comments on this change. Change subject: [java-client] RPC timeout may sometimes be reported as max attempts violation .. Patch Set 3: Why do we even bother limiting the number of attempts? The C++ client doesn't do this; what does it buy us here? -- To view, visit http://gerrit.cloudera.org:8080/3330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c5676ab5bd05170505ef0313b919c5475ae6b37 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [java-client] RPC timeout may sometimes be reported as max attempts violation
Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] RPC timeout may sometimes be reported as max attempts violation .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c5676ab5bd05170505ef0313b919c5475ae6b37 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [java-client] RPC timeout may sometimes be reported as max attempts violation
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3330 to look at the new patch set (#3). Change subject: [java-client] RPC timeout may sometimes be reported as max attempts violation .. [java-client] RPC timeout may sometimes be reported as max attempts violation Fixes an issue where an RPC timeout could be reported in the error message as too many attempts. Change-Id: I9c5676ab5bd05170505ef0313b919c5475ae6b37 --- M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/3330/3 -- To view, visit http://gerrit.cloudera.org:8080/3330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9c5676ab5bd05170505ef0313b919c5475ae6b37 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java-client] RPC timeout may sometimes be reported as max attempts violation
Kudu Jenkins has posted comments on this change. Change subject: [java-client] RPC timeout may sometimes be reported as max attempts violation .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/1766/ -- To view, visit http://gerrit.cloudera.org:8080/3330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c5676ab5bd05170505ef0313b919c5475ae6b37 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [java-client] RPC timeout may sometimes be reported as max attempts violation
Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] RPC timeout may sometimes be reported as max attempts violation .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3330/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java: Line 1004: message = "Time out: "; > With what content? "RPC cannot complete before timeout" so something like that. Else it's unclear why it times out since it hasn't elapsed to the deadline yet. -- To view, visit http://gerrit.cloudera.org:8080/3330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c5676ab5bd05170505ef0313b919c5475ae6b37 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] [java-client] RPC timeout may sometimes be reported as max attempts violation
Dan Burkert has posted comments on this change. Change subject: [java-client] RPC timeout may sometimes be reported as max attempts violation .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3330/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java: Line 1004: message = "Time out: "; > What I had in mind was a third message. With what content? -- To view, visit http://gerrit.cloudera.org:8080/3330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c5676ab5bd05170505ef0313b919c5475ae6b37 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] [java-client] RPC timeout may sometimes be reported as max attempts violation
Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] RPC timeout may sometimes be reported as max attempts violation .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3330/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java: Line 1004: message = "Time out: "; > I think it's still nice to have the elapsed and timeout info, even if it's What I had in mind was a third message. -- To view, visit http://gerrit.cloudera.org:8080/3330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c5676ab5bd05170505ef0313b919c5475ae6b37 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] [java-client] RPC timeout may sometimes be reported as max attempts violation
Dan Burkert has posted comments on this change. Change subject: [java-client] RPC timeout may sometimes be reported as max attempts violation .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3330/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java: Line 1004: message = "Time out: "; > I wonder if it should be even clearer than that. The reason we got "Too man I think it's still nice to have the elapsed and timeout info, even if it's initially a little confusing in the case of early timeout. -- To view, visit http://gerrit.cloudera.org:8080/3330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c5676ab5bd05170505ef0313b919c5475ae6b37 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] [java-client] RPC timeout may sometimes be reported as max attempts violation
Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] RPC timeout may sometimes be reported as max attempts violation .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3330/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java: Line 1004: message = "Time out: "; I wonder if it should be even clearer than that. The reason we got "Too many attempts" before is because were were checking wouldSleepingTimeout() and it was returning true. So we early time out the RPC to respect the configured timeout. So now we get "Time out", except that the log will still show something like "DeadlineTracker(timeout=3, elapsed=28824)". -- To view, visit http://gerrit.cloudera.org:8080/3330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c5676ab5bd05170505ef0313b919c5475ae6b37 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] [java-client] RPC timeout may sometimes be reported as max attempts violation
Kudu Jenkins has posted comments on this change. Change subject: [java-client] RPC timeout may sometimes be reported as max attempts violation .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/1764/ -- To view, visit http://gerrit.cloudera.org:8080/3330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c5676ab5bd05170505ef0313b919c5475ae6b37 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [java-client] RPC timeout may sometimes be reported as max attempts violation
Dan Burkert has uploaded a new patch set (#2). Change subject: [java-client] RPC timeout may sometimes be reported as max attempts violation .. [java-client] RPC timeout may sometimes be reported as max attempts violation Fixes an issue where an RPC timeout could be reported in the error message as too many attempts. Change-Id: I9c5676ab5bd05170505ef0313b919c5475ae6b37 --- M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/3330/2 -- To view, visit http://gerrit.cloudera.org:8080/3330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9c5676ab5bd05170505ef0313b919c5475ae6b37 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
