[kudu-CR] Show software vers to tablets in master web server

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: Show software vers to tablets in master web server
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3535/2/src/kudu/tserver/heartbeater.cc
File src/kudu/tserver/heartbeater.cc:

Line 277:   // Also register the Kudu version in the initial heartbeat
Nit: the comment isn't quite correct in that registration information may be 
sent outside of the initial heartbeat too. Given the simplicity of the new code 
to follow, I'd just remove the comment altogether.


-- 
To view, visit http://gerrit.cloudera.org:8080/3535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84b32608c9e12a47f422b5047591d4098d187478
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] Show software vers to tablets in master web server

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: Show software vers to tablets in master web server
..


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/2101/

-- 
To view, visit http://gerrit.cloudera.org:8080/3535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84b32608c9e12a47f422b5047591d4098d187478
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Show software vers to tablets in master web server

[Andrew Wong (Code Review)]

Andrew Wong has uploaded a new patch set (#2).

Change subject: Show software vers to tablets in master web server
..

Show software vers to tablets in master web server

In the web UI, it could be helpful to know what version of the
software a tablet server is running. This commit addresses this
by adding a field to the initial registration heartbeat of a
tablet. The version is displayed in the Registration column of
the Tablet Servers page of the master web server.

See:
https://raw.githubusercontent.com/anjuwong/kudu/tserver-vers/tserver_vers_on_master_ui.png

Change-Id: I84b32608c9e12a47f422b5047591d4098d187478
---
M src/kudu/master/master.proto
M src/kudu/tserver/heartbeater.cc
2 files changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/3535/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I84b32608c9e12a47f422b5047591d4098d187478
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Show software vers to tablets in master web server

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: Show software vers to tablets in master web server
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2099/

-- 
To view, visit http://gerrit.cloudera.org:8080/3535
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I84b32608c9e12a47f422b5047591d4098d187478
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No