[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
..


Patch Set 5: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
..


Patch Set 5: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
..


Patch Set 5: Verified+1

There was a build failure in the RELEASE build:
  
  01:36:24 Linking CXX shared library ../../../lib/libkrpc.so
  01:36:25 CMakeFiles/krpc.dir/constants.cc.o: file not recognized: File 
truncated
  01:36:25 collect2: error: ld returned 1 exit status
  01:36:25 make[2]: *** [lib/libkrpc.so] Error 1
  01:36:25 make[1]: *** [src/kudu/rpc/CMakeFiles/krpc.dir/all] Error 2
  01:36:25 make[1]: *** Waiting for unfinished jobs

That file isn't touched by this patch, all of the other builds passed, and 
subsequent RELEASE builds (building off of this patch) have also passed, so I'm 
overriding Jenkins.

-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
..


Patch Set 5: -Verified

Build Started http://104.196.14.100/job/kudu-gerrit/2076/

-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
..


Patch Set 4:

Build Started http://104.196.14.100/job/kudu-gerrit/2062/

-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

[Adar Dembo (Code Review)]

Hello Dan Burkert, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3497

to look at the new patch set (#3).

Change subject: locks: change kudu::shared_lock constructor to pass by ref
..

locks: change kudu::shared_lock constructor to pass by ref

This is less Kudu-style friendly, but it'll make the (eventual) transition
to the C++14 std::shared_lock smoother, and it's also more consistent with
std::lock_guard.

Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
---
M src/kudu/client/meta_cache.cc
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/rpc/rpcz_store.cc
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/transactions/write_transaction.cc
M src/kudu/util/locks.h
9 files changed, 20 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/3497/3
-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3497/2/src/kudu/util/locks.h
File src/kudu/util/locks.h:

Line 242: : m_(DCHECK_NOTNULL()) {
> this DCHECK seems a bit silly now (if we tried to create a null reference t
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
..


Patch Set 2: Code-Review+1

LGTM except for Todd's comment

-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

[Adar Dembo (Code Review)]

Hello Dan Burkert, Todd Lipcon,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/3497

to review the following change.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
..

locks: change kudu::shared_lock constructor to pass by ref

This is less Kudu-style friendly, but it'll make the (eventual) transition
to the C++14 std::shared_lock smoother, and it's also more consistent with
std::lock_guard.

Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
---
M src/kudu/client/meta_cache.cc
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/rpc/rpcz_store.cc
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/transactions/write_transaction.cc
M src/kudu/util/locks.h
9 files changed, 20 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/3497/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: locks: change kudu::shared_lock constructor to pass by ref
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/1991/

-- 
To view, visit http://gerrit.cloudera.org:8080/3497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e25a4f519f5cc09f08f8aeda5284eabdadd0c46
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No