[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-09-05 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r321151966 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-09-05 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r321144138 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-09-04 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r320725961 ## File path: pom.xml ## @@ -1009,6 +1007,20 @@ + Review comment: Now we really

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-31 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319729436 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-31 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319729380 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-31 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319729330 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-31 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319729284 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-30 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319528249 ## File path: pom.xml ## @@ -1009,6 +1007,20 @@ + Review comment: Without the two

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-30 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319526712 ## File path: pom.xml ## @@ -1009,6 +1007,20 @@ + Review comment: Without the two

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-30 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319526712 ## File path: pom.xml ## @@ -1009,6 +1007,20 @@ + Review comment: Without the two

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-30 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319526712 ## File path: pom.xml ## @@ -1009,6 +1007,20 @@ + Review comment: Without the two

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-30 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319413752 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-30 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319411850 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-30 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319409743 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-30 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319409203 ## File path: pom.xml ## @@ -1009,6 +1007,20 @@ + Review comment: These two parts

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-30 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319406484 ## File path: .travis.yml ## @@ -24,16 +24,22 @@ matrix: include: - name: "Spark 2.2 Unit Tests"

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-29 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319342405 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-29 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319342207 ## File path: .travis.yml ## @@ -23,17 +23,23 @@ language: scala matrix: include: - name:

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-29 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319340706 ## File path: pom.xml ## @@ -1009,6 +1007,23 @@ + + integration-test + +

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-29 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319064000 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-29 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319051929 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-29 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319049842 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-29 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319040975 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-29 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r318963375 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-29 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319040831 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-29 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319030285 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-29 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319022573 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-29 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319022573 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-29 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r318973514 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-29 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r318970583 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-29 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r318969732 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-29 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r318963375 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-29 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r318963277 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-29 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r318957528 ## File path: .travis.yml ## @@ -23,17 +23,23 @@ language: scala matrix: include: - name:

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-29 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r318956453 ## File path: .travis.yml ## @@ -23,17 +23,23 @@ language: scala matrix: include: - name: