Review Request 39754: Set the UUID of the expected ACK.

2015-10-29 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39754/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2864

Re: Review Request 39754: Set the UUID of the expected ACK.

2015-10-29 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39754/ --- (Updated 十月 29, 2015, 12:25 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 39358: Network monitoring metrics table has common style

2015-10-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39358/#review104418 --- Patch looks great! Reviews applied: [39358] All tests passed. -

Re: Review Request 39754: Set the UUID of the expected ACK.

2015-10-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39754/#review104423 --- Patch looks great! Reviews applied: [39754] All tests passed. -

Re: Review Request 39719: Fixed marking mounts as slave in ubuntu.

2015-10-29 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39719/ --- (Updated Oct. 29, 2015, 3:44 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 39754: Set the UUID of the expected ACK.

2015-10-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39754/#review104449 --- Hey Yong. Would you mind if I take over the fix for this? the fix

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

2015-10-29 Thread Alexander Rukletsov
> On Oct. 26, 2015, 8:27 a.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1017-1020 > > > > > > Why do we put these code inside the framework sorters foreach loop? I > > do not see it

Re: Review Request 39400: Quota: Implemented quota API.

2015-10-29 Thread Alexander Rukletsov
> On Oct. 28, 2015, 8:54 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 903 > > > > > > Alex, just want to get more for why do we need to add '' for role? I > > know that role is

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

2015-10-29 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/ --- (Updated Oct. 29, 2015, 7:29 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

2015-10-29 Thread Alexander Rukletsov
> On Oct. 26, 2015, 1:49 p.m., Qian Zhang wrote: > > For this patch, it seems that we add the code related to quota support in > > the slave foreach loop in the HierarchicalAllocatorProcess::allocate(const > > hashset& slaveIds_) method, so that means for **each slave**, we > > handle quota

Review Request 39774: Fix libprocess protobuf library detection.

2015-10-29 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39774/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-3600

Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

2015-10-29 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39781/ --- Review request for mesos. Bugs: MESOS-3725

Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

2015-10-29 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39780/ --- Review request for mesos. Bugs: MESOS-3725

Review Request 39769: Fix MESOS-3810 - Include ContainerInfo in command ExecutorInfo

2015-10-29 Thread Spike Curtis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39769/ --- Review request for mesos. Repository: mesos Description --- Always copy

Review Request 39770: Write a newline in ABORT().

2015-10-29 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39770/ --- Review request for mesos. Bugs: MESOS-3708

Review Request 39782: Add a comment for os::libraries::setPaths.

2015-10-29 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39782/ --- Review request for mesos. Bugs: MESOS-3725

Review Request 39775: Fix Mesos protobuf library detection

2015-10-29 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39775/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-3600

Review Request 39771: Show the failing path when execvpe(2) fails.

2015-10-29 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39771/ --- Review request for mesos. Bugs: MESOS-3608

Re: Review Request 39769: Fix MESOS-3810 - Include ContainerInfo in command ExecutorInfo

2015-10-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39769/#review104478 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 39769: Fix MESOS-3810 - Include ContainerInfo in command ExecutorInfo

2015-10-29 Thread Spike Curtis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39769/ --- (Updated Oct. 29, 2015, 10:15 p.m.) Review request for mesos, Jie Yu and Kapil

Re: Review Request 39771: Show the failing path when execvpe(2) fails.

2015-10-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39771/#review104492 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 38649: Add a benchmark to simulate frameworks declining offers.

2015-10-29 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38649/ --- (Updated Oct. 29, 2015, 10:57 p.m.) Review request for mesos and Joris Van

Re: Review Request 39719: Fixed marking mounts as slave in ubuntu.

2015-10-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39719/#review104445 --- Patch looks great! Reviews applied: [39719] All tests passed. -

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

2015-10-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39782/#review104504 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 39775: Fix Mesos protobuf library detection

2015-10-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39775/#review104501 --- Patch looks great! Reviews applied: [39774, 39775] All tests

Re: Review Request 39754: Set the UUID of the expected ACK.

2015-10-29 Thread Yong Qiao Wang
> On 十月 29, 2015, 5:22 p.m., Vinod Kone wrote: > > Hey Yong. Would you mind if I take over the fix for this? the fix is a bit > > involved and i would like to cleanup some tech debt in the process. If you > > are ok with that, please discard this review. OK, thanks! - Yong Qiao

Review Request 39791: Updated createStatusUpdate() to unset StatusUpdate.uuid instead of setting it to an empty string.

2015-10-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39791/ --- Review request for mesos, Anand Mazumdar and Ben Mahler. Repository: mesos

Review Request 39792: Updated master and slave to properly set task status uuid.

2015-10-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39792/ --- Review request for mesos, Anand Mazumdar and Ben Mahler. Repository: mesos

Re: Review Request 39358: Network monitoring metrics table has common style

2015-10-29 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39358/ --- (Updated Oct. 29, 2015, 8:44 a.m.) Review request for mesos, Dave Lester, Jie

Re: Review Request 39358: Network monitoring metrics table has common style

2015-10-29 Thread Tomasz Janiszewski
> On Oct. 28, 2015, 10:30 p.m., Joris Van Remoortere wrote: > > docs/network-monitoring.md, line 291 > > > > > > `[3]` applies to more than 1 field in the table right? > > I think this is why the message was

Re: Review Request 39358: Network monitoring metrics table has common style

2015-10-29 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39358/ --- (Updated Oct. 29, 2015, 10:48 a.m.) Review request for mesos, Dave Lester, Jie

Re: Review Request 39358: Network monitoring metrics table has common style

2015-10-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39358/#review104412 --- Bad patch! Reviews applied: [39358] Failed command:

Re: Review Request 39771: Show the failing path when execvpe(2) fails.

2015-10-29 Thread James Peach
> On Oct. 30, 2015, 2:03 a.m., Guangya Liu wrote: > > 3rdparty/libprocess/src/subprocess.cpp, line 179 > > > > > > I suggest that we use 'path' instead. > > > > ABORT(string("Failed to os::execvpe '") +

Re: Review Request 39771: Show the failing path when execvpe(2) fails.

2015-10-29 Thread Guangya Liu
> On Oct. 30, 2015, 2:03 a.m., Guangya Liu wrote: > > 3rdparty/libprocess/src/subprocess.cpp, line 179 > > > > > > I suggest that we use 'path' instead. > > > > ABORT(string("Failed to os::execvpe '") +

Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests

2015-10-29 Thread David Forsythe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39634/ --- (Updated Oct. 30, 2015, 5:05 a.m.) Review request for mesos and Ian Downes.

Re: Review Request 39635: FreeBSD: Enable libprocess build and disable failing test

2015-10-29 Thread David Forsythe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39635/ --- (Updated Oct. 30, 2015, 5:05 a.m.) Review request for mesos and Ian Downes.

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

2015-10-29 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39559/ --- (Updated Oct. 30, 2015, 5:53 a.m.) Review request for mesos, Artem

Re: Review Request 39560: CMake: Add state.cpp, flags.cpp to Windows agent build.

2015-10-29 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39560/ --- (Updated Oct. 30, 2015, 5:54 a.m.) Review request for mesos, Artem

Re: Review Request 39219: Windows: Added support for `slave/state.cpp`.

2015-10-29 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39219/ --- (Updated Oct. 30, 2015, 5:54 a.m.) Review request for mesos, Artem

Review Request 39799: Allow hdfs URLs in the HDFS wrapper API.

2015-10-29 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39799/ --- Review request for mesos. Bugs: MESOS-3602

Re: Review Request 39620: Windows: Included headers to make `stout/windows.hpp` standalone.

2015-10-29 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39620/ --- (Updated Oct. 30, 2015, 5:57 a.m.) Review request for mesos, Artem

Re: Review Request 39622: CMake: Pointed Stout test linker flags at correct gtest directory.

2015-10-29 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39622/ --- (Updated Oct. 30, 2015, 5:57 a.m.) Review request for mesos, Artem

Re: Review Request 39621: CMake: Corrected linking path for gmock libraries on Windows builds.

2015-10-29 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39621/ --- (Updated Oct. 30, 2015, 5:57 a.m.) Review request for mesos, Artem

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-10-29 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39583/ --- (Updated Oct. 30, 2015, 5:55 a.m.) Review request for mesos, Artem

Re: Review Request 39792: Updated master and slave to properly set task status uuid.

2015-10-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39792/#review104516 --- Patch looks great! Reviews applied: [39791, 39792] All tests

Re: Review Request 39800: Fix HDFS du output parsing.

2015-10-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39800/#review104520 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 39636: FreeBSD: Add basic support to stout

2015-10-29 Thread David Forsythe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39636/ --- (Updated Oct. 30, 2015, 5:06 a.m.) Review request for mesos and Ian Downes.

Review Request 39800: Fix HDFS du output parsing.

2015-10-29 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39800/ --- Review request for mesos. Bugs: MESOS-3605

Re: Review Request 39703: [WIP] Exposed container-id via TaskStatus updates.

2015-10-29 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39703/#review104528 --- Kapil, does it make sense to create another patch handle the

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-10-29 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/ --- (Updated Oct. 30, 2015, 5:59 a.m.) Review request for mesos, Artem

Re: Review Request 39623: CMake: Added protobuf compilation to Windows builds.

2015-10-29 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39623/ --- (Updated Oct. 30, 2015, 5:58 a.m.) Review request for mesos, Artem

Re: Review Request 39771: Show the failing path when execvpe(2) fails.

2015-10-29 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39771/#review104507 --- Also please add people for this RR.

Re: Review Request 38649: Add a benchmark to simulate frameworks declining offers.

2015-10-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38649/#review104506 --- Patch looks great! Reviews applied: [38649] All tests passed. -

Re: Review Request 39770: Write a newline in ABORT().

2015-10-29 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39770/#review104508 --- Code looks good, need to add people for this RR. - Guangya Liu

Re: Review Request 39507: Check message.empty() in Slave::shutdown before log it

2015-10-29 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39507/#review104509 --- Till, can you please help check if can be merged? Thanks! -

Re: Review Request 39702: Fixed incorrect signed vs. unsigned comparisons.

2015-10-29 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39702/#review104513 --- Ship it! Ship It! - Guangya Liu On Oct. 27, 2015, 9:54 p.m.,

Re: Review Request 39400: Quota: Implemented quota API.

2015-10-29 Thread Guangya Liu
> On Oct. 28, 2015, 8:54 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 903 > > > > > > Alex, just want to get more for why do we need to add '' for role? I > > know that role is

Re: Review Request 39400: Quota: Implemented quota API.

2015-10-29 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/#review104515 --- Ship it! Ship It! - Guangya Liu On Oct. 27, 2015, 7:17 p.m.,