Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review111881 --- Patch looks great! Reviews applied: [40429] Passed command:

Review Request 41713: Added HDFS URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41713/ --- Review request for mesos, Adam B, Ben Mahler, Ian Downes, and Vinod Kone.

Re: Review Request 41714: Added tests for HDFS URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41714/#review111886 --- Patch looks great! Reviews applied: [41713, 41714] Passed

Review Request 41714: Added tests for HDFS URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41714/ --- Review request for mesos, Adam B, Ben Mahler, Ian Downes, and Vinod Kone.

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/ --- (Updated Dec. 24, 2015, 8:29 p.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review111871 --- - Zhitao Li On Dec. 24, 2015, 8:29 p.m., Zhitao Li wrote: > >

Re: Review Request 40429: Report executor exit to framework schedulers.

> On Dec. 21, 2015, 5:47 a.m., Qian Zhang wrote: > > src/sched/sched.cpp, line 576 > > > > > > Why do you change the logic under "Event::MESSAGE"? I think it has > > nothing to do with this ticket. Mistread

Re: Review Request 40429: Report executor exit to framework schedulers.

> On Dec. 18, 2015, 12:04 p.m., Adam B wrote: > > CHANGELOG, line 104 > > > > > > You're modifying the 0.26 Release Notes, but this is going into 0.27 > > now. > > If this is worth calling out as an "API

Review Request 41706: Added Qunar to Powered by Mesos page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41706/ --- Review request for mesos, Adam B and Joris Van Remoortere. Repository: mesos

Re: Review Request 41705: WIP: Added support for enforcing quota on (persistent) volumes (MESOS-4198).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41705/#review111832 --- Patch looks great! Reviews applied: [41704, 41705] Passed

Re: Review Request 41444: Cleaned up Authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/#review111867 --- Patch looks great! Reviews applied: [41444] Passed command:

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

> On Dec. 24, 2015, 11:10 a.m., Adam B wrote: > > Looks good, but I wonder if we need to go so far as to introduce the `enum > > Protocol` misnomer in the global IPAddress message now. We could always add > > it in later, when we actually get NetworkInfo off of it. 1. Adam, can you elaborate

Re: Review Request 41586: Partially enforced commit message guidelines with a hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41586/#review111839 --- Nice work. Just a couple of tweaks. bootstrap (lines 22 - 23)

Re: Review Request 41444: Cleaned up Authorizer interface.

> On Dec. 18, 2015, 12:42 a.m., Adam B wrote: > > include/mesos/authorizer/authorizer.hpp, line 144 > > > > > > s/reserve particular resources/reserve resources/ since the only values > > currently allowed for

Re: Review Request 41584: Added commit message guidelines to docs.

> On Dec. 19, 2015, 6:34 a.m., Till Toenshoff wrote: > > docs/submitting-a-patch.md, line 52 > > > > > > We actually do it a bit more differentiated. > > > > The `Summary` should be past tense, start with a

Re: Review Request 41444: Cleaned up Authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/#review111845 --- Ship it! Awesome! Few minor tweaks and we can ship it!

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#review111848 --- Looks good, but I wonder if we need to go so far as to introduce

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/#review111858 --- Patch looks great! Reviews applied: [41438] Passed command:

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/ --- (Updated Dec. 24, 2015, 1:22 p.m.) Review request for mesos and Bernd

Re: Review Request 41444: Cleaned up Authorizer interface.

> On Dec. 24, 2015, 10:47 a.m., Adam B wrote: > > include/mesos/authorizer/authorizer.hpp, line 42 > > > > > > "checked"? You mean, "the request could not be completed"? or "made" or > > "authorized"? I like

Re: Review Request 41444: Cleaned up Authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/ --- (Updated Dec. 24, 2015, 3:32 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 41444: Cleaned up Authorizer interface.

> On Dec. 24, 2015, 10:47 a.m., Adam B wrote: > > include/mesos/authorizer/authorizer.hpp, line 133 > > > > > > where did `framework_principal` come from? YOu only talk about "the > > framework principal" prior to