Re: Review Request 42673: Silenced two more GMock warnings about shutdown expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42673/#review115976 --- Patch looks great! Reviews applied: [42673] Passed command: expo

Re: Review Request 41299: Allow DockerContainerizer log to console.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41299/ --- (Updated Jan. 23, 2016, 8:58 a.m.) Review request for mesos, Ben Mahler and Tim

Re: Review Request 41783: Logger Module: Implement the rotating container logger module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41783/ --- (Updated Jan. 23, 2016, 1:07 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 41962: Logger Module: Add tests for module recovery after agent failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41962/ --- (Updated Jan. 23, 2016, 1:13 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 42353: Correctted typo in fetcher.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42353/#review115977 --- Patch looks great! Reviews applied: [42353] Passed command: expo

Re: Review Request 42678: WIP: Avoid `slave.total` do not contain `slave.allocated` in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42678/#review115978 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42471/ --- (Updated Jan. 23, 2016, 10:47 a.m.) Review request for mesos, Jie Yu and Michae

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

> On Jan. 22, 2016, 5:03 p.m., Jie Yu wrote: > > src/common/resources.cpp, line 314 > > > > > > This is not correct. You've already checked left.disk() == > > right.disk(), why do you need this? Instead, you should

Re: Review Request 42472: Multiple Disk: Checkpoint persistent volume based on 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42472/ --- (Updated Jan. 23, 2016, 10:49 a.m.) Review request for mesos, Jie Yu and Michae

Re: Review Request 42473: Multiple Disk: Updated filesystem isolators to use 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42473/ --- (Updated Jan. 23, 2016, 10:50 a.m.) Review request for mesos, Jie Yu and Michae

Re: Review Request 42474: Multiple Disk: Updated Slave initialize to create DiskInfo paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42474/ --- (Updated Jan. 23, 2016, 10:51 a.m.) Review request for mesos, Jie Yu and Michae

Review Request 42683: Multiple Disk: Added Resource arithmetic tests for type 'MOUNT'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42683/ --- Review request for mesos, Jie Yu and Michael Park. Repository: mesos Descript

Re: Review Request 42593: Multiple Disk: Fixed invalid 'DiskResourcesTest's.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42593/ --- (Updated Jan. 23, 2016, 10:53 a.m.) Review request for mesos, Jie Yu and Michae

Re: Review Request 42504: Multiple Disk: Modified 'DiskInfo' stripping logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42504/ --- (Updated Jan. 23, 2016, 10:53 a.m.) Review request for mesos, Jie Yu and Michae

Re: Review Request 42506: Multiple Disk: Parameterized persistent volume tests on disk source.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42506/ --- (Updated Jan. 23, 2016, 10:55 a.m.) Review request for mesos, Jie Yu and Michae

Re: Review Request 42505: Multiple Disk: Adjusted DiskInfo validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42505/ --- (Updated Jan. 23, 2016, 10:54 a.m.) Review request for mesos, Jie Yu and Michae

Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42684/ --- Review request for mesos, Jie Yu and Michael Park. Repository: mesos Descript

Re: Review Request 42672: Explicitly checked for the absence of allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42672/#review115980 --- Patch looks great! Reviews applied: [42633, 42636, 42657, 42658,

Re: Review Request 41772: Added helper function to flatten resources.

> On Jan. 20, 2016, 6:18 a.m., Joseph Wu wrote: > > src/common/resources.cpp, line 880 > > > > > > It should be fine to just name this `flatten`. > > > > You should also consider changing the parameter type

Review Request 42685: Added roles validation to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42685/ --- Review request for mesos, Benjamin Bannier and Vinod Kone. Bugs: MESOS-4364

Re: Review Request 41772: Added helper function to flatten resources.

> On 一月 19, 2016, 10:18 p.m., Joseph Wu wrote: > > src/common/resources.cpp, line 880 > > > > > > It should be fine to just name this `flatten`. > > > > You should also consider changing the parameter type f

Re: Review Request 41299: Allow DockerContainerizer log to console.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41299/#review115983 --- Patch looks great! Reviews applied: [41299] Passed command: expo

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review115984 --- src/docker/docker.cpp (line 517)

Review Request 42686: Fix warning about _FORTIFY_SOURCE flag when compile python package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42686/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --

Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42684/#review115985 --- Patch looks great! Reviews applied: [42470, 42471, 42472, 42473,

Re: Review Request 42686: Fix warning about _FORTIFY_SOURCE flag when compile python package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42686/ --- (Updated Jan. 23, 2016, 3:29 p.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 42685: Added roles validation to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42685/#review115986 --- Patch looks great! Reviews applied: [42415, 42685] Passed comman

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42471/#review115987 --- Ship it! Ship It! - Jie Yu On Jan. 23, 2016, 10:47 a.m., Jor

Re: Review Request 42474: Multiple Disk: Updated Slave initialize to create DiskInfo paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42474/#review115988 --- Ship it! Ship It! - Jie Yu On Jan. 23, 2016, 10:51 a.m., Jor

Re: Review Request 42506: Multiple Disk: Parameterized persistent volume tests on disk source.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42506/#review115989 --- Fix it, then Ship it! src/tests/persistent_volume_tests.cpp (l

Re: Review Request 42683: Multiple Disk: Added Resource arithmetic tests for type 'MOUNT'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42683/#review115990 --- Fix it, then Ship it! src/tests/resources_tests.cpp (lines 171

Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42684/#review115991 --- src/tests/persistent_volume_tests.cpp (line 90)

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42674/#review115992 --- Can you add more context in the description? Is that because there

Re: Review Request 41783: Logger Module: Implement the rotating container logger module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41783/#review115993 --- src/slave/container_loggers/lib_logrotate.hpp (line 106)

Re: Review Request 42686: Fix warning about _FORTIFY_SOURCE flag when compile python package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42686/#review115994 --- Patch looks great! Reviews applied: [42686] Passed command: expo

Re: Review Request 42686: Fix warning about _FORTIFY_SOURCE flag when compile python package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42686/ --- (Updated Jan. 23, 2016, 6:32 p.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42674/#review115996 --- Patch looks great! Reviews applied: [42674] Passed command: expo

Review Request 42688: Fixed equality semantics for Labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42688/ --- Review request for mesos and Michael Park. Bugs: MESOS-4445 https://issues.

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated Jan. 23, 2016, 8:45 p.m.) Review request for mesos and TimothyIL Timot

Re: Review Request 42477: Corrected example in quota user doc.

> On Jan. 22, 2016, 4:34 p.m., Bernd Mathiske wrote: > > docs/quota.md, line 173 > > > > > > Same here. see above. - Joerg --- This is an automatically gen

Re: Review Request 42477: Corrected example in quota user doc.

> On Jan. 22, 2016, 4:34 p.m., Bernd Mathiske wrote: > > docs/quota.md, line 166 > > > > > > Please explain what this seemingly redundant field is doing. > > Guangya Liu wrote: > I think this is because the curr

Re: Review Request 42688: Fixed equality semantics for Labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42688/#review115999 --- Patch looks great! Reviews applied: [42688] Passed command: expo

Re: Review Request 42518: Disabled "drop_log_memory" flag for glog.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42518/#review116000 --- Ship it! Thanks Kapil! - Ben Mahler On Jan. 23, 2016, 3:59 a

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review116001 --- Patch looks great! Reviews applied: [42516] Passed command: expo

Review Request 42689: Clarified a comment that occurs in several test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42689/ --- Review request for mesos and Adam B. Repository: mesos Description --- C

Re: Review Request 42518: Disabled "drop_log_memory" flag for glog.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42518/#review116002 --- Patch looks great! Reviews applied: [42518] Passed command: expo

Re: Review Request 42683: Multiple Disk: Added Resource arithmetic tests for type 'MOUNT'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42683/ --- (Updated Jan. 24, 2016, 1 a.m.) Review request for mesos, Jie Yu and Michael Pa

Re: Review Request 42504: Multiple Disk: Modified 'DiskInfo' stripping logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42504/ --- (Updated Jan. 24, 2016, 1:01 a.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 42506: Multiple Disk: Parameterized persistent volume tests on disk source.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42506/ --- (Updated Jan. 24, 2016, 1:01 a.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42684/ --- (Updated Jan. 24, 2016, 1:02 a.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42684/ --- (Updated Jan. 24, 2016, 1:08 a.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 42683: Multiple Disk: Added Resource arithmetic tests for type 'MOUNT'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42683/ --- (Updated Jan. 24, 2016, 1:19 a.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 42504: Multiple Disk: Modified 'DiskInfo' stripping logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42504/ --- (Updated Jan. 24, 2016, 1:20 a.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 42506: Multiple Disk: Parameterized persistent volume tests on disk source.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42506/ --- (Updated Jan. 24, 2016, 1:20 a.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 42505: Multiple Disk: Adjusted DiskInfo validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42505/ --- (Updated Jan. 24, 2016, 1:20 a.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42684/ --- (Updated Jan. 24, 2016, 1:33 a.m.) Review request for mesos, Jie Yu and Michael

Re: Review Request 42689: Clarified a comment that occurs in several test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42689/#review116003 --- Patch looks great! Reviews applied: [42689] Passed command: expo

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review116005 --- Fix it, then Ship it! src/docker/docker.cpp (line 518)

Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42684/#review116006 --- Patch looks great! Reviews applied: [42470, 42471, 42472, 42473,

Review Request 42691: Fix GMock warning in MasterTest.OrphanTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42691/ --- Review request for mesos, Greg Mann, Jie Yu, and Timothy Chen. Bugs: MESOS-4484

Re: Review Request 42691: Fix GMock warning in MasterTest.OrphanTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42691/ --- (Updated Jan. 24, 2016, 3:45 a.m.) Review request for mesos, Greg Mann, Jie Yu,

Re: Review Request 42691: Fix GMock warning in MasterTest.OrphanTasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42691/#review116007 --- Patch looks great! Reviews applied: [42691] Passed command: expo

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 24, 2016, 5 a.m.) Review request for mesos, Adam B, Neil Conway,

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated Jan. 24, 2016, 6:42 a.m.) Review request for mesos and TimothyIL Timot

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review116010 --- Fix it, then Ship it! src/docker/docker.cpp (line 519)

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

> On 一月 23, 2016, 5:40 p.m., Jie Yu wrote: > > Can you add more context in the description? Is that because there are too > > many links in busybox, causing issues with docker with brfts backend snce > > brfts backend has a limit on links? > > > > Also, can you do a sweep in the code base to m

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review116012 --- Patch looks great! Reviews applied: [42516] Passed command: expo