Review Request 45623: Renamed the parameter 'override' to '_override'.

2016-04-03 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45623/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Re: Review Request 45626: Add jsonify for FlagsBase.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45626/ --- (Updated April 3, 2016, 2:14 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-03 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review126719 --- src/cli/execute.cpp (line 104)

Re: Review Request 44899: Update containerizer construction in slave_recovery_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44899/ --- (Updated April 3, 2016, 1:07 p.m.) Review request for mesos and Till

Re: Review Request 44897: Update containerizer construction in hook_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44897/ --- (Updated April 3, 2016, 1:07 p.m.) Review request for mesos and Till

Re: Review Request 44826: Remove `SlaveState` in `TestContainerizer` during recover.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44826/ --- (Updated April 3, 2016, 1:06 p.m.) Review request for mesos and Till

Re: Review Request 44824: Remove `SlaveState` in `ComposingContainerizer` during recover.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44824/ --- (Updated April 3, 2016, 1:06 p.m.) Review request for mesos and Till

Re: Review Request 44895: Update containerizer construction in container_logger_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44895/ --- (Updated April 3, 2016, 1:07 p.m.) Review request for mesos and Till

Re: Review Request 44896: Update containerizer construction in disk_quota_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44896/ --- (Updated April 3, 2016, 1:07 p.m.) Review request for mesos and Till

Re: Review Request 44893: Remove fetcher header file in containerizer.hpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44893/ --- (Updated April 3, 2016, 1:07 p.m.) Review request for mesos and Till

Re: Review Request 44894: Remove `Fetcher` in `MesosContainerizer::create`.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44894/ --- (Updated April 3, 2016, 1:07 p.m.) Review request for mesos and Till

Re: Review Request 44892: Remove `Fetcher` in `Containerizer::create`.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44892/ --- (Updated April 3, 2016, 1:07 p.m.) Review request for mesos and Till

Re: Review Request 44906: Update containerizer construction in fetcher_cache_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44906/ --- (Updated April 3, 2016, 1:07 p.m.) Review request for mesos and Till

Re: Review Request 44900: Update containerizer construction in slave_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44900/ --- (Updated April 3, 2016, 1:07 p.m.) Review request for mesos and Till

Re: Review Request 44898: Update containerizer construction in health_check_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44898/ --- (Updated April 3, 2016, 1:07 p.m.) Review request for mesos and Till

Re: Review Request 44908: Update `MockDockerContainerizer` construction.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44908/ --- (Updated April 3, 2016, 1:08 p.m.) Review request for mesos and Till

Re: Review Request 44904: Update containerizer construction in mesos_containerizer_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44904/ --- (Updated April 3, 2016, 1:07 p.m.) Review request for mesos and Till

Re: Review Request 44903: Update containerizer construction in port_mapping_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44903/ --- (Updated April 3, 2016, 1:07 p.m.) Review request for mesos and Till

Re: Review Request 44905: Update containerizer construction in isolator_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44905/ --- (Updated April 3, 2016, 1:07 p.m.) Review request for mesos and Till

Re: Review Request 44901: Update containerizer construction in filesystem_isolator_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44901/ --- (Updated April 3, 2016, 1:07 p.m.) Review request for mesos and Till

Re: Review Request 44902: Update containerizer construction in memory_pressure_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44902/ --- (Updated April 3, 2016, 1:07 p.m.) Review request for mesos and Till

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-03 Thread Guangya Liu
> On 四月 3, 2016, 9:52 a.m., Alexander Rukletsov wrote: > > src/cli/execute.cpp, line 283 > > > > > > According to "testing done" section, the separator is comma. How come > > here is space? > > > > Also,

Re: Review Request 44828: Remove `SlaveState` in ContainerLoggerTest related test cases.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44828/ --- (Updated April 3, 2016, 2:11 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44825: Remove `SlaveState` in `ExternalContainerizer` during recover.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44825/ --- (Updated April 3, 2016, 2:11 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44822: Remove `SlaveState` in `MesosContainerizer` during recover.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44822/ --- (Updated April 3, 2016, 2:11 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44823/ --- (Updated April 3, 2016, 2:11 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44824: Remove `SlaveState` in `ComposingContainerizer` during recover.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44824/ --- (Updated April 3, 2016, 2:11 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44892: Remove `Fetcher` in `Containerizer::create`.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44892/ --- (Updated April 3, 2016, 2:12 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44893: Remove fetcher header file in containerizer.hpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44893/ --- (Updated April 3, 2016, 2:12 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45634: Update `MesosContainerizer::create` in memory_pressure_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45634/ --- (Updated April 3, 2016, 2:25 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45632: Update `MesosContainerizer::create` in container_logger_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45632/ --- (Updated April 3, 2016, 2:25 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45636: Update `MesosContainerizer::create` in port_mapping_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45636/ --- (Updated April 3, 2016, 2:25 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45640: Update `MesosContainerizer::create` in slave_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45640/ --- (Updated April 3, 2016, 2:25 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45631: Use `Parameters` as `MesosContainerizer::create` parameters type.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45631/ --- (Updated April 3, 2016, 2:25 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45635: Update `MesosContainerizer::create` in mesos_containerizer_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45635/ --- (Updated April 3, 2016, 2:25 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45633: Update `MesosContainerizer::create` in isolator_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45633/ --- (Updated April 3, 2016, 2:25 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45638: Update `MesosContainerizer::create` in health_check_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45638/ --- (Updated April 3, 2016, 2:25 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

2016-04-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44798/#review126729 --- It is always suggested to use past tone for the summary and ditto

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-03 Thread Alexander Rukletsov
> On April 2, 2016, 2:38 p.m., haosdent huang wrote: > > src/cli/execute.cpp, line 283 > > > > > > How to handle those command parameters contains "," here? For example, > > if user want to try "cat 'a,b'". Yeah,

Review Request 45638: Update `MesosContainerizer::create` in health_check_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45638/ --- Review request for mesos. Repository: mesos Description --- Update

Review Request 45637: Update `MesosContainerizer::create` in disk_quota_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45637/ --- Review request for mesos. Repository: mesos Description --- Update

Re: Review Request 45655: Add containerizer module header.

2016-04-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45655/#review126723 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Review Request 45643: Use `Parameters` as `ExternalContainerizer::create` parameters type.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45643/ --- Review request for mesos. Repository: mesos Description --- Use

Review Request 45641: Update `MesosContainerizer::create` in slave_recovery_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45641/ --- Review request for mesos. Repository: mesos Description --- Update

Review Request 45650: Update the namespace of `Containerizer` to `mesos::slave`.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45650/ --- Review request for mesos. Repository: mesos Description --- Update the

Review Request 45647: Move `Containerizer::resources` out of containerizer interface.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45647/ --- Review request for mesos. Repository: mesos Description --- Move

Review Request 45640: Update `MesosContainerizer::create` in slave_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45640/ --- Review request for mesos. Repository: mesos Description --- Update

Review Request 45648: Move `executorEnvironment` out of containerizer interface.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45648/ --- Review request for mesos. Repository: mesos Description --- Move

Re: Review Request 45646: Remove `PID` in composing_containerizer_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45646/ --- (Updated April 3, 2016, 2:15 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45649: Update header files for `executorEnvironment`.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45649/ --- (Updated April 3, 2016, 2:15 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45645: Remove `PID` in containerizer interfaces.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45645/ --- (Updated April 3, 2016, 2:15 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45648: Move `executorEnvironment` out of containerizer interface.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45648/ --- (Updated April 3, 2016, 2:15 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44822: Remove `SlaveState` in `MesosContainerizer` during recover.

2016-04-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44822/#review126727 --- src/slave/containerizer/mesos/containerizer.hpp (lines 180 -

Re: Review Request 44908: Update `MockDockerContainerizer` construction.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44908/ --- (Updated April 3, 2016, 2:24 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44905: Update containerizer construction in isolator_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44905/ --- (Updated April 3, 2016, 2:23 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44894: Remove `Fetcher` in `MesosContainerizer::create`.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44894/ --- (Updated April 3, 2016, 2:22 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44900: Update containerizer construction in slave_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44900/ --- (Updated April 3, 2016, 2:23 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44904: Update containerizer construction in mesos_containerizer_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44904/ --- (Updated April 3, 2016, 2:23 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44909: Update containerizer construction in docker_containerizer_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44909/ --- (Updated April 3, 2016, 2:24 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44907: Remove `Fetcher` in `DockerContainerizer::create`.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44907/ --- (Updated April 3, 2016, 2:24 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44903: Update containerizer construction in port_mapping_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44903/ --- (Updated April 3, 2016, 2:23 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44895: Update containerizer construction in container_logger_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44895/ --- (Updated April 3, 2016, 2:22 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44901: Update containerizer construction in filesystem_isolator_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44901/ --- (Updated April 3, 2016, 2:23 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover.

2016-04-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44823/#review126728 --- src/slave/containerizer/docker.cpp (lines 785 - 788)

Re: Review Request 44897: Update containerizer construction in hook_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44897/ --- (Updated April 3, 2016, 2:22 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44906: Update containerizer construction in fetcher_cache_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44906/ --- (Updated April 3, 2016, 2:23 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44899: Update containerizer construction in slave_recovery_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44899/ --- (Updated April 3, 2016, 2:22 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44902: Update containerizer construction in memory_pressure_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44902/ --- (Updated April 3, 2016, 2:23 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44898: Update containerizer construction in health_check_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44898/ --- (Updated April 3, 2016, 2:22 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-03 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review126720 --- src/cli/execute.cpp (line 283)

Re: Review Request 44423: Added HTTP command executor to make files.

2016-04-03 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44423/ --- (Updated April 3, 2016, 8:51 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

2016-04-03 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44424/ --- (Updated April 3, 2016, 8:52 p.m.) Review request for mesos, Anand Mazumdar

Review Request 45642: Use `Parameters` as `DockerContainerizer::create` parameters type.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45642/ --- Review request for mesos. Repository: mesos Description --- Use

Review Request 45639: Update `MesosContainerizer::create` in hook_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45639/ --- Review request for mesos. Repository: mesos Description --- Update

Review Request 45649: Update header files for `executorEnvironment`.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45649/ --- Review request for mesos. Repository: mesos Description --- Update

Review Request 45644: Use `Parameters` as `ComposingContainerizer::create` parameters type.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45644/ --- Review request for mesos. Repository: mesos Description --- Use

Review Request 45645: Remove `PID` in containerizer interfaces.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45645/ --- Review request for mesos. Repository: mesos Description --- Remove

Review Request 45646: Remove `PID` in composing_containerizer_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45646/ --- Review request for mesos. Repository: mesos Description --- Remove

Review Request 45653: Update header file for `Containerizer` interface header.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45653/ --- Review request for mesos. Repository: mesos Description --- Update

Review Request 45651: Update `Containerizer` namespace in test files.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45651/ --- Review request for mesos. Repository: mesos Description --- Update

Review Request 45654: Update header file in tests for `Containerizer` interface header.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45654/ --- Review request for mesos. Repository: mesos Description --- Update

Review Request 45652: Public `Containerizer` interface file.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45652/ --- Review request for mesos. Repository: mesos Description --- Public

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44798/ --- (Updated April 3, 2016, 2:09 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44826: Remove `SlaveState` in `TestContainerizer` during recover.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44826/ --- (Updated April 3, 2016, 2:11 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44798/ --- (Updated April 3, 2016, 1:06 p.m.) Review request for mesos and Till

Re: Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44823/ --- (Updated April 3, 2016, 1:06 p.m.) Review request for mesos and Till

Re: Review Request 44822: Remove `SlaveState` in `MesosContainerizer` during recover.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44822/ --- (Updated April 3, 2016, 1:06 p.m.) Review request for mesos and Till

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

2016-04-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44798/#review126726 --- src/slave/containerizer/containerizer.hpp (line 29)

Re: Review Request 45652: Public `Containerizer` interface file.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45652/ --- (Updated April 3, 2016, 2:18 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45653: Update header file for `Containerizer` interface header.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45653/ --- (Updated April 3, 2016, 2:18 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45655: Add containerizer module header.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45655/ --- (Updated April 3, 2016, 2:19 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45651: Update `Containerizer` namespace in test files.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45651/ --- (Updated April 3, 2016, 2:18 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45650: Update the namespace of `Containerizer` to `mesos::slave`.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45650/ --- (Updated April 3, 2016, 2:18 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45654: Update header file in tests for `Containerizer` interface header.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45654/ --- (Updated April 3, 2016, 2:18 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45647: Move `Containerizer::resources` out of containerizer interface.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45647/ --- (Updated April 3, 2016, 2:17 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45639: Update `MesosContainerizer::create` in hook_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45639/ --- (Updated April 3, 2016, 2:25 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45637: Update `MesosContainerizer::create` in disk_quota_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45637/ --- (Updated April 3, 2016, 2:25 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45643: Use `Parameters` as `ExternalContainerizer::create` parameters type.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45643/ --- (Updated April 3, 2016, 2:27 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45641: Update `MesosContainerizer::create` in slave_recovery_tests.cpp.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45641/ --- (Updated April 3, 2016, 2:25 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 45200: Duplicate flags with keywork 'slave' on master side.

2016-04-03 Thread Jay Guo
> On April 1, 2016, 10:49 p.m., Vinod Kone wrote: > > Can you call this out in the CHANGELOG too please? > > > > Also, all of the old flags should print a deprecation warning (when a user > > does --help on the binary or starts the binary with a deprecated flag) and > > direct users to the

  1   2   >