----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44822/#review126727 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.hpp (lines 180 - 182) <https://reviews.apache.org/r/44822/#comment189781> one line src/slave/containerizer/mesos/containerizer.cpp (line 419) <https://reviews.apache.org/r/44822/#comment189783> What about s/newRecoverables/mesosRevocables or s/newRecoverables/filterRevocables and add some comments here for why do we need filter here? // ContainerState revocabale info which only // include mesos containerizers. list<ContainerState> filterRecoverables; src/slave/containerizer/mesos/containerizer.cpp (lines 421 - 424) <https://reviews.apache.org/r/44822/#comment189780> What about using reference here? const ExecutorInfo& executorInfo = recoverable.executor_info(); const ContainerID& containerId = recoverable.container_id(); const FrameworkID& frameworkId = executorInfo.framework_id(); const ExecutorID& executorId = executorInfo.executor_id(); - Guangya Liu On 四月 3, 2016, 1:06 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44822/ > ----------------------------------------------------------- > > (Updated 四月 3, 2016, 1:06 p.m.) > > > Review request for mesos and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Remove `SlaveState` in `MesosContainerizer` during recover. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > a6e3a8b43fb7591ff6f23b019a062696c8bfb719 > src/slave/containerizer/mesos/containerizer.cpp > a5dd22380066aa85de04d485052084e2629681c0 > src/tests/containerizer/mesos_containerizer_tests.cpp > 09742ff21513dc2570684d384b257868dd57a9ce > > Diff: https://reviews.apache.org/r/44822/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
