Re: Review Request 46501: Updated authorization.md to reflect current changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/ --- (Updated April 28, 2016, 11:56 a.m.) Review request for mesos, Adam B, Greg

Re: Review Request 46763: Removed unused RepeatedPtrField in quota_handler.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46763/#review130906 --- Ship it! Ship It! - haosdent huang On April 28, 2016, 6:54

Re: Review Request 46203: Added authorization of the '/flags' endpoint.

> On April 27, 2016, 11:29 a.m., Adam B wrote: > > src/authorizer/local/authorizer.cpp, line 213 > > > > > > Does this only match exact strings, or endpoints nested under this path > > as well? > > For

Review Request 46783: Minor clarifications to HA framework guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46783/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 46782: Removed false claim that TEARDOWN can remove persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46782/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 46762: Enabled volume support for mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46762/#review130920 --- Patch looks great! Reviews applied: [46762] Passed command:

Review Request 46779: Clarified and improved maintenance docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46779/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 46781: Fixed invalid JSON in scheduler HTTP API examples.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46781/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 46780: Clarify that slave checkpoint is always enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46780/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

> On 四月 2, 2016, 2:38 p.m., haosdent huang wrote: > > src/cli/execute.cpp, line 283 > > > > > > How to handle those command parameters contains "," here? For example, > > if user want to try "cat 'a,b'". > >

Review Request 46784: Added authorization of the '/flags' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46784/ --- Review request for mesos, Alexander Rukletsov and Benjamin Bannier. Bugs:

Re: Review Request 46762: Enabled volume support for mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46762/ --- (Updated 四月 28, 2016, 1:56 p.m.) Review request for mesos, Gilbert Song and

Review Request 46762: Enabled volume support for mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46762/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-5265

Review Request 46761: Slave/Agent Rename Phase I - Update terms in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46761/ --- Review request for mesos, Kevin Klues and Vinod Kone. Bugs: mesos-3779

Review Request 46763: Removed unused RepeatedPtrField in quota_handler.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46763/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 46796: Synced endpoint documentation by running generation script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46796/ --- (Updated April 28, 2016, 10:08 p.m.) Review request for mesos, Greg Mann,

Re: Review Request 46761: Slave/Agent Rename Phase I - Update terms in WebUI.

> On April 28, 2016, 5:18 p.m., Vinod Kone wrote: > > src/webui/master/static/js/app.js, lines 15-35 > > > > > > Hmm. Not sure if this is safe. We are renaming the URL paths. > > > > I think frameworks like

Review Request 46799: Added capabilities support to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46799/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 46370: Introduced linux capabilities API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/ --- (Updated April 28, 2016, 9:44 p.m.) Review request for mesos, Jie Yu and Kevin

Review Request 46798: Introduced linux capabilities support for mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46798/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 46763: Removed unused RepeatedPtrField in quota_handler.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46763/#review130932 --- src/master/quota_handler.cpp (line 21)

Re: Review Request 46736: Added authorization description to quota endpoint help.

> On April 27, 2016, 1:17 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, lines 1272-1274 > > > > > > Any reason you wrap it differently from other entries? It also looks like we indent by spaces, can

Re: Review Request 46783: Minor clarifications to HA framework guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46783/#review130935 --- Patch looks great! Reviews applied: [46779, 46780, 46781, 46782,

Re: Review Request 46781: Fixed invalid JSON in scheduler HTTP API examples.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46781/ --- (Updated April 28, 2016, 3:50 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 46761: Slave/Agent Rename Phase I - Update terms in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46761/#review130946 --- src/webui/master/static/js/app.js (lines 15 - 35)

Review Request 46792: Parameterized agent authorization tests by endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46792/ --- Review request for mesos, Adam B, Benjamin Bannier, and Jan Schlicht.

Review Request 46794: Unify POSIX and Windows `pstree` implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46794/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van

Re: Review Request 46424: Windows: Added libprocess to build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46424/ --- (Updated April 28, 2016, 5:47 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46763: Removed unused RepeatedPtrField in quota_handler.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46763/ --- (Updated 四月 28, 2016, 10:41 p.m.) Review request for mesos and Alexander

Review Request 46804: Patched glog to eliminate system-level gflag library detection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46804/ --- Review request for mesos, Kapil Arya and Vinod Kone. Repository: mesos

Re: Review Request 46804: Patched glog to eliminate system-level gflag library detection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46804/#review131012 --- 3rdparty/libprocess/3rdparty/glog-0.3.3.patch (line 197)

Re: Review Request 46804: Patched glog to eliminate system-level gflag library detection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46804/#review131014 --- Ship it! Ship It! - Vinod Kone On April 28, 2016, 11:32

Re: Review Request 45958: Updated protobuf Resource to mark the resource as shareable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45958/ --- (Updated April 29, 2016, 12:15 a.m.) Review request for mesos and Jiang Yan

Re: Review Request 46799: Added capabilities support to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46799/#review131021 --- src/cli/execute.cpp (lines 43 - 46)

Re: Review Request 46796: Synced endpoint documentation by running generation script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46796/#review131022 --- Patch looks great! Reviews applied: [46796] Passed command:

Re: Review Request 46761: Slave/Agent Rename Phase I - Update terms in WebUI.

> On 四月 28, 2016, 5:18 p.m., Vinod Kone wrote: > > src/webui/master/static/js/app.js, lines 15-35 > > > > > > Hmm. Not sure if this is safe. We are renaming the URL paths. > > > > I think frameworks like

Re: Review Request 46804: Patched glog to eliminate system-level gflag library detection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46804/ --- (Updated April 28, 2016, 11:55 p.m.) Review request for mesos, Kapil Arya and

Review Request 46805: Added backport of MESOS-5018 to 0.27.3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46805/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/#review130974 --- 3rdparty/libprocess/src/subprocess_windows.cpp (lines 534 - 539)

Review Request 46806: Fixed and illustrated process::initialize ordering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46806/ --- Review request for mesos, Greg Mann, Joerg Schad, Joris Van Remoortere, and

Review Request 46807: Simplified the rootfs preparation logic for command tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46807/ --- Review request for mesos, Gilbert Song, Ian Downes, and Joseph Wu. Repository:

Re: Review Request 46805: Added backport of MESOS-5018 to 0.27.3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46805/#review131019 --- Ship it! Ship It! - Kapil Arya On April 28, 2016, 7:38

Re: Review Request 45967: Added documentation for shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/ --- (Updated April 29, 2016, 12:16 a.m.) Review request for mesos and Jiang Yan

Re: Review Request 45966: Offer shareable resources to frameworks only if opted in.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45966/ --- (Updated April 29, 2016, 12:16 a.m.) Review request for mesos and Jiang Yan

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

> On April 9, 2016, 8:48 a.m., Guangya Liu wrote: > > src/common/resources.cpp, lines 296-304 > > > > > > Why not return false if the resource type is not `SCALAR` because only > > `SCALAR` was supportted for now

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

> On April 18, 2016, 6:09 a.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 56 > > > > > > Let's use a `class` just like Resources. As a `Resource` wrapper > > eventually most methods for single

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated April 29, 2016, 12:16 a.m.) Review request for mesos and Jiang Yan

Re: Review Request 45964: Add unit tests for sharing of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45964/ --- (Updated April 29, 2016, 12:16 a.m.) Review request for mesos and Jiang Yan

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45959/ --- (Updated April 29, 2016, 12:15 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 45960: Added interfaces to handle and track shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45960/ --- (Updated April 29, 2016, 12:16 a.m.) Review request for mesos and Jiang Yan

Re: Review Request 46804: Patched glog to eliminate system-level gflag library detection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46804/#review131010 --- Ship it! Ship It! - Kapil Arya On April 28, 2016, 7:32

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated April 29, 2016, 12:16 a.m.) Review request for mesos and Jiang Yan

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated April 29, 2016, 12:16 a.m.) Review request for mesos and Jiang Yan

Re: Review Request 46723: Send error message to the framework when it is not connected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46723/#review130967 --- Ship it! Ship It! - Vinod Kone On April 27, 2016, 11:37

Re: Review Request 46758: V1 API: Split Accept/Decline for offers and Inverse Offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46758/#review130973 --- Ship it! Ship It! - Vinod Kone On April 28, 2016, 1:22

Re: Review Request 46724: Added test to ensure calls from disconnected scheduler are dropped.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46724/#review130968 --- Ship it! Ship It! - Vinod Kone On April 27, 2016, 11:36

Re: Review Request 46757: V1 API: Split Rescind for offers and Inverse Offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46757/#review130972 --- src/messages/messages.proto (line 304)

Re: Review Request 46784: Added authorization of the '/flags' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46784/#review130961 --- Patch looks great! Reviews applied: [46784] Passed command:

Re: Review Request 46794: Unify POSIX and Windows `pstree` implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46794/ --- (Updated April 28, 2016, 6:26 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 46756: V1 API: Split Resource offers and Inverse Offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46756/#review130971 --- src/messages/messages.proto (line 267)

Re: Review Request 46799: Added capabilities support to mesos-execute.

> On April 29, 2016, 12:19 a.m., Qian Zhang wrote: > > src/cli/execute.cpp, lines 172-175 > > > > > > Can we only add this flag in Linux? Then user will not see this flag at > > all when running `mesos-execute` in

Re: Review Request 46669: Added deprecation support to Flag name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46669/#review130675 --- 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp

Re: Review Request 46807: Simplified the rootfs preparation logic for command tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46807/ --- (Updated April 29, 2016, 12:54 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 46763: Removed unused RepeatedPtrField in quota_handler.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46763/#review131027 --- Patch looks great! Reviews applied: [46763] Passed command:

Re: Review Request 46807: Simplified the rootfs preparation logic for command tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46807/ --- (Updated April 29, 2016, 1:19 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 46792: Parameterized agent authorization tests by endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46792/#review131034 --- Ship it! Ship It! - haosdent huang On April 28, 2016, 5:24

Re: Review Request 46806: Fixed and illustrated process::initialize ordering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46806/#review131036 --- Ship it! Ship It! - haosdent huang On April 28, 2016, 11:58

Re: Review Request 46806: Fixed and illustrated process::initialize ordering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46806/#review131039 --- Patch looks great! Reviews applied: [46806] Passed command:

Review Request 46814: Refactored FlagsBase::load().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46814/ --- Review request for mesos, Ben Mahler, Greg Mann, and Michael Park. Bugs:

Re: Review Request 46669: Added deprecation support to Flag name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46669/ --- (Updated April 29, 2016, 3:28 a.m.) Review request for mesos, Ben Mahler, Greg

Re: Review Request 46624: Added support to mesos to work with flag alias.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46624/ --- (Updated April 29, 2016, 3:27 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46670: Added deprecated alias for `--authenticate_frameworks` master flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46670/ --- (Updated April 29, 2016, 3:29 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46620: Refactored Flags to store name in `Name` struct instead of string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46620/ --- (Updated April 29, 2016, 3:24 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46622: Added tests for flag aliases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46622/ --- (Updated April 29, 2016, 3:26 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46621: Added alias support for flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46621/ --- (Updated April 29, 2016, 3:26 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46623: Updated libprocess to work with flag alias.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46623/ --- (Updated April 29, 2016, 3:27 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45967: Added documentation for shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/#review131047 --- Patch looks great! Reviews applied: [45958, 45959, 45960, 45961,

Review Request 46813: Update distribute to setuptools.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46813/ --- Review request for mesos, haosdent huang and Joseph Wu. Bugs: MESOS-5244

Review Request 46816: Fix the absolute symlink path issue of include/slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46816/ --- Review request for mesos, zhou xing and Vinod Kone. Repository: mesos

Re: Review Request 46807: Simplified the rootfs preparation logic for command tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46807/#review131051 --- Patch looks great! Reviews applied: [46807] Passed command:

Re: Review Request 46736: Added authorization description to quota endpoint help.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46736/#review130892 --- Ship it! Ship It! - Alexander Rojas On April 27, 2016, 5:17

Re: Review Request 46761: Slave/Agent Rename Phase I - Update terms in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46761/#review130893 --- Patch looks great! Reviews applied: [46761] Passed command:

Re: Review Request 46759: Updated Master to deal with Accept Offer vs InverseOffer correctly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46759/#review130976 --- src/master/master.cpp (line 3935)

Re: Review Request 46792: Parameterized agent authorization tests by endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46792/#review130979 --- Patch looks great! Reviews applied: [46792] Passed command:

Re: Review Request 46763: Removed unused RepeatedPtrField in quota_handler.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46763/#review130894 --- Patch looks great! Reviews applied: [46763] Passed command:

Re: Review Request 46424: Windows: Added libprocess to build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46424/#review130984 --- Bad patch! Reviews applied: [46424, 46794, 46608, 46423, 46422,